From f09a06575c6ae8c134a4b2b16076f5692089d131 Mon Sep 17 00:00:00 2001
From: Yegor Kozlov <yegor@apache.org>
Date: Fri, 10 Dec 2010 15:43:59 +0000
Subject: [PATCH] code cleanup as suggested in Bugzilla 50446

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1044405 13f79535-47bb-0310-9956-ffa450edef68
---
 src/documentation/content/xdocs/status.xml                  | 1 +
 src/java/org/apache/poi/hssf/record/SSTSerializer.java      | 1 -
 .../org/apache/poi/hssf/record/common/UnicodeString.java    | 2 +-
 .../org/apache/poi/hssf/usermodel/EscherGraphics2d.java     | 2 +-
 src/java/org/apache/poi/hssf/usermodel/FontDetails.java     | 6 +++---
 src/java/org/apache/poi/poifs/dev/POIFSHeaderDumper.java    | 2 +-
 src/java/org/apache/poi/util/POILogger.java                 | 2 +-
 .../org/apache/poi/hpsf/basic/TestMetaDataIPI.java          | 4 ++--
 .../poi/ss/util/NumberRenderingSpreadsheetGenerator.java    | 2 +-
 src/testcases/org/apache/poi/util/DummyPOILogger.java       | 4 ++--
 10 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml
index f12010238..9ee283fcb 100644
--- a/src/documentation/content/xdocs/status.xml
+++ b/src/documentation/content/xdocs/status.xml
@@ -34,6 +34,7 @@
 
     <changes>
         <release version="3.8-beta1" date="2010-??-??">
+           <action dev="POI-DEVELOPERS" type="add">50446 - Code cleanup and optimizations to keep some IDE quiet</action>
            <action dev="POI-DEVELOPERS" type="add">50437 - Support passing ranges to NPV()</action>
            <action dev="POI-DEVELOPERS" type="add">50409 - Added implementation for IRR()</action>
            <action dev="poi-developers" type="add">47405 - Improved performance of RowRecordsAggregate.getStartRowNumberForBlock / getEndRowNumberForBlock</action>
diff --git a/src/java/org/apache/poi/hssf/record/SSTSerializer.java b/src/java/org/apache/poi/hssf/record/SSTSerializer.java
index 44980f54e..c15c7ad1f 100644
--- a/src/java/org/apache/poi/hssf/record/SSTSerializer.java
+++ b/src/java/org/apache/poi/hssf/record/SSTSerializer.java
@@ -38,7 +38,6 @@ final class SSTSerializer {
     private final int[] bucketAbsoluteOffsets;
     /** Offsets relative the start of the current SST or continue record */
     private final int[] bucketRelativeOffsets;
-    int startOfSST, startOfRecord;
 
     public SSTSerializer( IntMapper<UnicodeString> strings, int numStrings, int numUniqueStrings )
     {
diff --git a/src/java/org/apache/poi/hssf/record/common/UnicodeString.java b/src/java/org/apache/poi/hssf/record/common/UnicodeString.java
index 235d54709..3d0813c87 100644
--- a/src/java/org/apache/poi/hssf/record/common/UnicodeString.java
+++ b/src/java/org/apache/poi/hssf/record/common/UnicodeString.java
@@ -266,7 +266,7 @@ public class UnicodeString implements Comparable<UnicodeString> { // TODO - make
           ext.formattingFontIndex = formattingFontIndex;
           ext.formattingOptions = formattingOptions;
           ext.numberOfRuns = numberOfRuns;
-          ext.phoneticText = new String(phoneticText);
+          ext.phoneticText = phoneticText;
           ext.phRuns = new PhRun[phRuns.length];
           for(int i=0; i<ext.phRuns.length; i++) {
              ext.phRuns[i] = new PhRun(
diff --git a/src/java/org/apache/poi/hssf/usermodel/EscherGraphics2d.java b/src/java/org/apache/poi/hssf/usermodel/EscherGraphics2d.java
index 41b94ffd4..1dff3d8ed 100644
--- a/src/java/org/apache/poi/hssf/usermodel/EscherGraphics2d.java
+++ b/src/java/org/apache/poi/hssf/usermodel/EscherGraphics2d.java
@@ -308,7 +308,7 @@ public final class EscherGraphics2d extends Graphics2D {
 
     public void drawString(AttributedCharacterIterator attributedcharacteriterator, int x, int y)
     {
-        drawString(attributedcharacteriterator, x, y);
+        getEscherGraphics().drawString(attributedcharacteriterator, x, y);
     }
 
     public void fill(Shape shape)
diff --git a/src/java/org/apache/poi/hssf/usermodel/FontDetails.java b/src/java/org/apache/poi/hssf/usermodel/FontDetails.java
index f9b2bc813..073bcba5d 100644
--- a/src/java/org/apache/poi/hssf/usermodel/FontDetails.java
+++ b/src/java/org/apache/poi/hssf/usermodel/FontDetails.java
@@ -57,7 +57,7 @@ public class FontDetails
 
     public void addChar( char c, int width )
     {
-        charWidths.put(new Character(c), Integer.valueOf(width));
+        charWidths.put(Character.valueOf(c), Integer.valueOf(width));
     }
 
     /**
@@ -67,7 +67,7 @@ public class FontDetails
      */
     public int getCharWidth( char c )
     {
-        Integer widthInteger = charWidths.get(new Character(c));
+        Integer widthInteger = charWidths.get(Character.valueOf(c));
         if (widthInteger == null && c != 'W') {
             return getCharWidth('W');
         }
@@ -78,7 +78,7 @@ public class FontDetails
     {
         for ( int i = 0; i < characters.length; i++ )
         {
-            charWidths.put( new Character(characters[i]), Integer.valueOf(widths[i]));
+            charWidths.put( Character.valueOf(characters[i]), Integer.valueOf(widths[i]));
         }
     }
 
diff --git a/src/java/org/apache/poi/poifs/dev/POIFSHeaderDumper.java b/src/java/org/apache/poi/poifs/dev/POIFSHeaderDumper.java
index 75f69caeb..7a6b187fe 100644
--- a/src/java/org/apache/poi/poifs/dev/POIFSHeaderDumper.java
+++ b/src/java/org/apache/poi/poifs/dev/POIFSHeaderDumper.java
@@ -123,7 +123,7 @@ public class POIFSHeaderDumper {
       gbm.setAccessible(true);
       
       for(int i=0; i<Math.min(16, data_blocks.blockCount()); i++) {
-         ListManagedBlock block = (ListManagedBlock)gbm.invoke(data_blocks, new Integer(i));
+         ListManagedBlock block = (ListManagedBlock)gbm.invoke(data_blocks, Integer.valueOf(i));
          byte[] data = new byte[Math.min(48, block.getData().length)];
          System.arraycopy(block.getData(), 0, data, 0, data.length);
          
diff --git a/src/java/org/apache/poi/util/POILogger.java b/src/java/org/apache/poi/util/POILogger.java
index 241196ec6..cf722c465 100644
--- a/src/java/org/apache/poi/util/POILogger.java
+++ b/src/java/org/apache/poi/util/POILogger.java
@@ -610,7 +610,7 @@ public abstract class POILogger {
 
             for (int j = 0; j < array.length; j++)
             {
-                results.add(new Character(array[ j ]));
+                results.add(Character.valueOf(array[ j ]));
             }
         }
         else if (object instanceof short [])
diff --git a/src/testcases/org/apache/poi/hpsf/basic/TestMetaDataIPI.java b/src/testcases/org/apache/poi/hpsf/basic/TestMetaDataIPI.java
index 7f579c83c..9fb58081f 100644
--- a/src/testcases/org/apache/poi/hpsf/basic/TestMetaDataIPI.java
+++ b/src/testcases/org/apache/poi/hpsf/basic/TestMetaDataIPI.java
@@ -383,7 +383,7 @@ public final class TestMetaDataIPI extends TestCase{
 			j += 33;
 			// System.out.println(j);
 			sb.append(">");
-			sb.append(new Character(j));
+			sb.append(Character.valueOf(j));
 			sb.append("=");
 			sb.append(umlaute[rand.nextInt(umlaute.length)]);
 			sb.append("<");
@@ -509,7 +509,7 @@ public final class TestMetaDataIPI extends TestCase{
 			j += 33;
 			// System.out.println(j);
 			sb.append(">");
-			sb.append(new Character(j));
+			sb.append(Character.valueOf(j));
 			sb.append("=");
 			sb.append(umlaute[rand.nextInt(umlaute.length)]);
 			sb.append("<");
diff --git a/src/testcases/org/apache/poi/ss/util/NumberRenderingSpreadsheetGenerator.java b/src/testcases/org/apache/poi/ss/util/NumberRenderingSpreadsheetGenerator.java
index a03bfb084..c074c9737 100644
--- a/src/testcases/org/apache/poi/ss/util/NumberRenderingSpreadsheetGenerator.java
+++ b/src/testcases/org/apache/poi/ss/util/NumberRenderingSpreadsheetGenerator.java
@@ -63,7 +63,7 @@ public class NumberRenderingSpreadsheetGenerator {
 		public void addTestRow(long rawBits, String expectedExcelRendering) {
 			writeDataRow(_sheet, _rowIndex++, rawBits, expectedExcelRendering);
 			if(Double.isNaN(Double.longBitsToDouble(rawBits))) {
-				_replacementNaNs.add(new Long(rawBits));
+				_replacementNaNs.add(Long.valueOf(rawBits));
 			}
 		}
 
diff --git a/src/testcases/org/apache/poi/util/DummyPOILogger.java b/src/testcases/org/apache/poi/util/DummyPOILogger.java
index 7efbfac29..f72e37b51 100644
--- a/src/testcases/org/apache/poi/util/DummyPOILogger.java
+++ b/src/testcases/org/apache/poi/util/DummyPOILogger.java
@@ -37,10 +37,10 @@ public class DummyPOILogger extends POILogger {
 	public void initialize(String cat) {}
 
 	public void log(int level, Object obj1) {
-		logged.add(new String(level + " - " + obj1));
+		logged.add(level + " - " + obj1);
 	}
 
 	public void log(int level, Object obj1, Throwable exception) {
-		logged.add(new String(level + " - " + obj1 + " - " + exception));
+		logged.add(level + " - " + obj1 + " - " + exception);
 	}
 }