moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

bug 58740: add @Internal annotations and decrease access level to methods that only exist for unit testing

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721864 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2015-12-28 00:52:47 +00:00
parent 19e5db9602
commit ec4732a034
1 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java
View File

@ -37,6 +37,7 @@ import org.apache.poi.ss.SpreadsheetVersion;
import org.apache.poi.ss.usermodel.BuiltinFormats; import org.apache.poi.ss.usermodel.BuiltinFormats;
import org.apache.poi.ss.usermodel.FontFamily; import org.apache.poi.ss.usermodel.FontFamily;
import org.apache.poi.ss.usermodel.FontScheme; import org.apache.poi.ss.usermodel.FontScheme;
import org.apache.poi.util.Internal;
import org.apache.poi.xssf.usermodel.XSSFCellStyle; import org.apache.poi.xssf.usermodel.XSSFCellStyle;
import org.apache.poi.xssf.usermodel.XSSFFactory; import org.apache.poi.xssf.usermodel.XSSFFactory;
import org.apache.poi.xssf.usermodel.XSSFFont; import org.apache.poi.xssf.usermodel.XSSFFont;
@ -326,25 +327,35 @@ public class StylesTable extends POIXMLDocumentPart {
return fills.size() - 1; return fills.size() - 1;
} }
@Internal
public CTXf getCellXfAt(int idx) { public CTXf getCellXfAt(int idx) {
return xfs.get(idx); return xfs.get(idx);
} }
@Internal
public int putCellXf(CTXf cellXf) { public int putCellXf(CTXf cellXf) {
xfs.add(cellXf); xfs.add(cellXf);
return xfs.size(); return xfs.size();
} }
@Internal
public void replaceCellXfAt(int idx, CTXf cellXf) { public void replaceCellXfAt(int idx, CTXf cellXf) {
xfs.set(idx, cellXf); xfs.set(idx, cellXf);
} }
@Internal
public CTXf getCellStyleXfAt(int idx) { public CTXf getCellStyleXfAt(int idx) {
return idx < styleXfs.size() ? styleXfs.get(idx) : null; return idx < styleXfs.size() ? styleXfs.get(idx) : null;
} }
@Internal
public int putCellStyleXf(CTXf cellStyleXf) { public int putCellStyleXf(CTXf cellStyleXf) {
styleXfs.add(cellStyleXf); styleXfs.add(cellStyleXf);
return styleXfs.size(); return styleXfs.size();
} }
public void replaceCellStyleXfAt(int idx, CTXf cellStyleXf) {
@Internal
protected void replaceCellStyleXfAt(int idx, CTXf cellStyleXf) {
styleXfs.set(idx, cellStyleXf); styleXfs.set(idx, cellStyleXf);
} }
@ -360,6 +371,7 @@ public class StylesTable extends POIXMLDocumentPart {
/** /**
* For unit testing only * For unit testing only
*/ */
@Internal
public int _getNumberFormatSize() { public int _getNumberFormatSize() {
return numberFormats.size(); return numberFormats.size();
} }
@ -367,21 +379,27 @@ public class StylesTable extends POIXMLDocumentPart {
/** /**
* For unit testing only * For unit testing only
*/ */
public int _getXfsSize() { @Internal
/*package*/ int _getXfsSize() {
return xfs.size(); return xfs.size();
} }
/** /**
* For unit testing only * For unit testing only
*/ */
@Internal
public int _getStyleXfsSize() { public int _getStyleXfsSize() {
return styleXfs.size(); return styleXfs.size();
} }
/** /**
* For unit testing only! * For unit testing only!
*/ */
@Internal
public CTStylesheet getCTStylesheet() { public CTStylesheet getCTStylesheet() {
return doc.getStyleSheet(); return doc.getStyleSheet();
} }
@Internal
public int _getDXfsSize() { public int _getDXfsSize() {
return dxfs.size(); return dxfs.size();
} }
@ -553,15 +571,22 @@ public class StylesTable extends POIXMLDocumentPart {
return xssfFont; return xssfFont;
} }
@Internal
public CTDxf getDxfAt(int idx) { public CTDxf getDxfAt(int idx) {
return dxfs.get(idx); return dxfs.get(idx);
} }
@Internal
public int putDxf(CTDxf dxf) { public int putDxf(CTDxf dxf) {
this.dxfs.add(dxf); this.dxfs.add(dxf);
return this.dxfs.size(); return this.dxfs.size();
} }
/**
* Create a cell style in this style table.
* Note - End users probably want to call {@link XSSFWorkbook#createCellStyle()}
* rather than working with the styles table directly.
*/
public XSSFCellStyle createCellStyle() { public XSSFCellStyle createCellStyle() {
if (getNumCellStyles() > MAXIMUM_STYLE_ID) { if (getNumCellStyles() > MAXIMUM_STYLE_ID) {
throw new IllegalStateException("The maximum number of Cell Styles was exceeded. " + throw new IllegalStateException("The maximum number of Cell Styles was exceeded. " +