moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

make class attributes final; return unmodifiable lists

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751182 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-07-03 23:23:54 +00:00
parent 57033b6a9e
commit b6fe670114
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/scratchpad/src/org/apache/poi/hmef/HMEFMessage.java
View File

@ -20,6 +20,7 @@ package org.apache.poi.hmef;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collections;
import java.util.List; import java.util.List;
import org.apache.poi.hmef.attribute.MAPIAttribute; import org.apache.poi.hmef.attribute.MAPIAttribute;
@ -41,10 +42,11 @@ import org.apache.poi.util.LittleEndian;
public final class HMEFMessage { public final class HMEFMessage {
public static final int HEADER_SIGNATURE = 0x223e9f78; public static final int HEADER_SIGNATURE = 0x223e9f78;
@SuppressWarnings("unused")
private int fileId; private int fileId;
private List<TNEFAttribute> messageAttributes = new ArrayList<TNEFAttribute>(); private final List<TNEFAttribute> messageAttributes = new ArrayList<TNEFAttribute>();
private List<MAPIAttribute> mapiAttributes = new ArrayList<MAPIAttribute>(); private final List<MAPIAttribute> mapiAttributes = new ArrayList<MAPIAttribute>();
private List<Attachment> attachments = new ArrayList<Attachment>(); private final List<Attachment> attachments = new ArrayList<Attachment>();
public HMEFMessage(InputStream inp) throws IOException { public HMEFMessage(InputStream inp) throws IOException {
try { try {
@ -125,7 +127,7 @@ public final class HMEFMessage {
* are stored as {@link MAPIAttribute}s - see {@link #getMessageMAPIAttributes()} * are stored as {@link MAPIAttribute}s - see {@link #getMessageMAPIAttributes()}
*/ */
public List<TNEFAttribute> getMessageAttributes() { public List<TNEFAttribute> getMessageAttributes() {
return messageAttributes; return Collections.unmodifiableList(messageAttributes);
} }
/** /**
@ -134,14 +136,14 @@ public final class HMEFMessage {
* apply to most messages, see {@link #getMessageAttributes()} * apply to most messages, see {@link #getMessageAttributes()}
*/ */
public List<MAPIAttribute> getMessageMAPIAttributes() { public List<MAPIAttribute> getMessageMAPIAttributes() {
return mapiAttributes; return Collections.unmodifiableList(mapiAttributes);
} }
/** /**
* Returns all the Attachments of the message. * Returns all the Attachments of the message.
*/ */
public List<Attachment> getAttachments() { public List<Attachment> getAttachments() {
return attachments; return Collections.unmodifiableList(attachments);
} }
/** /**