moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Fix bug #46664 - When creating HSSF Print Areas, ensure the named range is reference based not value based

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1069780 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Nick Burch 2011-02-11 12:36:57 +00:00
parent d1aab350fd
commit b048b8422a
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/documentation/content/xdocs/status.xml
View File

@ -34,6 +34,7 @@
<changes> <changes>
<release version="3.8-beta1" date="2010-??-??"> <release version="3.8-beta1" date="2010-??-??">
<action dev="poi-developers" type="fix">46664 - When creating HSSF Print Areas, ensure the named range is reference based not value based</action>
<action dev="poi-developers" type="fix">50756 - When formatting numbers based on their Cell Style, treat GENERAL the same as the more typical General</action> <action dev="poi-developers" type="fix">50756 - When formatting numbers based on their Cell Style, treat GENERAL the same as the more typical General</action>
<action dev="poi-developers" type="fix">fixed HSSFWorkbook.createCellStyle to throw exception if the maximum number of cell styles was exceeded</action> <action dev="poi-developers" type="fix">fixed HSSFWorkbook.createCellStyle to throw exception if the maximum number of cell styles was exceeded</action>
<action dev="poi-developers" type="fix">50539 - Better fix for html-style br tags (invalid XML) inside XSSF documents</action> <action dev="poi-developers" type="fix">50539 - Better fix for html-style br tags (invalid XML) inside XSSF documents</action>

2
src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
View File

@ -1389,7 +1389,7 @@ public final class HSSFWorkbook extends POIDocument implements org.apache.poi.ss
sb.append("!"); sb.append("!");
sb.append(parts[i]); sb.append(parts[i]);
} }
name.setNameDefinition(HSSFFormulaParser.parse(sb.toString(), this, FormulaType.CELL, sheetIndex)); name.setNameDefinition(HSSFFormulaParser.parse(sb.toString(), this, FormulaType.NAMEDRANGE, sheetIndex));
} }
/** /**

3
src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
View File

@ -1650,10 +1650,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
"new_sheet!$A$1:$C$1", "new_sheet!$A$1:$C$1",
((Area3DPtg)nr.getNameDefinition()[0]).toFormulaString(HSSFEvaluationWorkbook.create(wb)) ((Area3DPtg)nr.getNameDefinition()[0]).toFormulaString(HSSFEvaluationWorkbook.create(wb))
); );
// TODO - fix me to be Reference not Value!
if(1==2) {
assertEquals('R', nr.getNameDefinition()[0].getRVAType()); assertEquals('R', nr.getNameDefinition()[0].getRVAType());
}
} }
/** /**