moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Remove commented out System.out calls / Move DummyGraphics2d to testcase area, as it's not used by production code

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1846946 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andreas Beeker 2018-11-19 20:48:10 +00:00
parent 0beee42a19
commit af5b9d959c
8 changed files with 14 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/java/org/apache/poi/hssf/eventusermodel/MissingRecordAwareHSSFListener.java
View File

@ -94,8 +94,6 @@ public final class MissingRecordAwareHSSFListener implements HSSFListener {
break;
case RowRecord.sid:
RowRecord rowrec = (RowRecord) record;
//System.out.println("Row " + rowrec.getRowNumber() + " found, first column at "
// + rowrec.getFirstCol() + " last column at " + rowrec.getLastCol());
// If there's a jump in rows, fire off missing row records
if (lastRowRow + 1 < rowrec.getRowNumber()) {

11
src/java/org/apache/poi/hssf/record/UnknownRecord.java
View File

@ -80,13 +80,10 @@ public final class UnknownRecord extends StandardRecord {
public UnknownRecord(RecordInputStream in) {
_sid = in.getSid();
_rawData = in.readRemainder();
// if (false && getBiffName(_sid) == null) {
// // unknown sids in the range 0x0004-0x0013 are probably 'sub-records' of ObjectRecord
// // those sids are in a different number space.
// // TODO - put unknown OBJ sub-records in a different class
// System.out.println("Unknown record 0x" +
// Integer.toHexString(_sid).toUpperCase(Locale.ROOT));
// }
// TODO - put unknown OBJ sub-records in a different class
// unknown sids in the range 0x0004-0x0013 are probably 'sub-records' of ObjectRecord
// those sids are in a different number space.
}
/**

22
src/java/org/apache/poi/ss/formula/Formula.java
View File

@ -48,19 +48,15 @@ public class Formula {
private Formula(byte[] byteEncoding, int encodedTokenLen) {
_byteEncoding = byteEncoding.clone();
_encodedTokenLen = encodedTokenLen;
// if (false) { // set to true to eagerly check Ptg decoding
// LittleEndianByteArrayInputStream in = new LittleEndianByteArrayInputStream(byteEncoding);
// Ptg.readTokens(encodedTokenLen, in);
// int nUnusedBytes = _byteEncoding.length - in.getReadIndex();
// if (nUnusedBytes > 0) {
// // TODO - this seems to occur when IntersectionPtg is present
// // This example file "IntersectionPtg.xls"
// // used by test: TestIntersectionPtg.testReading()
// // has 10 bytes unused at the end of the formula
// // 10 extra bytes are just 0x01 and 0x00
// System.out.println(nUnusedBytes + " unused bytes at end of formula");
// }
// }
// TODO - this seems to occur when IntersectionPtg is present
// This example file "IntersectionPtg.xls"
// used by test: TestIntersectionPtg.testReading()
// has 10 bytes unused at the end of the formula
// 10 extra bytes are just 0x01 and 0x00
// LittleEndianByteArrayInputStream in = new LittleEndianByteArrayInputStream(byteEncoding);
// Ptg.readTokens(encodedTokenLen, in);
// int nUnusedBytes = _byteEncoding.length - in.getReadIndex();
}
/**
* Convenience method for {@link #read(int, LittleEndianInput, int)}

1
src/java/org/apache/poi/ss/formula/FormulaParser.java
View File

@ -234,7 +234,6 @@ public final class FormulaParser {
_inIntersection = false;
}
_pointer += Character.charCount(look);
//System.out.println(new StringBuilder("Got char: ").appendCodePoint(look)).toString();
}
private void resetPointer(int ptr) {
_pointer = ptr;

3
src/java/org/apache/poi/ss/formula/eval/OperandResolver.java
View File

@ -88,8 +88,7 @@ public final class OperandResolver {
CellRangeAddress range = cell.getArrayFormulaRange();
int relativeRowIndex = cell.getRowIndex() - range.getFirstRow();
int relativeColIndex = cell.getColumnIndex() - range.getFirstColumn();
//System.out.println("Row: " + relativeRowIndex + " Col: " + relativeColIndex);
if (ae.isColumn()) {
if (ae.isRow()) {
return ae.getRelativeValue(0, 0);

1
src/java/org/apache/poi/ss/usermodel/DataFormatter.java
View File

@ -450,7 +450,6 @@ public class DataFormatter implements Observer {
// Strip custom text in quotes and escaped characters for now as it can cause performance problems in fractions.
//String strippedFormatStr = formatStr.replaceAll("\\\\ ", " ").replaceAll("\\\\.", "").replaceAll("\"[^\"]*\"", " ").replaceAll("\\?", "#");
//System.out.println("formatStr: "+strippedFormatStr);
return new FractionFormat(defaultFractionWholePartFormat, defaultFractionFractionPartFormat);
}

1
src/scratchpad/src/org/apache/poi/hslf/record/Notes.java
View File

@ -63,7 +63,6 @@ public final class Notes extends SheetContainer
for(int i=0; i<_children.length; i++) {
if(_children[i] instanceof NotesAtom) {
notesAtom = (NotesAtom)_children[i];
//System.out.println("Found notes for sheet " + notesAtom.getSlideID());
}
if(_children[i] instanceof PPDrawing) {
ppDrawing = (PPDrawing)_children[i];

0
src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java → src/testcases/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
View File