moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

FindBugs fixes - MS_SHOULD_BE_FINAL

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693984 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andreas Beeker 2015-08-03 23:36:28 +00:00
parent 0a42120b89
commit adfcf4d251
5 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/java/org/apache/poi/poifs/crypt/EncryptionInfo.java
View File

@ -48,25 +48,25 @@ public class EncryptionInfo {
* A flag that specifies whether CryptoAPI RC4 or ECMA-376 encryption * A flag that specifies whether CryptoAPI RC4 or ECMA-376 encryption
* ECMA-376 is used. It MUST be 1 unless flagExternal is 1. If flagExternal is 1, it MUST be 0. * ECMA-376 is used. It MUST be 1 unless flagExternal is 1. If flagExternal is 1, it MUST be 0.
*/ */
public static BitField flagCryptoAPI = BitFieldFactory.getInstance(0x04); public static final BitField flagCryptoAPI = BitFieldFactory.getInstance(0x04);
/** /**
* A value that MUST be 0 if document properties are encrypted. * A value that MUST be 0 if document properties are encrypted.
* The encryption of document properties is specified in section 2.3.5.4. * The encryption of document properties is specified in section 2.3.5.4.
*/ */
public static BitField flagDocProps = BitFieldFactory.getInstance(0x08); public static final BitField flagDocProps = BitFieldFactory.getInstance(0x08);
/** /**
* A value that MUST be 1 if extensible encryption is used. If this value is 1, * A value that MUST be 1 if extensible encryption is used. If this value is 1,
* the value of every other field in this structure MUST be 0. * the value of every other field in this structure MUST be 0.
*/ */
public static BitField flagExternal = BitFieldFactory.getInstance(0x10); public static final BitField flagExternal = BitFieldFactory.getInstance(0x10);
/** /**
* A value that MUST be 1 if the protected content is an ECMA-376 document * A value that MUST be 1 if the protected content is an ECMA-376 document
* ECMA-376. If the fAES bit is 1, the fCryptoAPI bit MUST also be 1. * ECMA-376. If the fAES bit is 1, the fCryptoAPI bit MUST also be 1.
*/ */
public static BitField flagAES = BitFieldFactory.getInstance(0x20); public static final BitField flagAES = BitFieldFactory.getInstance(0x20);
/** /**

2
src/java/org/apache/poi/sl/draw/DrawFactory.java
View File

@ -42,7 +42,7 @@ import org.apache.poi.sl.usermodel.TextRun;
import org.apache.poi.sl.usermodel.TextShape; import org.apache.poi.sl.usermodel.TextShape;
public class DrawFactory { public class DrawFactory {
protected static ThreadLocal<DrawFactory> defaultFactory = new ThreadLocal<DrawFactory>(); protected static final ThreadLocal<DrawFactory> defaultFactory = new ThreadLocal<DrawFactory>();
/** /**
* Set a custom draw factory for the current thread. * Set a custom draw factory for the current thread.

10
src/ooxml/java/org/apache/poi/xssf/util/NumericRanges.java
View File

@ -19,11 +19,11 @@ package org.apache.poi.xssf.util;
public class NumericRanges { public class NumericRanges {
public static int NO_OVERLAPS = -1; public static final int NO_OVERLAPS = -1;
public static int OVERLAPS_1_MINOR = 0; public static final int OVERLAPS_1_MINOR = 0;
public static int OVERLAPS_2_MINOR = 1; public static final int OVERLAPS_2_MINOR = 1;
public static int OVERLAPS_1_WRAPS = 2; public static final int OVERLAPS_1_WRAPS = 2;
public static int OVERLAPS_2_WRAPS = 3; public static final int OVERLAPS_2_WRAPS = 3;
public static long[] getOverlappingRange(long[] range1, long[] range2) { public static long[] getOverlappingRange(long[] range1, long[] range2) {
int overlappingType = getOverlappingType(range1, range2); int overlappingType = getOverlappingType(range1, range2);

2
src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFNotes.java
View File

@ -33,7 +33,7 @@ import org.apache.poi.util.POILogger;
*/ */
public final class HSLFNotes extends HSLFSheet implements Notes<HSLFShape, HSLFSlideShow> { public final class HSLFNotes extends HSLFSheet implements Notes<HSLFShape, HSLFSlideShow> {
protected static POILogger logger = POILogFactory.getLogger(HSLFNotes.class); protected static final POILogger logger = POILogFactory.getLogger(HSLFNotes.class);
private List<List<HSLFTextParagraph>> _paragraphs = new ArrayList<List<HSLFTextParagraph>>(); private List<List<HSLFTextParagraph>> _paragraphs = new ArrayList<List<HSLFTextParagraph>>();

2
src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java
View File

@ -40,7 +40,7 @@ import org.apache.poi.util.*;
*/ */
public final class HSLFTextParagraph implements TextParagraph<HSLFTextRun> { public final class HSLFTextParagraph implements TextParagraph<HSLFTextRun> {
protected static POILogger logger = POILogFactory.getLogger(HSLFTextParagraph.class); protected static final POILogger logger = POILogFactory.getLogger(HSLFTextParagraph.class);
/** /**
* How to align the text * How to align the text