From a350f399f5eeb50eff4e72c0b48304998c42666a Mon Sep 17 00:00:00 2001 From: Dominik Stadler Date: Mon, 24 Oct 2016 12:07:15 +0000 Subject: [PATCH] Allow more time for a unit-test when running on slow Gump VM git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766397 13f79535-47bb-0310-9956-ffa450edef68 --- build.xml | 1 + .../xssf/usermodel/TestXSSFSheetMergeRegions.java | 12 ++++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/build.xml b/build.xml index bdf0033f3..531ce6a30 100644 --- a/build.xml +++ b/build.xml @@ -300,6 +300,7 @@ under the License. + diff --git a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java index 88530dc03..fb7a9c0b0 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java @@ -41,9 +41,17 @@ public class TestXSSFSheetMergeRegions { } System.out.println("Retry " + i + " because run-time is too high: " + millis); } - + + boolean inGump = false; + String version = System.getProperty("version.id"); + if(version != null && version.startsWith("gump-")) { + inGump = true; + } + // This time is typically ~800ms, versus ~7800ms to iterate getMergedRegion(int). - assertTrue("Should have taken <2000 ms to iterate 50k merged regions but took " + millis, millis < 2000); + // when running in Gump, the VM is very slow, so we should allow much more time + assertTrue("Should have taken <2000 ms to iterate 50k merged regions but took " + millis, + inGump ? millis < 8000 : millis < 2000); } finally { wb.close(); }