From 9ca89c22782741352227a38528055b1b942f1e94 Mon Sep 17 00:00:00 2001 From: Javen O'Neal Date: Sat, 11 Jun 2016 01:41:54 +0000 Subject: [PATCH] add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java b/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java index aa04f3b8d..a0da336d7 100644 --- a/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java +++ b/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java @@ -71,6 +71,7 @@ public final class AnalysisToolPak implements UDFFinder { // if you save such a .xlsx workbook as .xls if(name.startsWith("_xlfn.")) name = name.substring(6); + // FIXME: inconsistent case-sensitivity return _functionsByName.get(name.toUpperCase(Locale.ROOT)); } @@ -197,6 +198,7 @@ public final class AnalysisToolPak implements UDFFinder { public static boolean isATPFunction(String name){ AnalysisToolPak inst = (AnalysisToolPak)instance; + // FIXME: inconsistent case-sensitivity return inst._functionsByName.containsKey(name); } @@ -261,6 +263,7 @@ public final class AnalysisToolPak implements UDFFinder { ". You cannot override POI's implementations of Excel functions"); } + // FIXME: inconsistent case-sensitivity inst._functionsByName.put(name, func); } }