moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

fixed XSSFSheet.setColumnWidth to produce XML compatible with Mac Excel 2008, see Bugzilla 47581

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@814358 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Yegor Kozlov 2009-09-13 17:49:46 +00:00
parent bd966f208b
commit 8ca7addc26
3 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/documentation/content/xdocs/status.xml
View File

@ -33,6 +33,7 @@
<changes> <changes>
<release version="3.5-beta7" date="2009-??-??"> <release version="3.5-beta7" date="2009-??-??">
<action dev="POI-DEVELOPERS" type="fix">47581 - fixed XSSFSheet.setColumnWidth to produce XML compatible with Mac Excel 2008</action>
<action dev="POI-DEVELOPERS" type="fix">47734 - removed unnecessary svn:executable flag from files in SVN trunk</action> <action dev="POI-DEVELOPERS" type="fix">47734 - removed unnecessary svn:executable flag from files in SVN trunk</action>
<action dev="POI-DEVELOPERS" type="fix">47543 - added javadoc how to avoid Excel crash when creating too many HSSFRichTextString cells</action> <action dev="POI-DEVELOPERS" type="fix">47543 - added javadoc how to avoid Excel crash when creating too many HSSFRichTextString cells</action>
<action dev="POI-DEVELOPERS" type="fix">47813 - fixed problems with XSSFWorkbook.removeSheetAt when workbook contains chart</action> <action dev="POI-DEVELOPERS" type="fix">47813 - fixed problems with XSSFWorkbook.removeSheetAt when workbook contains chart</action>

1
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
View File

@ -1675,6 +1675,7 @@ public class XSSFSheet extends POIXMLDocumentPart implements Sheet {
if(width > 255*256) throw new IllegalArgumentException("The maximum column width for an individual cell is 255 characters."); if(width > 255*256) throw new IllegalArgumentException("The maximum column width for an individual cell is 255 characters.");
columnHelper.setColWidth(columnIndex, (double)width/256); columnHelper.setColWidth(columnIndex, (double)width/256);
columnHelper.setCustomWidth(columnIndex, true);
} }
public void setDefaultColumnStyle(int column, CellStyle style) { public void setDefaultColumnStyle(int column, CellStyle style) {

3
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheet.java
View File

@ -695,6 +695,7 @@ public class TestXSSFSheet extends BaseTestSheet {
assertEquals(2, col.getMin()); assertEquals(2, col.getMin());
assertEquals(2, col.getMax()); assertEquals(2, col.getMax());
assertEquals(22.0, col.getWidth(), 0.0); assertEquals(22.0, col.getWidth(), 0.0);
assertTrue(col.getCustomWidth());
// Now set another // Now set another
sheet.setColumnWidth(3, 33 * 256); sheet.setColumnWidth(3, 33 * 256);
@ -708,10 +709,12 @@ public class TestXSSFSheet extends BaseTestSheet {
assertEquals(2, col.getMin()); // POI 1 assertEquals(2, col.getMin()); // POI 1
assertEquals(2, col.getMax()); assertEquals(2, col.getMax());
assertEquals(22.0, col.getWidth(), 0.0); assertEquals(22.0, col.getWidth(), 0.0);
assertTrue(col.getCustomWidth());
col = cols.getColArray(1); col = cols.getColArray(1);
assertEquals(4, col.getMin()); // POI 3 assertEquals(4, col.getMin()); // POI 3
assertEquals(4, col.getMax()); assertEquals(4, col.getMax());
assertEquals(33.0, col.getWidth(), 0.0); assertEquals(33.0, col.getWidth(), 0.0);
assertTrue(col.getCustomWidth());
} }
} }