From 8c5115aeb15a500af21306fce606ca0842363024 Mon Sep 17 00:00:00 2001 From: Dominik Stadler Date: Sat, 8 Mar 2014 08:41:25 +0000 Subject: [PATCH] Fix Sonar issues about finalize() usage git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/poi/hssf/usermodel/DummyGraphics2d.java | 8 +++++--- .../org/apache/poi/xssf/streaming/SheetDataWriter.java | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java b/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java index 41393d1a5..f2e2325da 100644 --- a/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java +++ b/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java @@ -19,16 +19,16 @@ package org.apache.poi.hssf.usermodel; import java.awt.*; +import java.awt.font.FontRenderContext; +import java.awt.font.GlyphVector; import java.awt.geom.AffineTransform; import java.awt.image.BufferedImage; import java.awt.image.BufferedImageOp; import java.awt.image.ImageObserver; import java.awt.image.RenderedImage; import java.awt.image.renderable.RenderableImage; -import java.awt.font.GlyphVector; -import java.awt.font.FontRenderContext; -import java.util.Map; import java.text.AttributedCharacterIterator; +import java.util.Map; public class DummyGraphics2d extends Graphics2D @@ -675,6 +675,8 @@ public class DummyGraphics2d public void finalize() { System.out.println( "finalize():" ); g2D.finalize(); + + super.finalize(); } public Shape getClip() diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java index 43f7e72e6..95f8f515a 100644 --- a/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java +++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java @@ -127,6 +127,8 @@ public class SheetDataWriter { @Override protected void finalize() throws Throwable { _fd.delete(); + + super.finalize(); } /**