moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

If a NoteRecord has no author tag, it seems it can sometimes be double padded. Fixes #47251

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597098 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Nick Burch 2014-05-23 14:07:20 +00:00
parent 6cc94cdae8
commit 834973efe0
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/java/org/apache/poi/hssf/record/NoteRecord.java
View File

@ -90,7 +90,11 @@ public final class NoteRecord extends StandardRecord {
} }
if (in.available() == 1) { if (in.available() == 1) {
field_7_padding = Byte.valueOf(in.readByte()); field_7_padding = Byte.valueOf(in.readByte());
} } else if (in.available() == 2 && length == 0) {
// If there's no author, may be double padded
field_7_padding = Byte.valueOf(in.readByte());
in.readByte();
}
} }
public void serialize(LittleEndianOutput out) { public void serialize(LittleEndianOutput out) {

3
src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
View File

@ -1651,8 +1651,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
openSample("47251.xls"); openSample("47251.xls");
// Now with one that triggers on NoteRecord // Now with one that triggers on NoteRecord
// TODO Fix the bug and enable this bit of the test openSample("47251_1.xls");
//openSample("47251_1.xls");
} }
/** /**