From 808c01e365b6dfe93a7538d77f540717ffd5552e Mon Sep 17 00:00:00 2001 From: Nick Burch Date: Mon, 6 May 2013 16:53:04 +0000 Subject: [PATCH] Fix #54891 - correct javadoc on HSSF + SS (XSSF was correct) for Row.createCell(int,int) git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1479639 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/poi/hssf/usermodel/HSSFRow.java | 6 ++++-- src/java/org/apache/poi/ss/usermodel/Row.java | 13 +++++++++++-- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java b/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java index 0c6a612fc..402397e54 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java @@ -129,8 +129,10 @@ public final class HSSFRow implements Row { /** * Use this to create new cells within the row and return it. *

- * The cell that is returned is a CELL_TYPE_BLANK. The type can be changed - * either through calling setCellValue or setCellType. + * The cell that is returned will be of the requested type. + * The type can be changed either through calling setCellValue + * or setCellType, but there is a small overhead to doing this, + * so it is best to create of the required type up front. * * @param columnIndex - the column number this cell represents * diff --git a/src/java/org/apache/poi/ss/usermodel/Row.java b/src/java/org/apache/poi/ss/usermodel/Row.java index 5d93f6492..08fb4254d 100644 --- a/src/java/org/apache/poi/ss/usermodel/Row.java +++ b/src/java/org/apache/poi/ss/usermodel/Row.java @@ -40,13 +40,22 @@ public interface Row extends Iterable { /** * Use this to create new cells within the row and return it. *

- * The cell that is returned is a {@link Cell#CELL_TYPE_BLANK}. The type can be changed - * either through calling setCellValue or setCellType. + * The cell that is returned will be of the requested type. + * The type can be changed either through calling setCellValue + * or setCellType, but there is a small overhead to doing this, + * so it is best to create of the required type up front. * * @param column - the column number this cell represents + * @param type - the cell's data type * @return Cell a high level representation of the created cell. * @throws IllegalArgumentException if columnIndex < 0 or greate than a maximum number of supported columns * (255 for *.xls, 1048576 for *.xlsx) + * @see Cell#CELL_TYPE_BLANK + * @see Cell#CELL_TYPE_BOOLEAN + * @see Cell#CELL_TYPE_ERROR + * @see Cell#CELL_TYPE_FORMULA + * @see Cell#CELL_TYPE_NUMERIC + * @see Cell#CELL_TYPE_STRING */ Cell createCell(int column, int type);