From 7c0d830822a39ebd6ea50584441a2bb78448688a Mon Sep 17 00:00:00 2001 From: Nick Burch Date: Thu, 24 Jan 2008 16:05:27 +0000 Subject: [PATCH] From bug #44254 - avoid some unread bytes warnings, and process the contents of DVALRecord git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@614909 13f79535-47bb-0310-9956-ffa450edef68 --- src/documentation/content/xdocs/changes.xml | 1 + src/documentation/content/xdocs/status.xml | 1 + .../apache/poi/hssf/record/DVALRecord.java | 124 +++++++++++++----- .../poi/hssf/record/UncalcedRecord.java | 1 + .../poi/hssf/record/formula/ErrPtg.java | 2 +- 5 files changed, 92 insertions(+), 37 deletions(-) diff --git a/src/documentation/content/xdocs/changes.xml b/src/documentation/content/xdocs/changes.xml index 33340b375..51aeb2246 100644 --- a/src/documentation/content/xdocs/changes.xml +++ b/src/documentation/content/xdocs/changes.xml @@ -36,6 +36,7 @@ + 44254 - Avoid some unread byte warnings, and properly understand DVALRecord Add another formula evaluation method, evaluateFormulaCell(cell), which will re-calculate the value for a formula, without affecting the formula itself. 41726 - Fix how we handle signed cell offsets in relative areas and references 44233 - Support for getting and setting a flag on the sheet, which tells excel to re-calculate all formulas on it at next reload diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml index 92ee0d94e..feabdf76b 100644 --- a/src/documentation/content/xdocs/status.xml +++ b/src/documentation/content/xdocs/status.xml @@ -33,6 +33,7 @@ + 44254 - Avoid some unread byte warnings, and properly understand DVALRecord Add another formula evaluation method, evaluateFormulaCell(cell), which will re-calculate the value for a formula, without affecting the formula itself. 41726 - Fix how we handle signed cell offsets in relative areas and references 44233 - Support for getting and setting a flag on the sheet, which tells excel to re-calculate all formulas on it at next reload diff --git a/src/java/org/apache/poi/hssf/record/DVALRecord.java b/src/java/org/apache/poi/hssf/record/DVALRecord.java index 858f525ca..2846f5066 100644 --- a/src/java/org/apache/poi/hssf/record/DVALRecord.java +++ b/src/java/org/apache/poi/hssf/record/DVALRecord.java @@ -29,19 +29,22 @@ import org.apache.poi.util.LittleEndian; public class DVALRecord extends Record { - public final static short sid = 0x01B2; + public final static short sid = 0x01B2; - //unknown field ; it's size should be 10 - private short field_unknown = 0x0000; + /** Options of the DVAL */ + private short field_1_options; + /** Horizontal position of the dialog */ + private int field_2_horiz_pos; + /** Vertical position of the dialog */ + private int field_3_vert_pos; - //Object ID of the drop down arrow object for list boxes ; - //in our case this will be always FFFF , until - //MSODrawingGroup and MSODrawing records are implemented - private int field_cbo_id = 0xFFFFFFFF; + /** Object ID of the drop down arrow object for list boxes ; + * in our case this will be always FFFF , until + * MSODrawingGroup and MSODrawing records are implemented */ + private int field_cbo_id = 0xFFFFFFFF; - //Number of following DV records - //Default value is 1 - private int field_3_dv_no = 0x00000000; + /** Number of following DV Records */ + private int field_5_dv_no = 0x00000000; public DVALRecord() { @@ -66,17 +69,38 @@ public class DVALRecord extends Record } } - protected void fillFields(RecordInputStream in) - { - for ( int i=0; i<5; i++) - { - this.field_unknown = in.readShort(); - } + protected void fillFields(RecordInputStream in) + { + this.field_1_options = in.readShort(); + this.field_2_horiz_pos = in.readInt(); + this.field_3_vert_pos = in.readInt(); this.field_cbo_id = in.readInt(); - this.field_3_dv_no = in.readInt(); - } + this.field_5_dv_no = in.readInt(); + } + /** + * @param field_1_options the options of the dialog + */ + public void setOptions(short field_1_options) { + this.field_1_options = field_1_options; + } + + /** + * @param field_2_horiz_pos the Horizontal position of the dialog + */ + public void setHorizontalPos(int field_2_horiz_pos) { + this.field_2_horiz_pos = field_2_horiz_pos; + } + + /** + * @param field_3_vert_pos the Vertical position of the dialog + */ + public void setVerticalPos(int field_3_vert_pos) { + this.field_3_vert_pos = field_3_vert_pos; + } + + /** * set the object ID of the drop down arrow object for list boxes * @param cboID - Object ID */ @@ -91,10 +115,33 @@ public class DVALRecord extends Record */ public void setDVRecNo(int dvNo) { - this.field_3_dv_no = dvNo; + this.field_5_dv_no = dvNo; } + + /** + * @return the field_1_options + */ + public short getOptions() { + return field_1_options; + } + + /** + * @return the Horizontal position of the dialog + */ + public int getHorizontalPos() { + return field_2_horiz_pos; + } + + /** + * @return the the Vertical position of the dialog + */ + public int getVerticalPos() { + return field_3_vert_pos; + } + + /** * get Object ID of the drop down arrow object for list boxes */ public int getObjectID( ) @@ -107,29 +154,32 @@ public class DVALRecord extends Record */ public int getDVRecNo( ) { - return this.field_3_dv_no; + return this.field_5_dv_no; } - public String toString() - { - StringBuffer buffer = new StringBuffer(); + public String toString() + { + StringBuffer buffer = new StringBuffer(); - buffer.append("[DVAL]\n"); - buffer.append(" .comboObjectID = ").append(Integer.toHexString(this.getObjectID())).append("\n"); - buffer.append(" .DVRecordsNumber = ").append(Integer.toHexString(this.getDVRecNo())).append("\n"); - buffer.append("[/DVAL]\n"); - return buffer.toString(); - } + buffer.append("[DVAL]\n"); + buffer.append(" .options = ").append(this.getOptions()).append('\n'); + buffer.append(" .horizPos = ").append(this.getHorizontalPos()).append('\n'); + buffer.append(" .vertPos = ").append(this.getVerticalPos()).append('\n'); + buffer.append(" .comboObjectID = ").append(Integer.toHexString(this.getObjectID())).append("\n"); + buffer.append(" .DVRecordsNumber = ").append(Integer.toHexString(this.getDVRecNo())).append("\n"); + buffer.append("[/DVAL]\n"); + return buffer.toString(); + } public int serialize(int offset, byte [] data) { LittleEndian.putShort(data, 0 + offset, this.sid); LittleEndian.putShort(data, 2 + offset, ( short)(this.getRecordSize()-4)); - for ( int i=0; i<5; i++) - { - LittleEndian.putShort(data, 4 + i*2 + offset, (short)this.field_unknown); - } + + LittleEndian.putShort(data, 4 + offset, this.getOptions()); + LittleEndian.putInt(data, 6 + offset, this.getHorizontalPos()); + LittleEndian.putInt(data, 10 + offset, this.getVerticalPos()); LittleEndian.putInt(data, 14 + offset, this.getObjectID()); LittleEndian.putInt(data, 18 + offset, this.getDVRecNo()); return getRecordSize(); @@ -149,9 +199,11 @@ public class DVALRecord extends Record public Object clone() { DVALRecord rec = new DVALRecord(); - rec.field_unknown = this.field_unknown; + rec.field_1_options = field_1_options; + rec.field_2_horiz_pos = field_2_horiz_pos; + rec.field_3_vert_pos = field_3_vert_pos; rec.field_cbo_id = this.field_cbo_id; - rec.field_3_dv_no = this.field_3_dv_no; + rec.field_5_dv_no = this.field_5_dv_no; return rec; } -} \ No newline at end of file +} diff --git a/src/java/org/apache/poi/hssf/record/UncalcedRecord.java b/src/java/org/apache/poi/hssf/record/UncalcedRecord.java index c3243f258..a67b0b5af 100644 --- a/src/java/org/apache/poi/hssf/record/UncalcedRecord.java +++ b/src/java/org/apache/poi/hssf/record/UncalcedRecord.java @@ -55,6 +55,7 @@ public class UncalcedRecord extends Record } protected void fillFields(RecordInputStream in) { + short unused = in.readShort(); } public String toString() { diff --git a/src/java/org/apache/poi/hssf/record/formula/ErrPtg.java b/src/java/org/apache/poi/hssf/record/formula/ErrPtg.java index e382d4e75..34bad6f32 100644 --- a/src/java/org/apache/poi/hssf/record/formula/ErrPtg.java +++ b/src/java/org/apache/poi/hssf/record/formula/ErrPtg.java @@ -29,7 +29,7 @@ import org.apache.poi.hssf.usermodel.HSSFErrorConstants; public class ErrPtg extends Ptg { public static final short sid = 0x1c; - private static final int SIZE = 7; + private static final int SIZE = 2; private byte field_1_error_code; /** Creates new ErrPtg */