diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml index 839684de4..27ec8027f 100644 --- a/src/documentation/content/xdocs/status.xml +++ b/src/documentation/content/xdocs/status.xml @@ -34,6 +34,7 @@ + 54016 - Avoid exception when parsing workbooks with DConRefRecord in row aggregate 54008 - Fixed Ant build to support build directories with blanks 53374 - Avoid exceptions when parsing hyperlinks of type "javascript://" 53404 - Fixed compatibility bug with modifying xls files created by POI-3.6 and earlier diff --git a/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java b/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java index e4e92cf70..535e7781f 100644 --- a/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java +++ b/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java @@ -24,20 +24,7 @@ import java.util.Map; import java.util.TreeMap; import org.apache.poi.hssf.model.RecordStream; -import org.apache.poi.hssf.record.ArrayRecord; -import org.apache.poi.hssf.record.CellValueRecordInterface; -import org.apache.poi.hssf.record.ContinueRecord; -import org.apache.poi.hssf.record.DBCellRecord; -import org.apache.poi.hssf.record.DimensionsRecord; -import org.apache.poi.hssf.record.FormulaRecord; -import org.apache.poi.hssf.record.IndexRecord; -import org.apache.poi.hssf.record.MergeCellsRecord; -import org.apache.poi.hssf.record.MulBlankRecord; -import org.apache.poi.hssf.record.Record; -import org.apache.poi.hssf.record.RowRecord; -import org.apache.poi.hssf.record.SharedFormulaRecord; -import org.apache.poi.hssf.record.TableRecord; -import org.apache.poi.hssf.record.UnknownRecord; +import org.apache.poi.hssf.record.*; import org.apache.poi.ss.formula.FormulaShifter; import org.apache.poi.ss.SpreadsheetVersion; @@ -86,7 +73,10 @@ public final class RowRecordsAggregate extends RecordAggregate { case RowRecord.sid: insertRow((RowRecord) rec); continue; - case DBCellRecord.sid: + case DConRefRecord.sid: + addUnknownRecord(rec); + continue; + case DBCellRecord.sid: // end of 'Row Block'. Should only occur after cell records // ignore DBCELL records because POI generates them upon re-serialization continue; diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java index 7dd8591b8..f392a4da2 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java @@ -2313,4 +2313,10 @@ if(1==2) { wb = writeOutAndReadBack((HSSFWorkbook) wb); } + + public void test54016() { + // This used to break + HSSFWorkbook wb = openSample("54016.xls"); + wb = HSSFTestDataSamples.writeOutAndReadBack(wb); + } } diff --git a/test-data/spreadsheet/54016.xls b/test-data/spreadsheet/54016.xls new file mode 100644 index 000000000..4148ca790 Binary files /dev/null and b/test-data/spreadsheet/54016.xls differ