moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

FindBugs fixes

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711708 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andreas Beeker 2015-10-31 23:13:35 +00:00
parent 8ebc22a84e
commit 72834dfffa
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/java/org/apache/poi/hpsf/MutableSection.java
View File

@ -505,10 +505,9 @@ public class MutableSection extends Section
throws IOException throws IOException
{ {
int length = TypeWriter.writeUIntToStream(out, dictionary.size()); int length = TypeWriter.writeUIntToStream(out, dictionary.size());
for (final Iterator<Long> i = dictionary.keySet().iterator(); i.hasNext();) for (Map.Entry<Long,String> ls : dictionary.entrySet()) {
{ final Long key = ls.getKey();
final Long key = i.next(); final String value = ls.getValue();
final String value = dictionary.get(key);
if (codepage == CodePageUtil.CP_UNICODE) if (codepage == CodePageUtil.CP_UNICODE)
{ {

5
src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java
View File

@ -76,8 +76,9 @@ public final class CollaboratingWorkbooksEnvironment {
} }
public static void setupFormulaEvaluator(Map<String,FormulaEvaluator> evaluators) { public static void setupFormulaEvaluator(Map<String,FormulaEvaluator> evaluators) {
Map<String, WorkbookEvaluator> evaluatorsByName = new HashMap<String, WorkbookEvaluator>(evaluators.size()); Map<String, WorkbookEvaluator> evaluatorsByName = new HashMap<String, WorkbookEvaluator>(evaluators.size());
for (String wbName : evaluators.keySet()) { for (Map.Entry<String,FormulaEvaluator> swb : evaluators.entrySet()) {
FormulaEvaluator eval = evaluators.get(wbName); String wbName = swb.getKey();
FormulaEvaluator eval = swb.getValue();
if (eval instanceof WorkbookEvaluatorProvider) { if (eval instanceof WorkbookEvaluatorProvider) {
evaluatorsByName.put(wbName, ((WorkbookEvaluatorProvider)eval)._getWorkbookEvaluator()); evaluatorsByName.put(wbName, ((WorkbookEvaluatorProvider)eval)._getWorkbookEvaluator());
} else { } else {