moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

bug 50795: move hack to avoid xmlbeans corrupt pointer to its own function

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751742 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-07-07 02:19:02 +00:00
parent 140b11bc7a
commit 56d11479de
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFComment.java
View File

@ -60,10 +60,7 @@ public class XSSFComment implements Comment {
clientData.setRowArray(0, new BigInteger(String.valueOf(ref.getRow()))); clientData.setRowArray(0, new BigInteger(String.valueOf(ref.getRow())));
clientData.setColumnArray(0, new BigInteger(String.valueOf(ref.getCol()))); clientData.setColumnArray(0, new BigInteger(String.valueOf(ref.getCol())));
// There is a very odd xmlbeans bug when changing the row avoidXmlbeansCorruptPointer(vmlShape);
// arrays which can lead to corrupt pointer
// This call seems to fix them again... See bug #50795
vmlShape.getClientDataList().toString();
} }
} }
@ -156,10 +153,7 @@ public class XSSFComment implements Comment {
clientData.setRowArray(0, new BigInteger(String.valueOf(address.getRow()))); clientData.setRowArray(0, new BigInteger(String.valueOf(address.getRow())));
clientData.setColumnArray(0, new BigInteger(String.valueOf(address.getColumn()))); clientData.setColumnArray(0, new BigInteger(String.valueOf(address.getColumn())));
// There is a very odd xmlbeans bug when changing the column avoidXmlbeansCorruptPointer(_vmlShape);
// arrays which can lead to corrupt pointer
// This call seems to fix them again... See bug #50795
_vmlShape.getClientDataList().toString();
} }
} }
@ -254,4 +248,11 @@ public class XSSFComment implements Comment {
public int hashCode() { public int hashCode() {
return ((getRow()*17) + getColumn())*31; return ((getRow()*17) + getColumn())*31;
} }
private static void avoidXmlbeansCorruptPointer(CTShape vmlShape) {
// There is a very odd xmlbeans bug when changing the row
// arrays which can lead to corrupt pointer
// This call seems to fix them again... See bug #50795
vmlShape.getClientDataList().toString();
}
} }