moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

fix findbugs issues

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-06-13 03:48:30 +00:00
parent 9d58a47e0c
commit 55b675a384
4 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/java/org/apache/poi/ddf/EscherComplexProperty.java
View File

@ -106,7 +106,7 @@ public class EscherComplexProperty extends EscherProperty {
if (this == o) { if (this == o) {
return true; return true;
} }
if (!(o instanceof EscherComplexProperty)) { if (o == null || !(o instanceof EscherComplexProperty)) {
return false; return false;
} }

8
src/java/org/apache/poi/dev/RecordGenerator.java
View File

@ -92,7 +92,9 @@ public class RecordGenerator {
// Generate record // Generate record
String destinationPath = destSrcPathDir + "/" + packageName; String destinationPath = destSrcPathDir + "/" + packageName;
File destinationPathFile = new File(destinationPath); File destinationPathFile = new File(destinationPath);
destinationPathFile.mkdirs(); if (destinationPathFile.mkdirs()) {
System.out.println("Created destination directory: " + destinationPath);
}
String destinationFilepath = destinationPath + "/" + recordName + suffix + ".java"; String destinationFilepath = destinationPath + "/" + recordName + suffix + ".java";
transform(file, new File(destinationFilepath), transform(file, new File(destinationFilepath),
new File(recordStyleDir + "/" + extendstg.toLowerCase(Locale.ROOT) + ".xsl")); new File(recordStyleDir + "/" + extendstg.toLowerCase(Locale.ROOT) + ".xsl"));
@ -101,7 +103,9 @@ public class RecordGenerator {
// Generate test (if not already generated) // Generate test (if not already generated)
destinationPath = testSrcPathDir + "/" + packageName; destinationPath = testSrcPathDir + "/" + packageName;
destinationPathFile = new File(destinationPath); destinationPathFile = new File(destinationPath);
destinationPathFile.mkdirs(); if (destinationPathFile.mkdirs()) {
System.out.println("Created destination directory: " + destinationPath);
}
destinationFilepath = destinationPath + "/Test" + recordName + suffix + ".java"; destinationFilepath = destinationPath + "/Test" + recordName + suffix + ".java";
if (new File(destinationFilepath).exists() == false) { if (new File(destinationFilepath).exists() == false) {
String temp = (recordStyleDir + "/" + extendstg.toLowerCase(Locale.ROOT) + "_test.xsl"); String temp = (recordStyleDir + "/" + extendstg.toLowerCase(Locale.ROOT) + "_test.xsl");

3
src/java/org/apache/poi/hpsf/Decimal.java
View File

@ -24,6 +24,9 @@ class Decimal
{ {
static final int SIZE = 16; static final int SIZE = 16;
/**
* Findbugs: UNR_UNREAD_FIELD
*/
private short field_1_wReserved; private short field_1_wReserved;
private byte field_2_scale; private byte field_2_scale;
private byte field_3_sign; private byte field_3_sign;

4
src/resources/devtools/findbugs-filters.xml
View File

@ -80,6 +80,10 @@
<Class name="org.apache.poi.xssf.model.IndexedUDFFinder"/> <Class name="org.apache.poi.xssf.model.IndexedUDFFinder"/>
<Bug code="Nm" /> <Bug code="Nm" />
</Match> </Match>
<Match>
<Class name="org.apache.poi.hpsf.Decimal"/>
<Bug pattern="URF_UNREAD_FIELD" />
</Match>
<!-- named this way on purpose --> <!-- named this way on purpose -->
<Match> <Match>