moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Remove misleading SXSSF logging

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819282 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2017-12-26 11:02:45 +00:00
parent 64d98e7872
commit 50c0ba01c6
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
View File

@ -43,8 +43,8 @@ import org.apache.poi.xssf.usermodel.XSSFHyperlink;
import org.apache.poi.xssf.usermodel.XSSFRichTextString; import org.apache.poi.xssf.usermodel.XSSFRichTextString;
/** /**
* Streaming version of XSSFRow implementing the "BigGridDemo" strategy. * Streaming version of XSSFCell implementing the "BigGridDemo" strategy.
*/ */
public class SXSSFCell implements Cell { public class SXSSFCell implements Cell {
private static final POILogger logger = POILogFactory.getLogger(SXSSFCell.class); private static final POILogger logger = POILogFactory.getLogger(SXSSFCell.class);
@ -53,7 +53,7 @@ public class SXSSFCell implements Cell {
private CellStyle _style; private CellStyle _style;
private Property _firstProperty; private Property _firstProperty;
public SXSSFCell(SXSSFRow row,CellType cellType) public SXSSFCell(SXSSFRow row, CellType cellType)
{ {
_row=row; _row=row;
setType(cellType); setType(cellType);
@ -268,8 +268,8 @@ public class SXSSFCell implements Cell {
/** /**
* Set a rich string value for the cell. * Set a rich string value for the cell.
* *
* @param value value to set the cell to. For formulas we'll set the formula * @param value value to set the cell to. For formulas: we'll set the formula
* string, for String cells we'll set its value. For other types we will * string, for String cells: we'll set its value. For other types we will
* change the cell to a string cell and set its value. * change the cell to a string cell and set its value.
* If value is null then we will change the cell to a Blank cell. * If value is null then we will change the cell to a Blank cell.
*/ */
@ -284,8 +284,6 @@ public class SXSSFCell implements Cell {
if (xvalue.length() > SpreadsheetVersion.EXCEL2007.getMaxTextLength()) { if (xvalue.length() > SpreadsheetVersion.EXCEL2007.getMaxTextLength()) {
throw new IllegalArgumentException("The maximum length of cell contents (text) is 32,767 characters"); throw new IllegalArgumentException("The maximum length of cell contents (text) is 32,767 characters");
} }
if (xvalue.hasFormatting())
logger.log(POILogger.WARN, "SXSSF doesn't support Shared Strings, rich text formatting information has be lost");
((RichTextValue)_value).setValue(xvalue); ((RichTextValue)_value).setValue(xvalue);
} else { } else {

2
src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
View File

@ -130,7 +130,7 @@ public class SXSSFRow implements Row, Comparable<SXSSFRow>
* *
* @param column - the column number this cell represents * @param column - the column number this cell represents
* @return Cell a high level representation of the created cell. * @return Cell a high level representation of the created cell.
* @throws IllegalArgumentException if columnIndex < 0 or greate than a maximum number of supported columns * @throws IllegalArgumentException if columnIndex < 0 or greater than a maximum number of supported columns
* (255 for *.xls, 1048576 for *.xlsx) * (255 for *.xls, 1048576 for *.xlsx)
*/ */
@Override @Override