moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

SonarCube fixes

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769399 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andreas Beeker 2016-11-12 18:35:39 +00:00
parent a6f005de81
commit 44ca7f04ba
2 changed files with 21 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/java/org/apache/poi/ss/formula/functions/LogicalFunction.java
View File

@ -40,12 +40,11 @@ public abstract class LogicalFunction extends Fixed1ArgFunction {
try { try {
ve = OperandResolver.getSingleValue(arg0, srcRowIndex, srcColumnIndex); ve = OperandResolver.getSingleValue(arg0, srcRowIndex, srcColumnIndex);
} catch (EvaluationException e) { } catch (EvaluationException e) {
if (false) { // Note - it is more usual to propagate error codes straight to the result like this:
// Note - it is more usual to propagate error codes straight to the result like this: // but logical functions behave a little differently
return e.getErrorEval(); // return e.getErrorEval();
// but logical functions behave a little differently
} // this will usually cause a 'FALSE' result except for ISNONTEXT()
// this will usually cause a 'FALSE' result except for ISNONTEXT()
ve = e.getErrorEval(); ve = e.getErrorEval();
} }
return BoolEval.valueOf(evaluate(ve)); return BoolEval.valueOf(evaluate(ve));

38
src/scratchpad/src/org/apache/poi/hwpf/dev/HWPFLister.java
View File

@ -380,27 +380,24 @@ public final class HWPFLister
} }
} }
if ( true ) String text = new Range( chpx.getStart(), chpx.getEnd(),
_doc.getOverallRange() )
{ {
String text = new Range( chpx.getStart(), chpx.getEnd(), public String toString()
_doc.getOverallRange() )
{ {
public String toString() return "CHPX range (" + super.toString() + ")";
{
return "CHPX range (" + super.toString() + ")";
}
}.text();
StringBuilder stringBuilder = new StringBuilder();
for ( char c : text.toCharArray() )
{
if ( c < 30 )
stringBuilder
.append( "\\0x" + Integer.toHexString( c ) );
else
stringBuilder.append( c );
} }
System.out.println( stringBuilder ); }.text();
StringBuilder stringBuilder = new StringBuilder();
for ( char c : text.toCharArray() )
{
if ( c < 30 )
stringBuilder
.append( "\\0x" + Integer.toHexString( c ) );
else
stringBuilder.append( c );
} }
System.out.println( stringBuilder );
} }
} }
@ -584,11 +581,8 @@ public final class HWPFLister
System.out.println( paragraph.getProps() ); System.out.println( paragraph.getProps() );
} }
if ( true ) SprmIterator sprmIt = new SprmIterator( papx.getGrpprl(), 2 );
{ dumpSprms( sprmIt, "\t" );
SprmIterator sprmIt = new SprmIterator( papx.getGrpprl(), 2 );
dumpSprms( sprmIt, "\t" );
}
} }
} }