moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

bug 60158: add failing test cases for AIOOBE on VBAMacroReader

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761652 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-09-21 01:03:12 +00:00
parent c669e2ef67
commit 3adf725ba4
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java
View File

@ -262,6 +262,10 @@ public class TestVBAMacroReader {
reader.close(); reader.close();
} }
private void skipTest(Throwable e) {
assumeTrue("This test currently fails." + e.getLocalizedMessage(), false);
}
// This test is written as expected-to-fail and should be rewritten // This test is written as expected-to-fail and should be rewritten
// as expected-to-pass when the bug is fixed. // as expected-to-pass when the bug is fixed.
@Test @Test
@ -273,11 +277,23 @@ public class TestVBAMacroReader {
if (e.getMessage().matches("Module offset for '.+' was never read.")) { if (e.getMessage().matches("Module offset for '.+' was never read.")) {
//e.printStackTrace(); //e.printStackTrace();
// NPE when reading module.offset in VBAMacroReader.readMacros (approx line 258) // NPE when reading module.offset in VBAMacroReader.readMacros (approx line 258)
assumeTrue("This test currently fails. See stdout.", false); skipTest(e);
} else { } else {
// something unexpected failed // something unexpected failed
throw e; throw e;
} }
} }
} }
// This test is written as expected-to-fail and should be rewritten
// as expected-to-pass when the bug is fixed.
@Test
public void bug60158() throws IOException {
try {
fromFile(POIDataSamples.getDocumentInstance(), "60158.docm");
fail("This test passes now. Please update the unit test and bug 59858.");
} catch (ArrayIndexOutOfBoundsException e) {
skipTest(e);
}
}
} }

BIN
test-data/document/60158.docm Normal file
View File

Binary file not shown.