moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

convert "".equals(string) to string.isEmpty()

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2017-10-18 08:22:51 +00:00
parent 21b65721e7
commit 3a2ee5f4d1
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/examples/src/org/apache/poi/ss/examples/html/ToHtml.java
View File

@ -479,7 +479,7 @@ public class ToHtml {
style.getDataFormatString()); style.getDataFormatString());
CellFormatResult result = cf.apply(cell); CellFormatResult result = cf.apply(cell);
content = result.text; content = result.text;
if ("".equals(content)) { if (content.isEmpty()) {
content = " "; content = " ";
} }
} }

2
src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java
View File

@ -798,7 +798,7 @@ public class TestSignatureInfo {
private static File copy(File input) throws IOException { private static File copy(File input) throws IOException {
String extension = input.getName().replaceAll(".*?(\\.[^.]+)?$", "$1"); String extension = input.getName().replaceAll(".*?(\\.[^.]+)?$", "$1");
if (extension == null || "".equals(extension)) { if (extension == null || extension.isEmpty()) {
extension = ".zip"; extension = ".zip";
} }

2
src/testcases/org/apache/poi/ss/formula/functions/BaseTestFunctionsFromSpreadsheet.java
View File

@ -127,7 +127,7 @@ public abstract class BaseTestFunctionsFromSpreadsheet {
String rowComment = getCellTextValue(r, SS.COLUMN_ROW_COMMENT, "row comment"); String rowComment = getCellTextValue(r, SS.COLUMN_ROW_COMMENT, "row comment");
String testName = (currentGroupComment+'\n'+rowComment).replace("null", "").trim().replace("\n", " - "); String testName = (currentGroupComment+'\n'+rowComment).replace("null", "").trim().replace("\n", " - ");
if ("".equals(testName)) { if (testName.isEmpty()) {
testName = evalCell.getCellFormula(); testName = evalCell.getCellFormula();
} }

2
src/testcases/org/apache/poi/ss/usermodel/BaseTestCellComment.java
View File

@ -170,7 +170,7 @@ public abstract class BaseTestCellComment {
assertEquals("Yegor Kozlov", comment.getAuthor()); assertEquals("Yegor Kozlov", comment.getAuthor());
assertFalse("cells in the second column have not empyy notes", assertFalse("cells in the second column have not empyy notes",
"".equals(comment.getString().getString())); comment.getString().getString().isEmpty());
assertEquals(rownum, comment.getRow()); assertEquals(rownum, comment.getRow());
assertEquals(cell.getColumnIndex(), comment.getColumn()); assertEquals(cell.getColumnIndex(), comment.getColumn());
} }