From 359820ba8041d9dac5d387c7f1b3bca6ab074350 Mon Sep 17 00:00:00 2001 From: Javen O'Neal Date: Fri, 21 Oct 2016 07:29:40 +0000 Subject: [PATCH] bug 60288: remove defensive copy for internal relationships. Patch from Tim Helmstedt. This closes #38. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765935 13f79535-47bb-0310-9956-ffa450edef68 --- .../java/org/apache/poi/openxml4j/opc/OPCPackage.java | 2 +- .../java/org/apache/poi/openxml4j/opc/PackagePart.java | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java b/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java index 759cfdea9..506344f93 100644 --- a/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java +++ b/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java @@ -1409,7 +1409,7 @@ public abstract class OPCPackage implements RelationshipSource, Closeable { */ @Override public boolean isRelationshipExists(PackageRelationship rel) { - for (PackageRelationship r : this.getRelationships()) { + for (PackageRelationship r : relationships) { if (r == rel) { return true; } diff --git a/src/ooxml/java/org/apache/poi/openxml4j/opc/PackagePart.java b/src/ooxml/java/org/apache/poi/openxml4j/opc/PackagePart.java index bcf457e1a..23969fa68 100644 --- a/src/ooxml/java/org/apache/poi/openxml4j/opc/PackagePart.java +++ b/src/ooxml/java/org/apache/poi/openxml4j/opc/PackagePart.java @@ -447,12 +447,9 @@ public abstract class PackagePart implements RelationshipSource, Comparable