code clean-up (removed compiler warnings/unused methods)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@696860 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Josh Micich 2008-09-19 00:02:21 +00:00
parent c5a00d78c9
commit 26b458016e
2 changed files with 12 additions and 21 deletions

View File

@ -17,8 +17,6 @@
package org.apache.poi.hssf.record.formula; package org.apache.poi.hssf.record.formula;
import org.apache.poi.ss.formula.FormulaRenderingWorkbook;
/** /**
* defines a Ptg that is an operation instead of an operand * defines a Ptg that is an operation instead of an operand
* @author andy * @author andy
@ -42,16 +40,10 @@ public abstract class OperationPtg extends Ptg {
public abstract int getNumberOfOperands(); public abstract int getNumberOfOperands();
public byte getDefaultOperandClass() { public byte getDefaultOperandClass() {
return Ptg.CLASS_VALUE; return Ptg.CLASS_VALUE;
} }
public final int getType() { public final int getType() {
// TODO remove "int getType();" from Eval hierarchy // TODO remove "int getType();" from Eval hierarchy
throw new RuntimeException("remove this method"); throw new RuntimeException("remove this method");
} }
public String toFormulaString(FormulaRenderingWorkbook book) {
// TODO Auto-generated method stub
return null;
}
} }

View File

@ -18,7 +18,6 @@
package org.apache.poi.hssf.record.formula; package org.apache.poi.hssf.record.formula;
import org.apache.poi.hssf.record.RecordInputStream; import org.apache.poi.hssf.record.RecordInputStream;
import org.apache.poi.hssf.usermodel.HSSFWorkbook;
import org.apache.poi.hssf.util.CellReference; import org.apache.poi.hssf.util.CellReference;
import org.apache.poi.ss.formula.WorkbookDependentFormula; import org.apache.poi.ss.formula.WorkbookDependentFormula;
import org.apache.poi.ss.formula.FormulaRenderingWorkbook; import org.apache.poi.ss.formula.FormulaRenderingWorkbook;
@ -67,9 +66,9 @@ public final class Ref3DPtg extends RefPtgBase implements WorkbookDependentFormu
} }
public void writeBytes(byte [] array, int offset) { public void writeBytes(byte [] array, int offset) {
LittleEndian.putByte(array, 0 + offset, sid + getPtgClass()); LittleEndian.putByte(array, 0 + offset, sid + getPtgClass());
LittleEndian.putUShort(array, 1 + offset, getExternSheetIndex()); LittleEndian.putUShort(array, 1 + offset, getExternSheetIndex());
writeCoordinates(array, offset + 3); writeCoordinates(array, offset + 3);
} }
public int getSize() { public int getSize() {
@ -89,9 +88,9 @@ public final class Ref3DPtg extends RefPtgBase implements WorkbookDependentFormu
* formulas. The sheet name will get properly delimited if required. * formulas. The sheet name will get properly delimited if required.
*/ */
public String toFormulaString(FormulaRenderingWorkbook book) { public String toFormulaString(FormulaRenderingWorkbook book) {
return ExternSheetNameResolver.prependSheetName(book, field_1_index_extern_sheet, formatReferenceAsString()); return ExternSheetNameResolver.prependSheetName(book, field_1_index_extern_sheet, formatReferenceAsString());
}
public String toFormulaString() {
throw new RuntimeException("3D references need a workbook to determine formula text");
} }
public String toFormulaString() {
throw new RuntimeException("3D references need a workbook to determine formula text");
}
} }