moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

junit improvements: assertEquals(null|true|false, ...) -> assertNull, assertTrue, assertFalse

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777450 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2017-01-05 11:26:42 +00:00
parent 5add583122
commit 25db24d2d6
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/scratchpad/testcases/org/apache/poi/hsmf/TestBasics.java
View File

@ -127,7 +127,7 @@ public final class TestBasics extends TestCase {
* Use a file with no HTML body * Use a file with no HTML body
*/ */
public void testMissingChunks() throws Exception { public void testMissingChunks() throws Exception {
assertEquals(false, attachments.isReturnNullOnMissingChunk()); assertFalse(attachments.isReturnNullOnMissingChunk());
try { try {
attachments.getHtmlBody(); attachments.getHtmlBody();
@ -138,7 +138,7 @@ public final class TestBasics extends TestCase {
attachments.setReturnNullOnMissingChunk(true); attachments.setReturnNullOnMissingChunk(true);
assertEquals(null, attachments.getHtmlBody()); assertNull(attachments.getHtmlBody());
attachments.setReturnNullOnMissingChunk(false); attachments.setReturnNullOnMissingChunk(false);
@ -155,7 +155,7 @@ public final class TestBasics extends TestCase {
* missing recipient email address * missing recipient email address
*/ */
public void testMissingAddressChunk() throws Exception { public void testMissingAddressChunk() throws Exception {
assertEquals(false, noRecipientAddress.isReturnNullOnMissingChunk()); assertFalse(noRecipientAddress.isReturnNullOnMissingChunk());
try { try {
noRecipientAddress.getRecipientEmailAddress(); noRecipientAddress.getRecipientEmailAddress();
@ -176,7 +176,7 @@ public final class TestBasics extends TestCase {
noRecipientAddress.getRecipientEmailAddressList(); noRecipientAddress.getRecipientEmailAddressList();
assertEquals("", noRecipientAddress.getRecipientEmailAddress()); assertEquals("", noRecipientAddress.getRecipientEmailAddress());
assertEquals(1, noRecipientAddress.getRecipientEmailAddressList().length); assertEquals(1, noRecipientAddress.getRecipientEmailAddressList().length);
assertEquals(null, noRecipientAddress.getRecipientEmailAddressList()[0]); assertNull(noRecipientAddress.getRecipientEmailAddressList()[0]);
// Check a few other bits too // Check a few other bits too
assertEquals("Microsoft Outlook 2003 Team", noRecipientAddress.getDisplayFrom()); assertEquals("Microsoft Outlook 2003 Team", noRecipientAddress.getDisplayFrom());
@ -189,10 +189,10 @@ public final class TestBasics extends TestCase {
* Test the 7 bit detection * Test the 7 bit detection
*/ */
public void test7BitDetection() throws Exception { public void test7BitDetection() throws Exception {
assertEquals(false, unicode.has7BitEncodingStrings()); assertFalse(unicode.has7BitEncodingStrings());
assertEquals(true, simple.has7BitEncodingStrings()); assertTrue(simple.has7BitEncodingStrings());
assertEquals(true, chinese.has7BitEncodingStrings()); assertTrue(chinese.has7BitEncodingStrings());
assertEquals(true, cyrillic.has7BitEncodingStrings()); assertTrue(cyrillic.has7BitEncodingStrings());
} }
/** /**