From 1ce039753a569b50b5eb99a2bde4c36d2b687dc5 Mon Sep 17 00:00:00 2001 From: Andreas Beeker Date: Thu, 29 Jun 2017 09:33:33 +0000 Subject: [PATCH] remove timezoned call to Date.toString() - SignatureProperties don't necessarily need an Id attribute git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800257 13f79535-47bb-0310-9956-ffa450edef68 --- .../poi/poifs/crypt/dsig/facets/OOXMLSignatureFacet.java | 3 +-- .../org/apache/poi/poifs/crypt/TestSignatureInfo.java | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/facets/OOXMLSignatureFacet.java b/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/facets/OOXMLSignatureFacet.java index d8164cdc6..f7b1f9547 100644 --- a/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/facets/OOXMLSignatureFacet.java +++ b/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/facets/OOXMLSignatureFacet.java @@ -240,8 +240,7 @@ public class OOXMLSignatureFacet extends SignatureFacet { List signaturePropertyContent = new ArrayList(); signaturePropertyContent.add(signatureTimeSignatureProperty); SignatureProperties signatureProperties = getSignatureFactory() - .newSignatureProperties(signaturePropertyContent, - "id-signature-time-" + signatureConfig.getExecutionTime()); + .newSignatureProperties(signaturePropertyContent, null); objectContent.add(signatureProperties); } diff --git a/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java b/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java index ae04478ad..c9ceb113d 100644 --- a/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java +++ b/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java @@ -184,11 +184,11 @@ public class TestSignatureInfo { signatureConfig.setOpcPackage(pkg2); assertTrue(si.verifySignature()); String signExp = - "Lxp2LFa+0YWGOBL8zVdf7SWRQiNK/Tt85W+kmH1bunlua030BKbQc6yWIIk6gN6jCTtrJ1h2eMRbLwymygOUpM"+ - "dd0MeQY3mMWRSO9qEW87SQvyDqBh71zXWW3ZYET+vJWr3BCNEtXCy8jZvgXqILBGk5vMJW/EYaUEhBcDGjCm0="; + "HDdvgXblLMiE6gZSoRSQUof6+aedrhK9i51we1n+4Q/ioqrQCeh5UkfQ8lD63nV4ZDbM4/pIVFi6VpMpN/HMnA"+ + "UHeVdVUCVTgpn3Iz21Ymcd9/aerNov2BjHLhS8X3oUE+XTu2TbJLNmms0I9G4lfg6HWP9t7ZCXBXy6vyCMArc="; String signAct = si.getSignatureParts().iterator().next(). getSignatureDocument().getSignature().getSignatureValue().getStringValue(); -// assertEquals(signExp, signAct); + assertEquals(signExp, signAct); if (new File("build").exists()) { // write out to build, for further comparison between local and Jenkins box