moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

findbugs: fix URF_UNREAD_FIELD warnings

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-06-13 04:42:59 +00:00
parent 81d15d29df
commit 1853126f9b
5 changed files with 30 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java
View File

@ -27,12 +27,12 @@ import org.apache.poi.ss.util.CellRangeAddressList;
* Helper for working with Data Validation * Helper for working with Data Validation
*/ */
public class HSSFDataValidationHelper implements DataValidationHelper { public class HSSFDataValidationHelper implements DataValidationHelper {
@SuppressWarnings("unused") //URF_UNREAD_FIELD
private HSSFSheet sheet; //private HSSFSheet sheet;
public HSSFDataValidationHelper(HSSFSheet sheet) { public HSSFDataValidationHelper(HSSFSheet sheet) {
super(); super();
this.sheet = sheet; //this.sheet = sheet;
} }
/* /*

3
src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java
View File

@ -48,7 +48,8 @@ public class HSSFTextbox extends HSSFSimpleShape {
super(spContainer, objRecord, textObjectRecord); super(spContainer, objRecord, textObjectRecord);
} }
HSSFRichTextString string = new HSSFRichTextString(""); //Unused: URF_UNREAD_FIELD
//HSSFRichTextString string = new HSSFRichTextString("");
/** /**
* Construct a new textbox with the given parent and anchor. * Construct a new textbox with the given parent and anchor.

5
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java
View File

@ -35,12 +35,13 @@ import org.openxmlformats.schemas.spreadsheetml.x2006.main.STDataValidationType;
* *
*/ */
public class XSSFDataValidationHelper implements DataValidationHelper { public class XSSFDataValidationHelper implements DataValidationHelper {
private XSSFSheet xssfSheet; //Unused: URF_UNREAD_FIELD
//private XSSFSheet xssfSheet;
public XSSFDataValidationHelper(XSSFSheet xssfSheet) { public XSSFDataValidationHelper(XSSFSheet xssfSheet) {
super(); super();
this.xssfSheet = xssfSheet; //this.xssfSheet = xssfSheet;
} }
/* (non-Javadoc) /* (non-Javadoc)

3
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java
View File

@ -43,7 +43,8 @@ public final class XSSFGraphicFrame extends XSSFShape {
private static CTGraphicalObjectFrame prototype = null; private static CTGraphicalObjectFrame prototype = null;
private CTGraphicalObjectFrame graphicFrame; private CTGraphicalObjectFrame graphicFrame;
private XSSFDrawing drawing; // Unused: URF_UNREAD_FIELD
//private XSSFDrawing drawing;
private XSSFClientAnchor anchor; private XSSFClientAnchor anchor;
/** /**

23
src/resources/devtools/findbugs-filters.xml
View File

@ -47,18 +47,31 @@
</Or> </Or>
<Bug code="Nm" /> <Bug code="Nm" />
</Match> </Match>
<!-- ignore fields that correspond to the values in a H??F binary record -->
<Match> <Match>
<Class name="org.apache.poi.hpsf.Decimal"/> <Class name="~org\.apache\.poi\.h..f\..*"/>
<Bug pattern="URF_UNREAD_FIELD" /> <Bug pattern="URF_UNREAD_FIELD" />
<Field name="field_[12345]_.+" /> <Field name="~field_[12345].*" />
</Match> </Match>
<Match>
<Class name="org.apache.poi.hssf.usermodel.HSSFChart"/>
<Bug pattern="URF_UNREAD_FIELD" />
<Field name="chartTitleFormat" />
</Match>
<Match>
<Class name="org.apache.poi.hwmf.record.HwmfWindowing"/>
<Bug pattern="URF_UNREAD_FIELD" />
<Field name="count2" />
</Match>
<!-- invalid performance issues - e.g. see #57840 --> <!-- invalid performance issues - e.g. see #57840 -->
<Match> <Match>
<Or>
<Class name="org.apache.poi.xssf.usermodel.XSSFRow"/> <Class name="org.apache.poi.xssf.usermodel.XSSFRow"/>
<Bug pattern="DM_NUMBER_CTOR" />
</Match>
<Match>
<Class name="org.apache.poi.xssf.usermodel.XSSFSheet"/> <Class name="org.apache.poi.xssf.usermodel.XSSFSheet"/>
</Or>
<Bug pattern="DM_NUMBER_CTOR" /> <Bug pattern="DM_NUMBER_CTOR" />
</Match> </Match>