moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Move more tests into base class and add a TestSXSSFBugs class to verify some things that are supported against SXSSFWorkbook as well

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686035 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Dominik Stadler 2015-06-17 14:53:38 +00:00
parent e7d33e4ccb
commit 13eb52f12f
4 changed files with 367 additions and 145 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestSXSSFBugs.java Normal file
View File

@ -0,0 +1,82 @@
/* ====================================================================
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==================================================================== */
package org.apache.poi.xssf.usermodel;
import static org.junit.Assert.assertEquals;
import org.apache.poi.ss.usermodel.BaseTestBugzillaIssues;
import org.apache.poi.ss.usermodel.PrintSetup;
import org.apache.poi.ss.usermodel.Sheet;
import org.apache.poi.ss.usermodel.Workbook;
import org.apache.poi.xssf.SXSSFITestDataProvider;
import org.apache.poi.xssf.streaming.SXSSFWorkbook;
import org.junit.Ignore;
import org.junit.Test;
public final class TestSXSSFBugs extends BaseTestBugzillaIssues {
public TestSXSSFBugs() {
super(SXSSFITestDataProvider.instance);
}
// override some tests which do not work for SXSSF
@Override @Ignore("cloneSheet() not implemented") @Test public void bug18800() { /* cloneSheet() not implemented */ }
@Override @Ignore("cloneSheet() not implemented") @Test public void bug22720() { /* cloneSheet() not implemented */ }
@Override @Ignore("Evaluation is not supported") @Test public void bug43093() { /* Evaluation is not supported */ }
@Override @Ignore("Evaluation is not supported") @Test public void bug51024() { /* Evaluation is not supported */ }
@Override @Ignore("Evaluation is not supported") @Test public void bug46729_testMaxFunctionArguments() { /* Evaluation is not supported */ }
@Override @Ignore("Evaluation is not supported") @Test public void stackoverflow26437323() { /* Evaluation is not supported */ }
@Override @Ignore("Evaluation is not supported") @Test public void bug47815() { /* Evaluation is not supported */ }
/**
* Setting repeating rows and columns shouldn't break
* any print settings that were there before
*/
@SuppressWarnings("deprecation")
@Test
public void bug49253() throws Exception {
Workbook wb1 = new SXSSFWorkbook();
Workbook wb2 = new SXSSFWorkbook();
// No print settings before repeating
Sheet s1 = wb1.createSheet();
wb1.setRepeatingRowsAndColumns(0, 2, 3, 1, 2);
PrintSetup ps1 = s1.getPrintSetup();
assertEquals(false, ps1.getValidSettings());
assertEquals(false, ps1.getLandscape());
// Had valid print settings before repeating
Sheet s2 = wb2.createSheet();
PrintSetup ps2 = s2.getPrintSetup();
ps2.setLandscape(false);
assertEquals(true, ps2.getValidSettings());
assertEquals(false, ps2.getLandscape());
wb2.setRepeatingRowsAndColumns(0, 2, 3, 1, 2);
ps2 = s2.getPrintSetup();
assertEquals(true, ps2.getValidSettings());
assertEquals(false, ps2.getLandscape());
wb1.close();
wb2.close();
}
}

129
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
View File

@ -74,6 +74,7 @@ import org.apache.poi.ss.usermodel.FormulaEvaluator;
import org.apache.poi.ss.usermodel.Hyperlink; import org.apache.poi.ss.usermodel.Hyperlink;
import org.apache.poi.ss.usermodel.IndexedColors; import org.apache.poi.ss.usermodel.IndexedColors;
import org.apache.poi.ss.usermodel.Name; import org.apache.poi.ss.usermodel.Name;
import org.apache.poi.ss.usermodel.PrintSetup;
import org.apache.poi.ss.usermodel.Row; import org.apache.poi.ss.usermodel.Row;
import org.apache.poi.ss.usermodel.Sheet; import org.apache.poi.ss.usermodel.Sheet;
import org.apache.poi.ss.usermodel.Workbook; import org.apache.poi.ss.usermodel.Workbook;
@ -349,42 +350,6 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
assertEquals(null, cs.getFillBackgroundColorColor().getARGBHex()); assertEquals(null, cs.getFillBackgroundColorColor().getARGBHex());
} }
/**
* With HSSF, if you create a font, don't change it, and
* create a 2nd, you really do get two fonts that you
* can alter as and when you want.
* With XSSF, that wasn't the case, but this verfies
* that it now is again
*/
@Test
public void bug48718() throws Exception {
// Verify the HSSF behaviour
// Then ensure the same for XSSF
Workbook[] wbs = new Workbook[] {
new HSSFWorkbook(),
new XSSFWorkbook()
};
int[] initialFonts = new int[] { 4, 1 };
for(int i=0; i<wbs.length; i++) {
Workbook wb = wbs[i];
int startingFonts = initialFonts[i];
assertEquals(startingFonts, wb.getNumberOfFonts());
// Get a font, and slightly change it
Font a = wb.createFont();
assertEquals(startingFonts+1, wb.getNumberOfFonts());
a.setFontHeightInPoints((short)23);
assertEquals(startingFonts+1, wb.getNumberOfFonts());
// Get two more, unchanged
/*Font b =*/ wb.createFont();
assertEquals(startingFonts+2, wb.getNumberOfFonts());
/*Font c =*/ wb.createFont();
assertEquals(startingFonts+3, wb.getNumberOfFonts());
}
}
/** /**
* Ensure General and @ format are working properly * Ensure General and @ format are working properly
* for integers * for integers
@ -418,73 +383,6 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
assertEquals("123", df.formatRawCellContents(123.0, -1, "General")); assertEquals("123", df.formatRawCellContents(123.0, -1, "General"));
} }
/**
* Ensures that XSSF and HSSF agree with each other,
* and with the docs on when fetching the wrong
* kind of value from a Formula cell
*/
@Test
public void bug47815() {
Workbook[] wbs = new Workbook[] {
new HSSFWorkbook(),
new XSSFWorkbook()
};
for(Workbook wb : wbs) {
Sheet s = wb.createSheet();
Row r = s.createRow(0);
// Setup
Cell cn = r.createCell(0, Cell.CELL_TYPE_NUMERIC);
cn.setCellValue(1.2);
Cell cs = r.createCell(1, Cell.CELL_TYPE_STRING);
cs.setCellValue("Testing");
Cell cfn = r.createCell(2, Cell.CELL_TYPE_FORMULA);
cfn.setCellFormula("A1");
Cell cfs = r.createCell(3, Cell.CELL_TYPE_FORMULA);
cfs.setCellFormula("B1");
FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator();
assertEquals(Cell.CELL_TYPE_NUMERIC, fe.evaluate(cfn).getCellType());
assertEquals(Cell.CELL_TYPE_STRING, fe.evaluate(cfs).getCellType());
fe.evaluateFormulaCell(cfn);
fe.evaluateFormulaCell(cfs);
// Now test
assertEquals(Cell.CELL_TYPE_NUMERIC, cn.getCellType());
assertEquals(Cell.CELL_TYPE_STRING, cs.getCellType());
assertEquals(Cell.CELL_TYPE_FORMULA, cfn.getCellType());
assertEquals(Cell.CELL_TYPE_NUMERIC, cfn.getCachedFormulaResultType());
assertEquals(Cell.CELL_TYPE_FORMULA, cfs.getCellType());
assertEquals(Cell.CELL_TYPE_STRING, cfs.getCachedFormulaResultType());
// Different ways of retrieving
assertEquals(1.2, cn.getNumericCellValue(), 0);
try {
cn.getRichStringCellValue();
fail();
} catch(IllegalStateException e) {}
assertEquals("Testing", cs.getStringCellValue());
try {
cs.getNumericCellValue();
fail();
} catch(IllegalStateException e) {}
assertEquals(1.2, cfn.getNumericCellValue(), 0);
try {
cfn.getRichStringCellValue();
fail();
} catch(IllegalStateException e) {}
assertEquals("Testing", cfs.getStringCellValue());
try {
cfs.getNumericCellValue();
fail();
} catch(IllegalStateException e) {}
}
}
/** /**
* A problem file from a non-standard source (a scientific instrument that saves its * A problem file from a non-standard source (a scientific instrument that saves its
* output as an .xlsx file) that have two issues: * output as an .xlsx file) that have two issues:
@ -1128,14 +1026,14 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
assertEquals(true, s1.getCTWorksheet().isSetPageSetup()); assertEquals(true, s1.getCTWorksheet().isSetPageSetup());
assertEquals(true, s1.getCTWorksheet().isSetPageMargins()); assertEquals(true, s1.getCTWorksheet().isSetPageMargins());
XSSFPrintSetup ps1 = s1.getPrintSetup(); PrintSetup ps1 = s1.getPrintSetup();
assertEquals(false, ps1.getValidSettings()); assertEquals(false, ps1.getValidSettings());
assertEquals(false, ps1.getLandscape()); assertEquals(false, ps1.getLandscape());
// Had valid print settings before repeating // Had valid print settings before repeating
XSSFSheet s2 = wb2.createSheet(); XSSFSheet s2 = wb2.createSheet();
XSSFPrintSetup ps2 = s2.getPrintSetup(); PrintSetup ps2 = s2.getPrintSetup();
assertEquals(true, s2.getCTWorksheet().isSetPageSetup()); assertEquals(true, s2.getCTWorksheet().isSetPageSetup());
assertEquals(true, s2.getCTWorksheet().isSetPageMargins()); assertEquals(true, s2.getCTWorksheet().isSetPageMargins());
@ -1380,12 +1278,13 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
@Test @Test
public void bug51963() throws Exception { public void bug51963() throws Exception {
XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook("51963.xlsx"); XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook("51963.xlsx");
XSSFSheet sheet = wb.getSheetAt(0); Sheet sheet = wb.getSheetAt(0);
assertEquals("Abc,1", sheet.getSheetName()); assertEquals("Abc,1", sheet.getSheetName());
Name name = wb.getName("Intekon.ProdCodes"); Name name = wb.getName("Intekon.ProdCodes");
assertEquals("'Abc,1'!$A$1:$A$2", name.getRefersToFormula()); assertEquals("'Abc,1'!$A$1:$A$2", name.getRefersToFormula());
@SuppressWarnings("deprecation")
AreaReference ref = new AreaReference(name.getRefersToFormula()); AreaReference ref = new AreaReference(name.getRefersToFormula());
assertEquals(0, ref.getFirstCell().getRow()); assertEquals(0, ref.getFirstCell().getRow());
assertEquals(0, ref.getFirstCell().getCol()); assertEquals(0, ref.getFirstCell().getCol());
@ -1483,6 +1382,7 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
Workbook workbook = XSSFTestDataSamples.openSampleWorkbook("54436.xlsx"); Workbook workbook = XSSFTestDataSamples.openSampleWorkbook("54436.xlsx");
if(!WorkbookEvaluator.getSupportedFunctionNames().contains("GETPIVOTDATA")){ if(!WorkbookEvaluator.getSupportedFunctionNames().contains("GETPIVOTDATA")){
Function func = new Function() { Function func = new Function() {
@Override
public ValueEval evaluate(ValueEval[] args, int srcRowIndex, int srcColumnIndex) { public ValueEval evaluate(ValueEval[] args, int srcRowIndex, int srcColumnIndex) {
return ErrorEval.NA; return ErrorEval.NA;
} }
@ -2095,20 +1995,6 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
} }
} }
@Test
public void bug57430() throws Exception {
XSSFWorkbook wb = new XSSFWorkbook();
try {
wb.createSheet("Sheet1");
XSSFName name1 = wb.createName();
name1.setNameName("FMLA");
name1.setRefersToFormula("Sheet1!$B$3");
} finally {
wb.close();
}
}
/** /**
* A .xlsx file with no Shared Strings table should open fine * A .xlsx file with no Shared Strings table should open fine
* in read-only mode * in read-only mode
@ -2507,6 +2393,7 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
tmp.delete(); tmp.delete();
} }
@Test @Test
public void test56574() throws IOException { public void test56574() throws IOException {
runTest56574(false); runTest56574(false);
@ -2599,5 +2486,5 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
} }
wb.close(); wb.close();
} }
} }

94
src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
View File

@ -32,6 +32,7 @@ import java.io.FileNotFoundException;
import java.io.FileOutputStream; import java.io.FileOutputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.io.OutputStream;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Calendar; import java.util.Calendar;
@ -291,7 +292,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
HSSFCell d1 = w.getSheetAt(0).getRow(3).getCell(0); HSSFCell d1 = w.getSheetAt(0).getRow(3).getCell(0);
HSSFCell d2 = w.getSheetAt(0).getRow(3).getCell(1); HSSFCell d2 = w.getSheetAt(0).getRow(3).getCell(1);
if (false) { /*
// THAI code page // THAI code page
System.out.println("a1="+unicodeString(a1)); System.out.println("a1="+unicodeString(a1));
System.out.println("a2="+unicodeString(a2)); System.out.println("a2="+unicodeString(a2));
@ -304,7 +305,8 @@ public final class TestBugs extends BaseTestBugzillaIssues {
// US+THAI // US+THAI
System.out.println("d1="+unicodeString(d1)); System.out.println("d1="+unicodeString(d1));
System.out.println("d2="+unicodeString(d2)); System.out.println("d2="+unicodeString(d2));
} */
confirmSameCellText(a1, a2); confirmSameCellText(a1, a2);
confirmSameCellText(b1, b2); confirmSameCellText(b1, b2);
confirmSameCellText(c1, c2); confirmSameCellText(c1, c2);
@ -336,7 +338,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
assertEquals(a.getRichStringCellValue().getString(), b.getRichStringCellValue().getString()); assertEquals(a.getRichStringCellValue().getString(), b.getRichStringCellValue().getString());
} }
private static String unicodeString(HSSFCell cell) { /*private static String unicodeString(HSSFCell cell) {
String ss = cell.getRichStringCellValue().getString(); String ss = cell.getRichStringCellValue().getString();
char s[] = ss.toCharArray(); char s[] = ss.toCharArray();
StringBuffer sb = new StringBuffer(); StringBuffer sb = new StringBuffer();
@ -344,7 +346,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
sb.append("\\u").append(Integer.toHexString(s[x])); sb.append("\\u").append(Integer.toHexString(s[x]));
} }
return sb.toString(); return sb.toString();
} }*/
/** Error in opening wb*/ /** Error in opening wb*/
@Test @Test
@ -886,7 +888,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
List<HSSFObjectData> objects = wb.getAllEmbeddedObjects(); List<HSSFObjectData> objects = wb.getAllEmbeddedObjects();
assertEquals(1, objects.size()); assertEquals(1, objects.size());
HSSFObjectData obj = (HSSFObjectData)objects.get(0); HSSFObjectData obj = objects.get(0);
assertNotNull(obj); assertNotNull(obj);
// Peek inside the underlying record // Peek inside the underlying record
@ -975,9 +977,10 @@ public final class TestBugs extends BaseTestBugzillaIssues {
/** /**
* Test that fonts get added properly * Test that fonts get added properly
* @throws IOException
*/ */
@Test @Test
public void bug45338() { public void bug45338() throws IOException {
HSSFWorkbook wb = new HSSFWorkbook(); HSSFWorkbook wb = new HSSFWorkbook();
assertEquals(4, wb.getNumberOfFonts()); assertEquals(4, wb.getNumberOfFonts());
@ -1056,6 +1059,8 @@ public final class TestBugs extends BaseTestBugzillaIssues {
"Thingy", false, true, (short)2, (byte)2 "Thingy", false, true, (short)2, (byte)2
) )
); );
wb.close();
} }
/** /**
@ -1200,9 +1205,10 @@ public final class TestBugs extends BaseTestBugzillaIssues {
/** /**
* People are all getting confused about the last * People are all getting confused about the last
* row and cell number * row and cell number
* @throws IOException
*/ */
@Test @Test
public void bug30635() { public void bug30635() throws IOException {
HSSFWorkbook wb = new HSSFWorkbook(); HSSFWorkbook wb = new HSSFWorkbook();
HSSFSheet s = wb.createSheet(); HSSFSheet s = wb.createSheet();
@ -1245,6 +1251,8 @@ public final class TestBugs extends BaseTestBugzillaIssues {
assertEquals(0, r.getFirstCellNum()); assertEquals(0, r.getFirstCellNum());
assertEquals(5, r.getLastCellNum()); // last cell # + 1 assertEquals(5, r.getLastCellNum()); // last cell # + 1
assertEquals(3, r.getPhysicalNumberOfCells()); assertEquals(3, r.getPhysicalNumberOfCells());
wb.close();
} }
/** /**
@ -1571,7 +1579,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
try { try {
OPOIFSFileSystem fs = new OPOIFSFileSystem( OPOIFSFileSystem fs = new OPOIFSFileSystem(
HSSFITestDataProvider.instance.openWorkbookStream("46904.xls")); HSSFITestDataProvider.instance.openWorkbookStream("46904.xls"));
new HSSFWorkbook(fs.getRoot(), false); new HSSFWorkbook(fs.getRoot(), false).close();
fail(); fail();
} catch(OldExcelFormatException e) { } catch(OldExcelFormatException e) {
assertTrue(e.getMessage().startsWith( assertTrue(e.getMessage().startsWith(
@ -1581,8 +1589,12 @@ public final class TestBugs extends BaseTestBugzillaIssues {
try { try {
NPOIFSFileSystem fs = new NPOIFSFileSystem( NPOIFSFileSystem fs = new NPOIFSFileSystem(
HSSFITestDataProvider.instance.openWorkbookStream("46904.xls")); HSSFITestDataProvider.instance.openWorkbookStream("46904.xls"));
new HSSFWorkbook(fs.getRoot(), false); try {
fail(); new HSSFWorkbook(fs.getRoot(), false).close();
fail();
} finally {
fs.close();
}
} catch(OldExcelFormatException e) { } catch(OldExcelFormatException e) {
assertTrue(e.getMessage().startsWith( assertTrue(e.getMessage().startsWith(
"The supplied spreadsheet seems to be Excel" "The supplied spreadsheet seems to be Excel"
@ -2020,9 +2032,10 @@ public final class TestBugs extends BaseTestBugzillaIssues {
/** /**
* Last row number when shifting rows * Last row number when shifting rows
* @throws IOException
*/ */
@Test @Test
public void bug50416LastRowNumber() { public void bug50416LastRowNumber() throws IOException {
// Create the workbook with 1 sheet which contains 3 rows // Create the workbook with 1 sheet which contains 3 rows
HSSFWorkbook workbook = new HSSFWorkbook(); HSSFWorkbook workbook = new HSSFWorkbook();
Sheet sheet = workbook.createSheet("Bug50416"); Sheet sheet = workbook.createSheet("Bug50416");
@ -2071,6 +2084,8 @@ public final class TestBugs extends BaseTestBugzillaIssues {
assertEquals("Cell A,2", sheet.getRow(0).getCell(0).getStringCellValue()); assertEquals("Cell A,2", sheet.getRow(0).getCell(0).getStringCellValue());
assertEquals("Cell A,1", sheet.getRow(1).getCell(0).getStringCellValue()); assertEquals("Cell A,1", sheet.getRow(1).getCell(0).getStringCellValue());
assertEquals("Cell A,3", sheet.getRow(2).getCell(0).getStringCellValue()); assertEquals("Cell A,3", sheet.getRow(2).getCell(0).getStringCellValue());
workbook.close();
} }
/** /**
@ -2376,6 +2391,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
InternalSheet ish = HSSFTestHelper.getSheetForTest(sh); InternalSheet ish = HSSFTestHelper.getSheetForTest(sh);
PageSettingsBlock psb = (PageSettingsBlock) ish.getRecords().get(13); PageSettingsBlock psb = (PageSettingsBlock) ish.getRecords().get(13);
psb.visitContainedRecords(new RecordAggregate.RecordVisitor() { psb.visitContainedRecords(new RecordAggregate.RecordVisitor() {
@Override
public void visitRecord(Record r) { public void visitRecord(Record r) {
list.add(r.getSid()); list.add(r.getSid());
} }
@ -2385,7 +2401,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
} }
@Test @Test
public void bug52272(){ public void bug52272() throws IOException{
HSSFWorkbook wb = new HSSFWorkbook(); HSSFWorkbook wb = new HSSFWorkbook();
HSSFSheet sh = wb.createSheet(); HSSFSheet sh = wb.createSheet();
HSSFPatriarch p = sh.createDrawingPatriarch(); HSSFPatriarch p = sh.createDrawingPatriarch();
@ -2395,14 +2411,17 @@ public final class TestBugs extends BaseTestBugzillaIssues {
HSSFSheet sh2 = wb.cloneSheet(0); HSSFSheet sh2 = wb.cloneSheet(0);
assertNotNull(sh2.getDrawingPatriarch()); assertNotNull(sh2.getDrawingPatriarch());
wb.close();
} }
@Test @Test
public void bug53432(){ public void bug53432() throws IOException{
Workbook wb = new HSSFWorkbook(); //or new HSSFWorkbook(); Workbook wb = new HSSFWorkbook(); //or new HSSFWorkbook();
wb.addPicture(new byte[]{123,22}, Workbook.PICTURE_TYPE_JPEG); wb.addPicture(new byte[]{123,22}, Workbook.PICTURE_TYPE_JPEG);
assertEquals(wb.getAllPictures().size(), 1); assertEquals(wb.getAllPictures().size(), 1);
wb.close();
wb = new HSSFWorkbook(); wb = new HSSFWorkbook();
wb = writeOutAndReadBack((HSSFWorkbook) wb); wb = writeOutAndReadBack((HSSFWorkbook) wb);
assertEquals(wb.getAllPictures().size(), 0); assertEquals(wb.getAllPictures().size(), 0);
@ -2411,6 +2430,8 @@ public final class TestBugs extends BaseTestBugzillaIssues {
wb = writeOutAndReadBack((HSSFWorkbook) wb); wb = writeOutAndReadBack((HSSFWorkbook) wb);
assertEquals(wb.getAllPictures().size(), 1); assertEquals(wb.getAllPictures().size(), 1);
wb.close();
} }
@Test @Test
@ -2560,12 +2581,12 @@ public final class TestBugs extends BaseTestBugzillaIssues {
Workbook wbBack = HSSFTestDataSamples.writeOutAndReadBack(wb); Workbook wbBack = HSSFTestDataSamples.writeOutAndReadBack(wb);
assertEquals(4, wbBack.getNumberOfSheets()); assertEquals(4, wbBack.getNumberOfSheets());
// OutputStream fOut = new FileOutputStream("/tmp/56325a.xls"); OutputStream fOut = new FileOutputStream("C:\\temp\\56325a.xls");
// try { try {
// wb.write(fOut); wb.write(fOut);
// } finally { } finally {
// fOut.close(); fOut.close();
// } }
} }
/** /**
@ -2758,4 +2779,39 @@ public final class TestBugs extends BaseTestBugzillaIssues {
wb.close(); wb.close();
} }
@Test
public void test48043() throws IOException {
HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("56325a.xls");
wb.removeSheetAt(2);
wb.removeSheetAt(1);
//Sheet s = wb.createSheet("sheetname");
Sheet s = wb.getSheetAt(0);
Row row = s.createRow(0);
Cell cell = row.createCell(0);
cell.setCellFormula(
"IF(AND(ISBLANK(A10)," +
"ISBLANK(B10)),\"\"," +
"CONCATENATE(A10,\"-\",B10))");
FormulaEvaluator eval = wb.getCreationHelper().createFormulaEvaluator();
eval.evaluateAll();
/*OutputStream out = new FileOutputStream("C:\\temp\\48043.xls");
try {
wb.write(out);
} finally {
out.close();
}*/
Workbook wbBack = HSSFTestDataSamples.writeOutAndReadBack(wb);
assertNotNull(wbBack);
wbBack.close();
wb.close();
}
} }

207
src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java
View File

@ -123,7 +123,7 @@ public abstract class BaseTestBugzillaIssues {
* Merged regions were being removed from the parent in cloned sheets * Merged regions were being removed from the parent in cloned sheets
*/ */
@Test @Test
public final void bug22720() { public void bug22720() {
Workbook workBook = _testDataProvider.createWorkbook(); Workbook workBook = _testDataProvider.createWorkbook();
workBook.createSheet("TEST"); workBook.createSheet("TEST");
Sheet template = workBook.getSheetAt(0); Sheet template = workBook.getSheetAt(0);
@ -247,7 +247,7 @@ public abstract class BaseTestBugzillaIssues {
} }
@Test @Test
public final void bug18800() { public void bug18800() {
Workbook book = _testDataProvider.createWorkbook(); Workbook book = _testDataProvider.createWorkbook();
book.createSheet("TEST"); book.createSheet("TEST");
Sheet sheet = book.cloneSheet(0); Sheet sheet = book.cloneSheet(0);
@ -276,7 +276,7 @@ public abstract class BaseTestBugzillaIssues {
} }
@Test @Test
public final void bug43093() { public void bug43093() {
Workbook xlw = _testDataProvider.createWorkbook(); Workbook xlw = _testDataProvider.createWorkbook();
addNewSheetWithCellsA1toD4(xlw, 1); addNewSheetWithCellsA1toD4(xlw, 1);
@ -296,7 +296,7 @@ public abstract class BaseTestBugzillaIssues {
} }
@Test @Test
public final void bug46729_testMaxFunctionArguments(){ public void bug46729_testMaxFunctionArguments(){
String[] func = {"COUNT", "AVERAGE", "MAX", "MIN", "OR", "SUBTOTAL", "SKEW"}; String[] func = {"COUNT", "AVERAGE", "MAX", "MIN", "OR", "SUBTOTAL", "SKEW"};
SpreadsheetVersion ssVersion = _testDataProvider.getSpreadsheetVersion(); SpreadsheetVersion ssVersion = _testDataProvider.getSpreadsheetVersion();
@ -534,7 +534,7 @@ public abstract class BaseTestBugzillaIssues {
assertAlmostEquals(1950, s.getColumnWidth(10), fontAccuracy); assertAlmostEquals(1950, s.getColumnWidth(10), fontAccuracy);
assertAlmostEquals(2225, s.getColumnWidth(11), fontAccuracy); assertAlmostEquals(2225, s.getColumnWidth(11), fontAccuracy);
} }
/** /**
* =ISNUMBER(SEARCH("AM",A1)) evaluation * =ISNUMBER(SEARCH("AM",A1)) evaluation
*/ */
@ -806,4 +806,201 @@ public abstract class BaseTestBugzillaIssues {
wb.close(); wb.close();
} }
/**
* With HSSF, if you create a font, don't change it, and
* create a 2nd, you really do get two fonts that you
* can alter as and when you want.
* With XSSF, that wasn't the case, but this verfies
* that it now is again
*/
@Test
public void bug48718() throws Exception {
Workbook wb = _testDataProvider.createWorkbook();
int startingFonts = wb instanceof HSSFWorkbook ? 4 : 1;
assertEquals(startingFonts, wb.getNumberOfFonts());
// Get a font, and slightly change it
Font a = wb.createFont();
assertEquals(startingFonts+1, wb.getNumberOfFonts());
a.setFontHeightInPoints((short)23);
assertEquals(startingFonts+1, wb.getNumberOfFonts());
// Get two more, unchanged
/*Font b =*/ wb.createFont();
assertEquals(startingFonts+2, wb.getNumberOfFonts());
/*Font c =*/ wb.createFont();
assertEquals(startingFonts+3, wb.getNumberOfFonts());
}
@Test
public void bug57430() throws Exception {
Workbook wb = _testDataProvider.createWorkbook();
try {
wb.createSheet("Sheet1");
Name name1 = wb.createName();
name1.setNameName("FMLA");
name1.setRefersToFormula("Sheet1!$B$3");
} finally {
wb.close();
}
}
@Test
public void bug56981() throws IOException {
Workbook wb = _testDataProvider.createWorkbook();
CellStyle vertTop = wb.createCellStyle();
vertTop.setVerticalAlignment(CellStyle.VERTICAL_TOP);
CellStyle vertBottom = wb.createCellStyle();
vertBottom.setVerticalAlignment(CellStyle.VERTICAL_BOTTOM);
Sheet sheet = wb.createSheet("Sheet 1");
Row row = sheet.createRow(0);
Cell top = row.createCell(0);
Cell bottom = row.createCell(1);
top.setCellValue("Top");
top.setCellStyle(vertTop); // comment this out to get all bottom-aligned
// cells
bottom.setCellValue("Bottom");
bottom.setCellStyle(vertBottom);
row.setHeightInPoints(85.75f); // make it obvious
/*FileOutputStream out = new FileOutputStream("c:\\temp\\56981.xlsx");
try {
wb.write(out);
} finally {
out.close();
}*/
wb.close();
}
@Test
public void test57973() throws IOException {
Workbook wb = _testDataProvider.createWorkbook();
CreationHelper factory = wb.getCreationHelper();
Sheet sheet = wb.createSheet();
Drawing drawing = sheet.createDrawingPatriarch();
ClientAnchor anchor = factory.createClientAnchor();
Cell cell0 = sheet.createRow(0).createCell(0);
cell0.setCellValue("Cell0");
Comment comment0 = drawing.createCellComment(anchor);
RichTextString str0 = factory.createRichTextString("Hello, World1!");
comment0.setString(str0);
comment0.setAuthor("Apache POI");
cell0.setCellComment(comment0);
anchor = factory.createClientAnchor();
anchor.setCol1(1);
anchor.setCol2(1);
anchor.setRow1(1);
anchor.setRow2(1);
Cell cell1 = sheet.createRow(3).createCell(5);
cell1.setCellValue("F4");
Comment comment1 = drawing.createCellComment(anchor);
RichTextString str1 = factory.createRichTextString("Hello, World2!");
comment1.setString(str1);
comment1.setAuthor("Apache POI");
cell1.setCellComment(comment1);
Cell cell2 = sheet.createRow(2).createCell(2);
cell2.setCellValue("C3");
anchor = factory.createClientAnchor();
anchor.setCol1(2);
anchor.setCol2(2);
anchor.setRow1(2);
anchor.setRow2(2);
Comment comment2 = drawing.createCellComment(anchor);
RichTextString str2 = factory.createRichTextString("XSSF can set cell comments");
//apply custom font to the text in the comment
Font font = wb.createFont();
font.setFontName("Arial");
font.setFontHeightInPoints((short)14);
font.setBoldweight(Font.BOLDWEIGHT_BOLD);
font.setColor(IndexedColors.RED.getIndex());
str2.applyFont(font);
comment2.setString(str2);
comment2.setAuthor("Apache POI");
comment2.setColumn(2);
comment2.setRow(2);
/*OutputStream out = new FileOutputStream("C:\\temp\\57973.xlsx");
try {
wb.write(out);
} finally {
out.close();
}*/
wb.close();
}
/**
* Ensures that XSSF and HSSF agree with each other,
* and with the docs on when fetching the wrong
* kind of value from a Formula cell
*/
@Test
public void bug47815() {
Workbook wb = _testDataProvider.createWorkbook();
Sheet s = wb.createSheet();
Row r = s.createRow(0);
// Setup
Cell cn = r.createCell(0, Cell.CELL_TYPE_NUMERIC);
cn.setCellValue(1.2);
Cell cs = r.createCell(1, Cell.CELL_TYPE_STRING);
cs.setCellValue("Testing");
Cell cfn = r.createCell(2, Cell.CELL_TYPE_FORMULA);
cfn.setCellFormula("A1");
Cell cfs = r.createCell(3, Cell.CELL_TYPE_FORMULA);
cfs.setCellFormula("B1");
FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator();
assertEquals(Cell.CELL_TYPE_NUMERIC, fe.evaluate(cfn).getCellType());
assertEquals(Cell.CELL_TYPE_STRING, fe.evaluate(cfs).getCellType());
fe.evaluateFormulaCell(cfn);
fe.evaluateFormulaCell(cfs);
// Now test
assertEquals(Cell.CELL_TYPE_NUMERIC, cn.getCellType());
assertEquals(Cell.CELL_TYPE_STRING, cs.getCellType());
assertEquals(Cell.CELL_TYPE_FORMULA, cfn.getCellType());
assertEquals(Cell.CELL_TYPE_NUMERIC, cfn.getCachedFormulaResultType());
assertEquals(Cell.CELL_TYPE_FORMULA, cfs.getCellType());
assertEquals(Cell.CELL_TYPE_STRING, cfs.getCachedFormulaResultType());
// Different ways of retrieving
assertEquals(1.2, cn.getNumericCellValue(), 0);
try {
cn.getRichStringCellValue();
fail();
} catch(IllegalStateException e) {}
assertEquals("Testing", cs.getStringCellValue());
try {
cs.getNumericCellValue();
fail();
} catch(IllegalStateException e) {}
assertEquals(1.2, cfn.getNumericCellValue(), 0);
try {
cfn.getRichStringCellValue();
fail();
} catch(IllegalStateException e) {}
assertEquals("Testing", cfs.getStringCellValue());
try {
cfs.getNumericCellValue();
fail();
} catch(IllegalStateException e) {}
}
} }