diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java b/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
index 698e20a06..b1cf0fced 100644
--- a/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
+++ b/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
@@ -1386,9 +1386,8 @@ public final class HSSFSheet implements org.apache.poi.ss.usermodel.Sheet {
*
* @param numerator The numerator for the zoom magnification.
* @param denominator The denominator for the zoom magnification.
- * @deprecated 2015-11-23 (circa POI 3.14beta1). Use {@link #setZoom(int)} instead.
+ * @see #setZoom(int)
*/
- @Override
public void setZoom(int numerator, int denominator) {
if (numerator < 1 || numerator > 65535)
throw new IllegalArgumentException("Numerator must be greater than 0 and less than 65536");
diff --git a/src/java/org/apache/poi/ss/usermodel/Sheet.java b/src/java/org/apache/poi/ss/usermodel/Sheet.java
index 34521fd43..3c064600b 100644
--- a/src/java/org/apache/poi/ss/usermodel/Sheet.java
+++ b/src/java/org/apache/poi/ss/usermodel/Sheet.java
@@ -25,6 +25,7 @@ import java.util.Map;
import org.apache.poi.ss.util.CellAddress;
import org.apache.poi.ss.util.CellRangeAddress;
import org.apache.poi.ss.util.PaneInformation;
+import org.apache.poi.util.Removal;
/**
* High level representation of a Excel worksheet.
@@ -624,6 +625,7 @@ public interface Sheet extends Iterable
* Note that XSSF offers more kinds of document headers than HSSF does
*
* Note that XSSF offers more kinds of document footers than HSSF does.
- *
+ *
+ *
* Note: multiple sheets can be selected, but only one sheet can be active at one time.
- *null
@@ -784,9 +785,9 @@ public class SXSSFSheet implements Sheet
/**
* Gets the user model for the default document footer.
- *
+ * null
*/
@Override
@@ -797,9 +798,9 @@ public class SXSSFSheet implements Sheet
/**
* Sets a flag indicating whether this sheet is selected.
- *
true
if this sheet is selected
* @see Workbook#setActiveSheet(int)
*/
@@ -836,7 +837,7 @@ public class SXSSFSheet implements Sheet
/**
* Answer whether protection is enabled or disabled
*
- * @return true => protection enabled; false => protection disabled
+ * @return true means protection enabled; false means protection disabled
*/
@Override
public boolean getProtect()
@@ -857,7 +858,7 @@ public class SXSSFSheet implements Sheet
/**
* Answer whether scenario protection is enabled or disabled
*
- * @return true => protection enabled; false => protection disabled
+ * @return true means protection enabled; false means protection disabled
*/
@Override
public boolean getScenarioProtect()
@@ -866,7 +867,7 @@ public class SXSSFSheet implements Sheet
}
/**
- * Sets the zoom magnication for the sheet. The zoom is expressed as a
+ * Sets the zoom magnification for the sheet. The zoom is expressed as a
* fraction. For example to express a zoom of 75% use 3 for the numerator
* and 4 for the denominator.
*
@@ -874,6 +875,7 @@ public class SXSSFSheet implements Sheet
* @param denominator The denominator for the zoom magnification.
* @deprecated 2015-11-23 (circa POI 3.14beta1). Use {@link #setZoom(int)} instead.
*/
+ @Removal(version="3.16")
@Override
public void setZoom(int numerator, int denominator)
{
@@ -882,7 +884,7 @@ public class SXSSFSheet implements Sheet
/**
* Window zoom magnification for current view representing percent values.
- * Valid values range from 10 to 400. Horizontal & Vertical scale together.
+ * Valid values range from 10 to 400. Horizontal and Vertical scale together.
*
* For example:
* @@ -1308,7 +1310,7 @@ public class SXSSFSheet implements Sheet * * * @param rownum index of row to update (0-based) - * @param level outline level (> 0) + * @param level outline level (greater than 0) */ public void setRowOutlineLevel(int rownum, int level) { diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java index 8188c9e72..6993579cc 100644 --- a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java +++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java @@ -82,11 +82,11 @@ import org.apache.poi.xssf.usermodel.XSSFWorkbook; */ public class SXSSFWorkbook implements Workbook { /** - * Specifies how many rows can be accessed at most via getRow(). - * When a new node is created via createRow() and the total number + * Specifies how many rows can be accessed at most via {@link SXSSFSheet#getRow}. + * When a new node is created via {@link SXSSFSheet#createRow} and the total number * of unflushed records would exceed the specified value, then the * row with the lowest index value is flushed and cannot be accessed - * via getRow() anymore. + * via {@link SXSSFSheet#getRow} anymore. */ public static final int DEFAULT_WINDOW_SIZE = 100; private static final POILogger logger = POILogFactory.getLogger(SXSSFWorkbook.class); @@ -116,8 +116,8 @@ public class SXSSFWorkbook implements Workbook { } /** - * Construct a workbook from a template. - *+ *
Construct a workbook from a template.
+ * * There are three use-cases to use SXSSFWorkbook(XSSFWorkbook) : **
* All three use cases can work in a combination. - * + * * What is not supported: *- @@ -126,7 +126,7 @@ public class SXSSFWorkbook implements Workbook { *
*- * Append rows to existing sheets. The row number MUST be greater - * than max(rownum) in the template sheet. + * than {@code max(rownum)} in the template sheet. *
*- * Use existing workbook as a template and re-use global objects such @@ -134,13 +134,13 @@ public class SXSSFWorkbook implements Workbook { *
*
null
.
* - * When a new node is created via createRow() and the total number + * When a new node is created via {@link SXSSFSheet#createRow} and the total number * of unflushed records would exceed the specified value, then the * row with the lowest index value is flushed and cannot be accessed - * via getRow() anymore. + * via {@link SXSSFSheet#getRow} anymore. *
*
- * A value of -1 indicates unlimited access. In this case all
- * records that have not been flushed by a call to flush() are available
+ * A value of -1
indicates unlimited access. In this case all
+ * records that have not been flushed by a call to flush()
are available
* for random access.
+ *
- *
- * A value of 0 is not allowed because it would flush any newly created row + * A value of0
is not allowed because it would flush any newly created row
* without having a chance to specify any cells.
*
*
@@ -182,18 +182,18 @@ public class SXSSFWorkbook implements Workbook {
/**
* Constructs an workbook from an existing workbook.
* - * When a new node is created via createRow() and the total number + * When a new node is created via {@link SXSSFSheet#createRow} and the total number * of unflushed records would exceed the specified value, then the * row with the lowest index value is flushed and cannot be accessed - * via getRow() anymore. + * via {@link SXSSFSheet#getRow} anymore. *
*
- * A value of -1 indicates unlimited access. In this case all
- * records that have not been flushed by a call to flush() are available
+ * A value of -1
indicates unlimited access. In this case all
+ * records that have not been flushed by a call to flush()
are available
* for random access.
+ *
- *
- * A value of 0 is not allowed because it would flush any newly created row + * A value of0
is not allowed because it would flush any newly created row
* without having a chance to specify any cells.
*
*
@@ -207,18 +207,18 @@ public class SXSSFWorkbook implements Workbook {
/**
* Constructs an workbook from an existing workbook.
* - * When a new node is created via createRow() and the total number + * When a new node is created via {@link SXSSFSheet#createRow} and the total number * of unflushed records would exceed the specified value, then the * row with the lowest index value is flushed and cannot be accessed - * via getRow() anymore. + * via {@link SXSSFSheet#getRow} anymore. *
*
- * A value of -1 indicates unlimited access. In this case all
- * records that have not been flushed by a call to flush() are available
+ * A value of -1
indicates unlimited access. In this case all
+ * records that have not been flushed by a call to flush()
are available
* for random access.
+ *
- *
- * A value of 0 is not allowed because it would flush any newly created row + * A value of0
is not allowed because it would flush any newly created row
* without having a chance to specify any cells.
*
*
@@ -250,18 +250,18 @@ public class SXSSFWorkbook implements Workbook {
/**
* Construct an empty workbook and specify the window for row access.
* - * When a new node is created via createRow() and the total number + * When a new node is created via {@link SXSSFSheet#createRow} and the total number * of unflushed records would exceed the specified value, then the * row with the lowest index value is flushed and cannot be accessed - * via getRow() anymore. + * via {@link SXSSFSheet#getRow} anymore. *
*
- * A value of -1 indicates unlimited access. In this case all
- * records that have not been flushed by a call to flush() are available
+ * A value of -1
indicates unlimited access. In this case all
+ * records that have not been flushed by a call to flush()
are available
* for random access.
+ *
- *
- * A value of 0 is not allowed because it would flush any newly created row + * A value of0
is not allowed because it would flush any newly created row
* without having a chance to specify any cells.
*
*
@@ -754,7 +754,7 @@ public class SXSSFWorkbook implements Workbook {
/**
* Get the Sheet object at the given index.
*
- * @param index of the sheet number (0-based physical & logical)
+ * @param index of the sheet number (0-based physical and logical)
* @return Sheet at the provided index
*/
@Override
@@ -1026,12 +1026,13 @@ public class SXSSFWorkbook implements Workbook {
}
/**
- * Gets the defined name index by name-1
if not found.
*/
@Override
public int getNameIndex(String name)
diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java
index b0287e05c..4aa2f037e 100644
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java
@@ -618,7 +618,7 @@ public final class XSSFCell implements Cell {
/**
* Return the cell's style.
*
- * @return the cell's style.
+ * @return the cell's style.
*/
@Override
public XSSFCellStyle getCellStyle() {
diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
index efd45943f..c7cb28f5b 100644
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
@@ -78,6 +78,7 @@ import org.apache.poi.util.Beta;
import org.apache.poi.util.Internal;
import org.apache.poi.util.POILogFactory;
import org.apache.poi.util.POILogger;
+import org.apache.poi.util.Removal;
import org.apache.poi.xssf.model.CommentsTable;
import org.apache.poi.xssf.usermodel.helpers.ColumnHelper;
import org.apache.poi.xssf.usermodel.helpers.XSSFIgnoredErrorHelper;
@@ -2740,6 +2741,7 @@ public class XSSFSheet extends POIXMLDocumentPart implements Sheet {
* @param denominator The denominator for the zoom magnification.
* @deprecated 2015-11-23 (circa POI 3.14beta1). Use {@link #setZoom(int)} instead.
*/
+ @Removal(version="3.16")
@Override
public void setZoom(int numerator, int denominator) {
int zoom = 100*numerator/denominator;