mirror of
https://github.com/moparisthebest/pacman
synced 2024-11-14 21:35:02 -05:00
3cb1669e07
Extract array detection into its own utility function that ensures extglob is enabled. Suggested-by: Dave Reisner <dreisner@archlinux.org> Signed-off-by: Allan McRae <allan@archlinux.org>
108 lines
2.9 KiB
Bash
108 lines
2.9 KiB
Bash
#!/bin/bash
|
|
#
|
|
# variable.sh - Check that variables are or are not arrays as appropriate
|
|
#
|
|
# Copyright (c) 2014-2016 Pacman Development Team <pacman-dev@archlinux.org>
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
[[ -n "$LIBMAKEPKG_LINT_PKGBUILD_VARIABLE_SH" ]] && return
|
|
LIBMAKEPKG_LINT_PKGBUILD_VARIABLE_SH=1
|
|
|
|
LIBRARY=${LIBRARY:-'@libmakepkgdir@'}
|
|
|
|
source "$LIBRARY/util/message.sh"
|
|
source "$LIBRARY/util/pkgbuild.sh"
|
|
|
|
lint_pkgbuild_functions+=('lint_variable')
|
|
|
|
|
|
lint_variable() {
|
|
# TODO: refactor - similar arrays are used elsewhere
|
|
local array=(arch backup checkdepends groups license noextract options
|
|
validpgpkeys)
|
|
local arch_array=(conflicts depends makedepends md5sums optdepends provides
|
|
replaces sha1sums sha256sums sha384sums sha512sums source)
|
|
local string=(changelog epoch install pkgdesc pkgrel pkgver url)
|
|
|
|
local i a v pkg keys out bad ret=0
|
|
|
|
# global variables
|
|
for i in ${array[@]} ${arch_array[@]}; do
|
|
eval "keys=(\"\${!$i[@]}\")"
|
|
if (( ${#keys[*]} > 0 )); then
|
|
if ! is_array $i; then
|
|
error "$(gettext "%s should be an array")" "$i"
|
|
ret=1
|
|
fi
|
|
fi
|
|
done
|
|
|
|
for a in ${arch[@]}; do
|
|
[[ $a == "any" ]] && continue
|
|
|
|
for i in ${arch_array[@]}; do
|
|
v="${i}_${a}"
|
|
eval "keys=(\"\${!${v}[@]}\")"
|
|
if (( ${#keys[*]} > 0 )); then
|
|
if ! is_array $v; then
|
|
error "$(gettext "%s_%s should be an array")" "$i" "$a"
|
|
ret=1
|
|
fi
|
|
fi
|
|
done
|
|
done
|
|
|
|
for i in ${string[@]}; do
|
|
eval "keys=(\"\${!$i[@]}\")"
|
|
if (( ${#keys[*]} > 0 )); then
|
|
if is_array $i; then
|
|
error "$(gettext "%s should not be an array")" "$i"
|
|
ret=1
|
|
fi
|
|
fi
|
|
done
|
|
|
|
# package function variables
|
|
for pkg in ${pkgname[@]}; do
|
|
for i in ${array[@]} ${arch_array[@]}; do
|
|
if extract_function_variable "package_$pkg" $i 0 out; then
|
|
error "$(gettext "%s should be an array")" "$i"
|
|
ret=1
|
|
fi
|
|
done
|
|
|
|
for a in ${arch[@]}; do
|
|
[[ $a == "any" ]] && continue
|
|
|
|
for i in ${arch_array[@]}; do
|
|
if extract_function_variable "package_$pkg" "${i}_${a}" 0 out; then
|
|
error "$(gettext "%s_%s should be an array")" "$i" "$a"
|
|
ret=1
|
|
fi
|
|
done
|
|
done
|
|
|
|
for i in ${string[@]}; do
|
|
if extract_function_variable "package_$pkg" $i 1 out; then
|
|
error "$(gettext "%s should not be an array")" "$i"
|
|
ret=1
|
|
fi
|
|
done
|
|
done
|
|
|
|
return $ret
|
|
}
|