mirror of
https://github.com/moparisthebest/pacman
synced 2024-11-04 16:45:07 -05:00
6cebd4e602
Hopefully we've finally arrived at package handling nirvana, or at least this commit will get us a heck of a lot closer. The former method of getting the depends list for a package was the following: 1. call alpm_pkg_get_depends() 2. this method would check if the package came from the cache 3. if so, ensure our cache level is correct, otherwise call db_load 4. finally return the depends list Why did this suck? Because getting the depends list from the package shouldn't care about whether the package was loaded from a file, from the 'package cache', or some other system which we can't even use because the damn thing is so complicated. It should just return the depends list. So what does this commit change? It adds a pointer to a struct of function pointers to every package for all of these 'package operations' as I've decided to call them (I know, sounds completely straightforward, right?). So now when we call an alpm_pkg_get-* function, we don't do any of the cache logic or anything else there- we let the actual backend handle it by delegating all work to the method at pkg->ops->get_depends. Now that be_package has achieved equal status with be_files, we can treat packages from these completely different load points differently. We know a package loaded from a zip file will have all of its fields populated, so we can set up all its accessor functions to be direct accessors. On the other hand, the packages loaded from the local and sync DBs are not always fully-loaded, so their accessor functions are routed through the same logic as before. Net result? More code. However, this code now make it roughly 52 times easier to open the door to something like a read-only tar.gz database backend. Are you still reading? I'm impressed. Looking at the patch will probably be clearer than this long-winded explanation. Signed-off-by: Dan McGee <dan@archlinux.org> [Allan: rebase and adjust] Signed-off-by: Allan McRae <allan@archlinux.org> |
||
|---|---|---|
| .. | ||
| po | ||
| .gitignore | ||
| add.c | ||
| add.h | ||
| alpm_list.c | ||
| alpm_list.h | ||
| alpm.c | ||
| alpm.h | ||
| backup.c | ||
| backup.h | ||
| be_files.c | ||
| be_package.c | ||
| cache.c | ||
| cache.h | ||
| conflict.c | ||
| conflict.h | ||
| db.c | ||
| db.h | ||
| delta.c | ||
| delta.h | ||
| deps.c | ||
| deps.h | ||
| dload.c | ||
| dload.h | ||
| error.c | ||
| graph.h | ||
| group.c | ||
| group.h | ||
| handle.c | ||
| handle.h | ||
| log.c | ||
| log.h | ||
| Makefile.am | ||
| md5.c | ||
| md5.h | ||
| package.c | ||
| package.h | ||
| remove.c | ||
| remove.h | ||
| sync.c | ||
| sync.h | ||
| trans.c | ||
| trans.h | ||
| util.c | ||
| util.h | ||
| version.c | ||