mirror of
https://github.com/moparisthebest/pacman
synced 2024-12-22 07:48:50 -05:00
875c017e4d
The signedness of char is implementation defined. Since the alpm_graph state is clearly meant to be signed, make the signedness explicit. This fixes bugs on systems where char is unsigned, in comparissons of the following type: if(v.state == -1) which, if state is unsigned, will never be true due to integer promotion rules. Fixes failing test/pacman/tests/sync012.py when compiling with -funsigned-char. Fixes two warnings [-Wtype-limits] for comparissons with -1 when compiling with -funsigned-char. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Signed-off-by: Allan McRae <allan@archlinux.org>
41 lines
1.3 KiB
C
41 lines
1.3 KiB
C
/*
|
|
* graph.h - helpful graph structure and setup/teardown methods
|
|
*
|
|
* Copyright (c) 2007-2016 Pacman Development Team <pacman-dev@archlinux.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#ifndef _ALPM_GRAPH_H
|
|
#define _ALPM_GRAPH_H
|
|
|
|
#include <sys/types.h> /* off_t */
|
|
|
|
#include "alpm_list.h"
|
|
|
|
typedef struct __alpm_graph_t {
|
|
void *data;
|
|
struct __alpm_graph_t *parent; /* where did we come from? */
|
|
alpm_list_t *children;
|
|
alpm_list_t *childptr; /* points to a child in children list */
|
|
off_t weight; /* weight of the node */
|
|
signed char state; /* 0: untouched, -1: entered, other: leaving time */
|
|
} alpm_graph_t;
|
|
|
|
alpm_graph_t *_alpm_graph_new(void);
|
|
void _alpm_graph_free(void *data);
|
|
|
|
#endif /* _ALPM_GRAPH_H */
|
|
|
|
/* vim: set noet: */
|