moparisthebest
/
pacman
mirror of https://github.com/moparisthebest/pacman
1
0
Fork 0
Code Issues Releases Wiki Activity
pacman/lib/libalpm
History
Pang Yan Han 3865352d23 Remove redundant _alpm_strtrim() in be_local.c 
When reading the "desc" file in _alpm_local_db_read(), some
strings are trimmed and checked for length > 0 before their
use/duplication subsequently. They are then trimmed again
when there is no need to.

The following code snippet should illustrate it clearly:

while(fgets(line, sizeof(line), fp) &&
	strlen(_alpm_strtrim(line))) {

	char *linedup;
	STRDUP(linedup, _alpm_strtrim(line), goto error);
	info->groups = alpm_list_add(info->groups, linedup);
}

This patch removes the redundant _alpm_strtrim() calls in
_alpm_local_db_read() such as the one inside the STRDUP shown
above.

Signed-off-by: Pang Yan Han <pangyanhan@gmail.com>
Signed-off-by: Dan McGee <dan@archlinux.org>
 		2011-02-06 12:50:46 -06:00
..
po Update translation file indexes and Makevars 2011-02-04 09:15:51 -06:00
.gitignore Remove unnecessary entries from .gitignore files 2007-07-16 16:49:28 -04:00
Makefile.am Add a hash table for holding packages 2011-02-04 09:55:45 +10:00
add.c alpm: drop old target interfaces 2011-01-29 19:40:08 +01:00
add.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
alpm.c Remove need to explicitly register the local DB 2011-01-29 12:13:56 -06:00
alpm.h Read pkgcache into hash 2011-02-04 09:55:45 +10:00
alpm_list.c Add new alpm_list_remove_item() function 2011-02-04 09:55:46 +10:00
alpm_list.h Add new alpm_list_remove_item() function 2011-02-04 09:55:46 +10:00
backup.c Update copyright years for 2011 2011-01-07 18:47:37 -06:00
backup.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
be_local.c Remove redundant _alpm_strtrim() in be_local.c 2011-02-06 12:50:46 -06:00
be_package.c Fix locale.h/setlocale inclusion with --disable-nls 2011-02-01 09:59:12 -06:00
be_sync.c Change default sync hash table sizing to 66% full 2011-02-04 09:55:45 +10:00
conflict.c Read pkgcache into hash 2011-02-04 09:55:45 +10:00
conflict.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
db.c Actually remove packages from pkghash on removal 2011-02-04 09:55:45 +10:00
db.h Read pkgcache into hash 2011-02-04 09:55:45 +10:00
delta.c Update copyright years for 2011 2011-01-07 18:47:37 -06:00
delta.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
deps.c Read pkgcache into hash 2011-02-04 09:55:45 +10:00
deps.h alpm/depcmp: new NODEPVERSION flag 2011-01-31 10:49:39 -06:00
diskspace.c Call archive_read_data_skip() while checking diskspace 2011-01-11 21:15:24 -06:00
diskspace.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
dload.c Add comment about download file resolution 2011-02-04 09:15:22 -06:00
dload.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
error.c Handle PM_ERR_WRITE in alpm_strerror() 2011-02-04 14:21:43 -06:00
graph.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
group.c Update copyright years for 2011 2011-01-07 18:47:37 -06:00
group.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
handle.c Update copyright years for 2011 2011-01-07 18:47:37 -06:00
handle.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
log.c Update copyright years for 2011 2011-01-07 18:47:37 -06:00
log.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
md5.c libalpm md5: use larger and dynamic buffer 2010-09-02 10:33:21 -05:00
md5.h libalpm/md5: Fix license header 2008-06-03 21:31:31 -05:00
package.c Read pkgcache into hash 2011-02-04 09:55:45 +10:00
package.h Remove epoch as an independent field 2011-01-21 19:30:45 -06:00
pkghash.c Improve pkghash_remove algorithm 2011-02-04 10:03:04 +10:00
pkghash.h Actually remove packages from pkghash on removal 2011-02-04 09:55:45 +10:00
remove.c Read pkgcache into hash 2011-02-04 09:55:45 +10:00
remove.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
sync.c Read pkgcache into hash 2011-02-04 09:55:45 +10:00
sync.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
trans.c Update copyright years for 2011 2011-01-07 18:47:37 -06:00
trans.h Update copyright years for 2011 2011-01-07 18:47:37 -06:00
util.c Add more error checking and logging 2011-02-04 09:00:47 -06:00
util.h Add strndup fallback function to libalpm util 2011-01-21 09:14:47 -06:00
version.c Allow version comparison to contain epoch specifier 2011-01-21 19:30:45 -06:00