mirror of
https://github.com/moparisthebest/pacman
synced 2024-12-23 00:08:50 -05:00
d2dbb04a9a
Sorry for this being such a huge patch, but I believe it is necessary for quite a few reasons which I will attempt to explain herein. I've been mulling this over for a while, but wasn't super happy with making the download interface more complex. Instead, if we carefully order things in the internal download code, we can actually make the interface simpler. 1. FS#15657 - This involves `name.db.tar.gz.part` files being left around the filesystem, and then causing all sorts of issues when someone attempts to rerun the operation they canceled. We need to ensure that if we resume a download, we are resuming it on exactly the same file; if we cannot be almost postive of that then we need to start over. 2. http://www.mail-archive.com/pacman-dev@archlinux.org/msg03536.html - Here we have a lighttpd bug to ruin the day. If we send both a Range: header and If-Modified-Since: header across the wire in a GET request, lighttpd doesn't do what we want in several cases. If the file hadn't been modified, it returns a '304 Not Modified' instead of a '206 Partial Content'. We need to do a stat (e.g. HEAD in HTTP terms) operation here, and the proceed accordingly based off the values we get back from it. 3. The mtime stuff was rather ugly, and relied on the called function to write back to a passed in reference, which isn't the greatest. Instead, use the power of the filesystem to contain this info. Every file downloaded internally is now carefully timestamped with the remote file time. This should allow the resume logic to work. In order to guarantee this, we need to implement a signal handler that catches interrupts, notifies the running code, and causes it to set the mtimes on the file. It then rethrows the signal so the pacman signal handler (or any frontend) works as expected. 4. We did a lot of funky stuff in trying to track the DB last modified time. It is a lot easier to just keep the downloaded DB file around and track the time on that rather than in a funky dot file. It also kills a lot of code. 5. For GPG verification of the databases down the road, we are going to need the DB file around for at least a short bit of time anyway, so this gets us closer to that. Signed-off-by: Dan McGee <dan@archlinux.org> [Xav: fixed printf with off_t] Signed-off-by: Xavier Chantry <shiningxc@gmail.com> |
||
|---|---|---|
| .. | ||
| po | ||
| .gitignore | ||
| add.c | ||
| add.h | ||
| alpm_list.c | ||
| alpm_list.h | ||
| alpm.c | ||
| alpm.h | ||
| backup.c | ||
| backup.h | ||
| be_files.c | ||
| be_package.c | ||
| cache.c | ||
| cache.h | ||
| conflict.c | ||
| conflict.h | ||
| db.c | ||
| db.h | ||
| delta.c | ||
| delta.h | ||
| deps.c | ||
| deps.h | ||
| dload.c | ||
| dload.h | ||
| error.c | ||
| graph.h | ||
| group.c | ||
| group.h | ||
| handle.c | ||
| handle.h | ||
| log.c | ||
| log.h | ||
| Makefile.am | ||
| md5.c | ||
| md5.h | ||
| package.c | ||
| package.h | ||
| remove.c | ||
| remove.h | ||
| sync.c | ||
| sync.h | ||
| trans.c | ||
| trans.h | ||
| util.c | ||
| util.h | ||