moparisthebest
/
pacman
mirror of https://github.com/moparisthebest/pacman
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix segfault on x86_64 when using UseSyslog 

Due to differences in handling va_list between i686 and x86_64, this bug
can only be seen on x86_64. va_list usage is not allowed but we had been
getting away with it. See
http://lists.opensuse.org/opensuse-programming/2008-02/msg00005.html
for details and explanation.

This fixes FS#11096.

Signed-off-by: Dan McGee <dan@archlinux.org>
This commit is contained in:
Dan McGee 2008-08-08 22:18:00 -05:00
parent 57393eb730
commit d8f8a12665
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/libalpm/util.c
View File

@ -25,6 +25,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <stdarg.h>
#include <string.h>
#include <fcntl.h>
#include <unistd.h>
@ -401,12 +402,18 @@ int _alpm_rmrf(const char *path)
return(0);
}
int _alpm_logaction(unsigned short usesyslog, FILE *f, const char *fmt, va_list args)
int _alpm_logaction(unsigned short usesyslog, FILE *f,
const char *fmt, va_list args)
{
int ret = 0;
if(usesyslog) {
vsyslog(LOG_WARNING, fmt, args);
/* we can't use a va_list more than once, so we need to copy it
* so we can use the original when calling vfprintf below. */
va_list args_syslog;
va_copy(args_syslog, args);
vsyslog(LOG_WARNING, fmt, args_syslog);
va_end(args_syslog);
}
if(f) {