moparisthebest
/
pacman
mirror of https://github.com/moparisthebest/pacman
1
0
Fork 0
Code Issues Releases Wiki Activity

Store fgetc output as an int. 

Bug exposed on ARM when char is unsigned resulting in the comparison
to EOF always failing.

Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Allan McRae 2013-08-12 21:09:01 +10:00
parent d8c2ab0e6f
commit ce7456b4cc
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pacman/pacman.c
View File

@ -830,13 +830,15 @@ int main(int argc, char *argv[])
int target_found = 0;
size_t current_size = PATH_MAX;
char *vdata, *line = malloc(current_size);
int c;
/* remove the '-' from the list */
pm_targets = alpm_list_remove_str(pm_targets, "-", &vdata);
free(vdata);
i = 0;
while((line[i] = (char)fgetc(stdin)) != EOF) {
while((c = fgetc(stdin)) != EOF) {
line[i] = (char)c;
if(isspace((unsigned char)line[i])) {
/* avoid adding zero length arg when multiple spaces separate args */
if(i > 0) {