mirror of
https://github.com/moparisthebest/pacman
synced 2024-12-21 23:38:49 -05:00
One more sanity check, and one more ORE tag
This commit is contained in:
parent
7a01ed50b9
commit
c0f681a0ae
@ -212,6 +212,7 @@ int alpm_db_update(char *treename, char *archive)
|
||||
ASSERT(treename != NULL && strlen(treename) != 0, RET_ERR(PM_ERR_WRONG_ARGS, -1));
|
||||
|
||||
/* ORE
|
||||
Does it make sense to update the 'local' database, or should we prevent it?
|
||||
stat(archive); */
|
||||
|
||||
return(db_update(handle->root, handle->dbpath, treename, archive));
|
||||
@ -535,10 +536,26 @@ int alpm_logaction(char *fmt, ...)
|
||||
char str[LOG_STR_LEN];
|
||||
va_list args;
|
||||
|
||||
/* Sanity checks */
|
||||
ASSERT(handle != NULL, RET_ERR(PM_ERR_HANDLE_NULL, -1));
|
||||
|
||||
va_start(args, fmt);
|
||||
vsnprintf(str, LOG_STR_LEN, fmt, args);
|
||||
va_end(args);
|
||||
|
||||
/* ORE
|
||||
We should add a prefix to log strings depending on who called us.
|
||||
If logaction was called by the frontend:
|
||||
USER: <the frontend log>
|
||||
and if called internally:
|
||||
ALPM: <the library log>
|
||||
Moreover, the frontend should be able to choose its prefix (USER by default?):
|
||||
pacman: "PACMAN"
|
||||
kpacman: "KPACMAN"
|
||||
...
|
||||
It allows to share the log file between several frontends and to actually
|
||||
know who does what */
|
||||
|
||||
return(_alpm_log_action(handle->usesyslog, handle->logfd, str));
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user