llstat: modify path in place

This makes llstat's signature differ from lstat's, but we never actually
use it on a const string and this saves a large number of strdup's.
This also allows stripping multiple trailing slashes and corrects a bug
where calling llstat on "/" would result in calling lstat on an empty
string.

Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>

src/common/util-common.c

@@ -80,17 +80,21 @@ char *mdirname(const char *path)
  * @param buf structure to fill with stat information
  * @return the return code from lstat
  */
-int llstat(const char *path, struct stat *buf)
+int llstat(char *path, struct stat *buf)
 {
 	int ret;
+	char *c = NULL;
 	size_t len = strlen(path);
 
-	/* strip the trailing slash if one exists */
+	while(len > 1 && path[len - 1] == '/') {
-	if(len != 0 && path[len - 1] == '/') {
+		--len;
-		char *newpath = strdup(path);
+		c = path + len;
-		newpath[len - 1] = '\0';
+	}
-		ret = lstat(newpath, buf);
+
-		free(newpath);
+	if(c) {
+		*c = '\0';
+		ret = lstat(path, buf);
+		*c = '/';
 	} else {
 		ret = lstat(path, buf);
 	}

src/common/util-common.h

@@ -25,7 +25,7 @@
 const char *mbasename(const char *path);
 char *mdirname(const char *path);
 
-int llstat(const char *path, struct stat *buf);
+int llstat(char *path, struct stat *buf);
 
 #ifndef HAVE_STRNDUP
 char *strndup(const char *s, size_t n);