moparisthebest/pacman
1
0
Fork 0
mirror of https://github.com/moparisthebest/pacman synced 2024-12-22 15:58:50 -05:00
Code Issues Releases Wiki Activity

Update 'submitting-patches'

Browse Source 
Signed-off-by: Dan McGee <dan@archlinux.org>
This commit is contained in:
Dan McGee 2007-07-01 23:27:20 -04:00
parent 89ed15c9c2
commit 4d286e567b
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
submitting-patches
View File

@ -9,10 +9,15 @@ NOTE: Much of this is paraphrased from the kernel documentation's
Creating your patch: Creating your patch:
Most of this was more relevant before we switched to GIT for version control.
However, much of it is still applicable and should be followed. Some notes
have been added to make this a bit more up-to-date with the GIT workflow.
* Use "diff -up" or "diff -uprN" to create patches. * Use "diff -up" or "diff -uprN" to create patches.
These options make the diff easier to read for those of us who try to review These options make the diff easier to read for those of us who try to review
submitted patches. submitted patches. If you are working on your own git branch, then GIT
formatted patches are perfectly acceptable.
* Please try to make patches "p1 applicable" * Please try to make patches "p1 applicable"
@ -23,7 +28,8 @@ Creating your patch:
--- ORIGINAL_DIR/lib/libalpm/alpm.h --- ORIGINAL_DIR/lib/libalpm/alpm.h
+++ NEW_DIR/lib/libalpm/alpm.h +++ NEW_DIR/lib/libalpm/alpm.h
With '-p1' the ORIGINAL_DIR and NEW_DIR arguments are stripped. With '-p1' the ORIGINAL_DIR and NEW_DIR arguments are stripped. GIT produces
p1 formatted patches by default.
Submitting your patch: Submitting your patch:
@ -48,7 +54,9 @@ Submitting your patch:
Before the actual diff begins, it helps if you describe the changes in the Before the actual diff begins, it helps if you describe the changes in the
patch. This allows others to see what you intended so as to compare it to patch. This allows others to see what you intended so as to compare it to
what was actually done, and allows better feedback what was actually done, and allows better feedback. If you use
'git-format-patch' to create your patch, then your commit message will
be shown above the patch by default.
* Credit yourself * Credit yourself
@ -58,7 +66,7 @@ Submitting your patch:
Signed-off-by: Aaron Griffin <aaron@archlinux.org> Signed-off-by: Aaron Griffin <aaron@archlinux.org>
Please use your real name and email address. Feel free to "scramble" the Please use your real name and email address. Feel free to "scramble" the
address if you're afraid of spam. address if you're afraid of spam. 'git commit -s' makes this easy.
After you submit: After you submit:
@ -66,3 +74,7 @@ After you submit:
Any feedback you get, positive or negative, has nothing to do with you. If a Any feedback you get, positive or negative, has nothing to do with you. If a
patch is rejected, try taking the suggestions into account and re-submitting. patch is rejected, try taking the suggestions into account and re-submitting.
We welcome most submissions here, and some may take a bit longer to get
looked over than others. If you think your patch got lost in the shuffle,
send another email to the list in reply to the original asking if anyone has
looked at it yet.