HACKING: Allow the use of 'sizeof' on values

Signed-off-by: Pierre Neidhardt <ambrevar@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Pierre Neidhardt 2015-10-20 15:30:32 +02:00 committed by Allan McRae
parent 2c72c8b822
commit 4b3df10d5d
1 changed files with 3 additions and 11 deletions

14
HACKING
View File

@ -75,15 +75,7 @@ alpm_list_t *alpm_list_add(alpm_list_t *list, void *data)
NOT NOT
return(0); return(0);
6. The sizeof() operator should accept a type, not a value. (TODO: in certain 6. When using strcmp() (or any function that returns 0 on success) in a
cases, it may be better- should this be a set guideline? Read "The Practice
of Programming")
sizeof(alpm_list_t);
NOT
sizeof(*mylist);
7. When using strcmp() (or any function that returns 0 on success) in a
conditional statement, use != 0 or == 0 and not the negation (!) operator. conditional statement, use != 0 or == 0 and not the negation (!) operator.
It reads much cleaner for humans (using a negative to check for success is It reads much cleaner for humans (using a negative to check for success is
confusing) and the compiler will treat it correctly anyway. confusing) and the compiler will treat it correctly anyway.
@ -92,7 +84,7 @@ alpm_list_t *alpm_list_add(alpm_list_t *list, void *data)
NOT NOT
if(!strcmp(a, b)) if(!strcmp(a, b))
8. Use spaces around almost all arithmetic, comparison and assignment 7. Use spaces around almost all arithmetic, comparison and assignment
operators and after all ',;:' separators. operators and after all ',;:' separators.
foobar[2 * size + 1] = function(a, 6); foobar[2 * size + 1] = function(a, 6);
@ -103,7 +95,7 @@ alpm_list_t *alpm_list_add(alpm_list_t *list, void *data)
NOT NOT
for(a=0;a<n&&n>0;a++,n--) {} for(a=0;a<n&&n>0;a++,n--) {}
9. Declare all variables at the start of the block. 8. Declare all variables at the start of the block.
[source,C] [source,C]
------------------------------------------- -------------------------------------------
int SYMEXPORT alpm_db_remove_server(alpm_db_t *db, const char *url) int SYMEXPORT alpm_db_remove_server(alpm_db_t *db, const char *url)