moparisthebest
/
pacman
mirror of https://github.com/moparisthebest/pacman
1
0
Fork 0
Code Issues Releases Wiki Activity

pactest: treat unknown rules as failures 

Tests should only be skipped when they aren't relevant, not when the
test itself is bad.

Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Andrew Gregory 2013-08-01 22:51:24 -04:00 committed by Allan McRae
parent d3726bbd26
commit 429b956fb2
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/pacman/pmenv.py
View File

@ -110,9 +110,8 @@ def _printtest(t):
else: else:
result = "[FAIL]" result = "[FAIL]"
print result, print result,
print "%s Rules: OK = %2u FAIL = %2u SKIP = %2u" \ print "%s Rules: OK = %2u FAIL = %2u" \
% (t.testname.ljust(34), success, fail, \ % (t.testname.ljust(34), success, fail)
rules - (success + fail))
if fail != 0: if fail != 0:
# print test description if test failed # print test description if test failed
print " ", t.description print " ", t.description

4
test/pacman/pmtest.py
View File

@ -266,11 +266,9 @@ def check(self):
if success == 1: if success == 1:
msg = " OK " msg = " OK "
self.result["success"] += 1 self.result["success"] += 1
elif success == 0: else:
msg = "FAIL" msg = "FAIL"
self.result["fail"] += 1 self.result["fail"] += 1
else:
msg = "SKIP"
print "\t[%s] %s" % (msg, i) print "\t[%s] %s" % (msg, i)
# vim: set ts=4 sw=4 et: # vim: set ts=4 sw=4 et: