mirror of
https://github.com/moparisthebest/pacman
synced 2024-12-22 15:58:50 -05:00
makepkg: improve parsing for sanity checks
Trailing backslahses can lead to additional spaces at the front of extracted entries. See FS#23524. Strip these while parsing the PKGBUILD entries. Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
This commit is contained in:
parent
fc334b4e77
commit
37df0d4f4f
@ -1256,7 +1256,7 @@ check_sanity() {
|
||||
|
||||
local provides_list=()
|
||||
eval $(awk '/^[[:space:]]*provides=/,/\)/' "$BUILDFILE" | \
|
||||
sed -e "s/provides=/provides_list+=/" -e "s/#.*//")
|
||||
sed -e "s/provides=/provides_list+=/" -e "s/#.*//" -e 's/\\$//')
|
||||
for i in ${provides_list[@]}; do
|
||||
if [[ $i != ${i//</} || $i != ${i//>/} ]]; then
|
||||
error "$(gettext "Provides array cannot contain comparison (< or >) operators.")"
|
||||
@ -1266,7 +1266,7 @@ check_sanity() {
|
||||
|
||||
local backup_list=()
|
||||
eval $(awk '/^[[:space:]]*backup=/,/\)/' "$BUILDFILE" | \
|
||||
sed -e "s/backup=/backup_list+=/" -e "s/#.*//")
|
||||
sed -e "s/backup=/backup_list+=/" -e "s/#.*//" -e 's/\\$//')
|
||||
for i in "${backup_list[@]}"; do
|
||||
if [[ ${i:0:1} = "/" ]]; then
|
||||
error "$(gettext "Backup entry should not contain leading slash : %s")" "$i"
|
||||
@ -1276,7 +1276,7 @@ check_sanity() {
|
||||
|
||||
local optdepends_list=()
|
||||
eval $(awk '/^[[:space:]]*optdepends=\(/,/\)[[:space:]]*(|#.*)$/' "$BUILDFILE" | \
|
||||
sed -e "s/optdepends=/optdepends_list+=/" -e "s/#.*//")
|
||||
sed -e "s/optdepends=/optdepends_list+=/" -e "s/#.*//" -e 's/\\$//')
|
||||
for i in "${optdepends_list[@]}"; do
|
||||
local pkg=${i%%:*}
|
||||
if [[ ! $pkg =~ ^[[:alnum:]\>\<\=\.\+\_\-]+$ ]]; then
|
||||
@ -1301,7 +1301,7 @@ check_sanity() {
|
||||
local valid_options=1
|
||||
local known kopt options_list
|
||||
eval $(awk '/^[[:space:]]*options=/,/\)/' "$BUILDFILE" | \
|
||||
sed -e "s/options=/options_list+=/" -e "s/#.*//")
|
||||
sed -e "s/options=/options_list+=/" -e "s/#.*//" -e 's/\\$//')
|
||||
for i in ${options_list[@]}; do
|
||||
known=0
|
||||
# check if option matches a known option or its inverse
|
||||
|
Loading…
Reference in New Issue
Block a user