From 11ba7a0e8a253bff53778688ee174f42c1513738 Mon Sep 17 00:00:00 2001 From: Dan McGee Date: Wed, 8 Jun 2011 02:47:26 -0500 Subject: [PATCH] Fix graph free valgrind warnings Due to the way we set up the graph structure, we don't always have good parent information. The changes made in dd8cf0c12dd5e assumed this, so back them out and just live with the dead pointers being there in the memory while we are cleaning up after ourselves. Signed-off-by: Dan McGee --- lib/libalpm/graph.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/lib/libalpm/graph.c b/lib/libalpm/graph.c index 2e2ba236..15ff9354 100644 --- a/lib/libalpm/graph.c +++ b/lib/libalpm/graph.c @@ -34,18 +34,7 @@ pmgraph_t *_alpm_graph_new(void) void _alpm_graph_free(void *data) { pmgraph_t *graph = data; - /* make my children forget about me */ - for(alpm_list_t *i = graph->children; i; i = i->next) { - pmgraph_t *child = i->data; - child->parent = NULL; - } alpm_list_free(graph->children); - /* and make my parents forget about me too */ - if(graph->parent) { - alpm_list_t *me = alpm_list_find_ptr(graph->parent->children, &data); - graph->parent->children = alpm_list_remove_item(graph->parent->children, - me); - } free(graph); }