moparisthebest/open-keychain
1
0
Fork 0
mirror of https://github.com/moparisthebest/open-keychain synced 2024-11-23 17:22:16 -05:00
Code Issues Releases Wiki Activity
1,560 Commits 12 Branches 24 Tags 116 MiB
Java 94.2%
Public Key 3.7%
eC 0.8%
Gradle 0.5%
Python 0.4%
Other 0.4%
a7eff41ced
Go to file
Vincent Breitmoser a7eff41ced Break a lot of stuff. Also, database redesign. 
Change entire database design. This introduces a lot of changes,
notably all URIs and almost all projections. Some features (like key
deletion) have been simply commented out for now since they need
serious reconsideration. There are a couple of new TODOs marking places
where more work is needed.

The migration path works fine from what I tested. The old database is
not deleted for now, ie, it is reimported at every start of the
application making all intermediate changes transient.

Tested and working (for me):
 - All activities in the main drawer
 - Multiselect and Search
 - ViewKeyActivity, with and without secret key available
 - CertifyKeyActivity
 - SelectSecretKeyActivity (from CertifyKeyActivity)
 - SelectPublicKeyActivity (from encrypt activity)

What doesn't work:
 - Actually certifying keys (pending a TODO in ProviderHelper)
 - Importing keys doesn't preserve secret keys
 - "Encrypt to this contact" doesn't pass key
 - Editing keys. All controls are disabled, I'm not sure why... (is this
   even my fault?)
 - Deleting keys

What I didn't test:
 - Key export
 - API stuff
 - Creating keys (since editing doesn't even work)
2014-04-03 01:34:35 +02:00
.tx Fix transifex config and pull translations 2014-01-29 04:06:53 +01:00
gradle/wrapper back to Gradle 1.10, Using Gradle 1.11 requires Android Studio 0.5.0 which is not released yet 2014-03-06 22:24:52 +01:00
libraries Split api libs into OpenKeychain specific and OpenPGP Provider lib 2014-03-07 23:05:03 +01:00
OpenPGP-Keychain Break a lot of stuff. Also, database redesign. 2014-04-03 01:34:35 +02:00
OpenPGP-Keychain-API Increase API_VERSION to 3 2014-03-30 19:18:18 +02:00
Resources put original license of launcher icon into repo 2014-03-23 19:42:17 +01:00
tools Optimize imports in all files, remove useless whitespace in some and fix indentation 2014-03-13 20:14:04 +02:00
.gitignore Lint changes after testing 2014-03-10 14:59:15 -04:00
.travis.yml Reduce library installation overhead 2014-03-12 20:33:08 +01:00
build.gradle back to Gradle 1.10, Using Gradle 1.11 requires Android Studio 0.5.0 which is not released yet 2014-03-06 22:24:52 +01:00
CHANGELOG Changelog for 2.4 2014-03-26 22:48:23 +01:00
DESCRIPTION keyserver instead of key server 2014-02-05 13:09:59 +01:00
gradlew fix gradle build 2013-12-30 23:25:38 +01:00
gradlew.bat fix gradle build 2013-12-30 23:25:38 +01:00
LICENSE LICENSE must be GPLv3 2014-01-28 10:28:42 +01:00
README.md Coding style 2014-03-26 13:42:16 +01:00
settings.gradle Split api libs into OpenKeychain specific and OpenPGP Provider lib 2014-03-07 23:05:03 +01:00

README.md

OpenKeychain (for Android)

OpenKeychain is an OpenPGP implementation for Android.
For a more detailed description and installation instructions go to http://www.openkeychain.org .

Travis CI Build Status

Build Status

How to help the project?

Translate the application

Translations are managed at Transifex, please contribute there at https://www.transifex.com/projects/p/openpgp-keychain/

Contribute Code

  1. Join the development mailinglist at http://groups.google.com/d/forum/openpgp-keychain-dev
  2. Lookout for interesting issues on our issue page at Github: https://github.com/openpgp-keychain/openpgp-keychain/issues
  3. Tell us about your plans on the mailinglist
  4. Read this README, especially the notes about coding style
  5. Fork OpenKeychain and contribute code (the best part ;) )
  6. Open a pull request on Github. I will help with occuring problems and merge your changes back into the main project.

I am happy about every code contribution and appreciate your effort to help us developing OpenKeychain!

Development

Development mailinglist at http://groups.google.com/d/forum/openpgp-keychain-dev

Build with Gradle

  1. Have Android SDK "tools", "platform-tools", and "build-tools" directories in your PATH (http://developer.android.com/sdk/index.html)
  2. Open the Android SDK Manager (shell command: android).
    Expand the Tools directory and select "Android SDK Build-tools (Version 19.0.3)".
    Expand the Extras directory and install "Android Support Repository"
    Select everything for the newest SDK (API-Level 19)
  3. Export ANDROID_HOME pointing to your Android SDK
  4. Execute ./gradlew build
  5. You can install the app with adb install -r OpenPGP-Keychain/build/apk/OpenPGP-Keychain-debug-unaligned.apk

Build API Demo with Gradle

  1. Follow 1-3 from above
  2. Change to API Demo directory cd OpenPGP-Keychain-API
  3. Execute ./gradlew build

Development with Android Studio

I am using the newest Android Studio for development. Development with Eclipse is currently not possible because I am using the new project structure.

  1. Clone the project from github
  2. From Android Studio: File -> Import Project -> ...
  • Select the cloned top folder if you want to develop on the main project
  • Select the "OpenPGP-Keychain-API" folder if you want to develop on the API example
  1. Import project from external model -> choose Gradle

OpenKeychain's API

OpenKeychain provides two APIs, namely the Intent API and the Remote OpenPGP API. The Intent API can be used without permissions to start OpenKeychain's activities for cryptographic operations, import of keys, etc. However, it always requires user input, so that no malicious application can use this API without user intervention.
The Remote OpenPGP API is more sophisticated and allows to to operations without user interaction in the background. When utilizing this API, OpenKeychain asks the user on first use to grant access for the calling client application.

More technical information and examples about these APIs can be found in the project's wiki:

Libraries

ZXing Barcode Scanner Android Integration

Classes can be found under "libraries/zxing-android-integration/".

  1. Checkout their SVN (see http://code.google.com/p/zxing/source/checkout)
  2. Copy all classes from their android-integration folder to our library folder

ZXing

Classes can be found under "libraries/zxing/". ZXing classes were extracted from the ZXing library (https://github.com/zxing/zxing). Only classes related to QR Code generation are utilized.

Bouncy Castle

Spongy Castle

Spongy Castle is the stock Bouncy Castle libraries with a couple of small changes to make it work on Android. OpenKeychain uses a forked version with some small changes. These changes will been sent to Bouncy Castle, and Spongy Castle will be used again when they have filtered down.

see

Bouncy Castle resources

Documentation

Notes

Gradle Build System

We try to make our builds as reproducible/deterministic as possible.
When changing build files or dependencies, respect the following requirements:

  • No precompiled libraries. All libraries should be provided as sourcecode in "libraries" folder (you never know what pre-compiled jar files really contain! The library files are currently directly commited, because git submodules/git subtree are too much of a hassle for new contributors. This could change in the future!)
  • No dependencies from Maven (also a soft requirement for inclusion in F-Droid)
  • Always use a fixed Android Gradle plugin version not a dynamic one, e.g. 0.7.3 instead of 0.7.+ (allows offline builds without lookups for new versions, also some minor Android plugin versions had serious issues, i.e. 0.7.2 and 0.8.1)
  • Commit the corresponding Gradle wrapper to the repository (allows easy building for new contributors without the need to install the required Gradle version using a package manager)
  • In order to update the build system to a newer gradle version you need to:
    • Update every build.gradle file with the new gradle version and/or gradle plugin version
      • build.gradle
      • OpenPGP-Keychain/build.gradle
      • OpenPGP-Keychain-API/build.gradle
      • OpenPGP-Keychain-API/example-app/build.gradle
      • OpenPGP-Keychain-API/libraries/keychain-api-library/build.gradle
    • run ./gradlew wrapper twice to update gradle and download the new jar file
    • commit the new jar and property files

Translations

Translations are hosted on Transifex, which is configured by ".tx/config".

  1. To pull newest translations install transifex client (e.g. apt-get install transifex-client)
  2. Config Transifex client with "~/.transifexrc"
  3. Go into root folder of git repo
  4. execute tx pull (tx pull -a to get all languages)

see http://help.transifex.net/features/client/index.html#user-client

Coding Style

Code

  • Indentation: 4 spaces, no tabs
  • Maximum line width for code and comments: 100
  • Opening braces don't go on their own line
  • Field names: Non-public, non-static fields start with m.
  • Acronyms are words: Treat acronyms as words in names, yielding !XmlHttpRequest, getUrl(), etc.
  • Fully Qualify Imports: Do not use wildcard-imports such as import foo.*;

The full coding style can be found at http://source.android.com/source/code-style.html

Automated syntax check with CheckStyle

####Linux

  1. Paste the tools/checkstyle.xml file to ~/.AndroidStudioPreview/config/codestyles/
  2. Go to Settings > Code Style > Java, select OpenPgpChecker, as well as Code Style > XML and select OpenPgpChecker again.
  3. Start code inspection and see the results by selecting Analyze > Inspect Code from Android-Studio or you can directly run checkstyle via cli with .tools/checkstyle. Make sure it's executable first.

####Mac OSX

  1. Paste the tools/checkstyle.xml file to ~/Library/Preferences/AndroidStudioPreview/codestyles
  2. Go to Preferences > Code Style > Java, select OpenPgpChecker, as well as Code Style > XML and select OpenPgpChecker again.
  3. Start code inspection and see the results by selecting Analyze > Inspect Code from Android-Studio or you can directly run checkstyle via cli with .tools/checkstyle. Make sure it's executable first.

####Windows

  1. Paste the tools/checkstyle.xml file to C:\Users\<UserName>\.AndroidStudioPreview\config\codestyles
  2. Go to File > Settings > Code Style > Java, select OpenPgpChecker, as well as Code Style > XML and select OpenPgpChecker again.
  3. Start code inspection and see the results by selecting Analyze > Inspect Code from Android-Studio.

Licenses

OpenPGP Kechain is licensed under GPLv3+. Some parts (older parts and some libraries are Apache License v2, MIT X11 License)

This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.

This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with this program. If not, see http://www.gnu.org/licenses/.

Libraries

Images