moparisthebest/open-keychain
1
0
Fork 0
mirror of https://github.com/moparisthebest/open-keychain synced 2024-11-23 17:22:16 -05:00
Code Issues Releases Wiki Activity
3,645 Commits 12 Branches 24 Tags 116 MiB
Java 94.2%
Public Key 3.7%
eC 0.8%
Gradle 0.5%
Python 0.4%
Other 0.4%
9514719719
Go to file
Dominik Schürmann 9514719719 Re-add black color
2015-03-02 16:29:40 +01:00
.tx add WoT help file to transifex config 2014-04-15 13:54:07 +02:00
extern Removed unused submodules 2015-03-02 16:24:26 +01:00
gradle/wrapper Update for Android Studio 1.0 RC 2014-12-04 19:05:17 +01:00
Graphics Invoke NFC button 2015-02-25 20:50:34 +01:00
OpenKeychain Re-add black color 2015-03-02 16:29:40 +01:00
OpenKeychain-Test add unit test for "no expiry where revoked user id still has expiry" case 2015-02-26 19:06:23 +01:00
Resources Reorganize folders of graphics sources 2015-01-14 14:52:23 +01:00
tools Minor code cleanup 2014-11-21 12:41:39 +01:00
.gitignore work on test prepare script, make the whole thing optional 2014-07-18 19:05:38 +02:00
.gitmodules Removed unused submodules 2015-03-02 16:24:26 +01:00
.travis.yml Revert "Gradle hack to always use same build tools in subprojects" 2015-03-02 15:49:29 +01:00
build.gradle Use SDK and build tools versions from root project 2015-03-02 16:21:51 +01:00
CHANGELOG Changelog 2014-11-02 17:50:31 +01:00
gradlew fix gradle build 2013-12-30 23:25:38 +01:00
gradlew.bat fix gradle build 2013-12-30 23:25:38 +01:00
LICENSE LICENSE must be GPLv3 2014-01-28 10:28:42 +01:00
README.md Use SDK and build tools versions from root project 2015-03-02 16:21:51 +01:00
settings.gradle Integrate QR Code library instead of requiring the app to be installed, also due to security reasons 2015-01-14 19:14:30 +01:00

README.md

OpenKeychain (for Android)

OpenKeychain is an OpenPGP implementation for Android.
For a more detailed description and installation instructions go to http://www.openkeychain.org .

Travis CI Build Status

Build Status

How to help the project?

Translate the application

Translations are managed at Transifex, please contribute there at https://www.transifex.com/projects/p/open-keychain/

Contribute Code

  1. Join the development mailinglist at http://groups.google.com/d/forum/openpgp-keychain-dev
  2. Lookout for interesting issues on our issue page at Github: https://github.com/open-keychain/open-keychain/issues
  3. Tell us about your plans on the mailinglist
  4. Read this README, especially the notes about coding style
  5. Fork OpenKeychain and contribute code (the best part ;) )
  6. Open a pull request on Github. I will help with occuring problems and merge your changes back into the main project.

I am happy about every code contribution and appreciate your effort to help us developing OpenKeychain!

Development

Development mailinglist at http://groups.google.com/d/forum/openpgp-keychain-dev

Build with Gradle

  1. Get all external submodules with git submodule update --init --recursive
  2. Have Android SDK "tools", "platform-tools", and "build-tools" directories in your PATH (http://developer.android.com/sdk/index.html)
  3. Open the Android SDK Manager (shell command: android).
    Expand the Tools directory and select "Android SDK Build-tools (Version 21.1.1)".
    Expand the Extras directory and install "Android Support Repository"
    Select everything for the newest SDK Platform (API-Level 21)
  4. Export ANDROID_HOME pointing to your Android SDK
  5. Execute ./gradlew build
  6. You can install the app with adb install -r OpenKeychain/build/outputs/apk/OpenKeychain-debug-unaligned.apk

Run Tests

  1. Use OpenJDK instead of Oracle JDK
  2. Execute ./gradlew test

Build API Demo with Gradle

  1. Follow 1-4 from above
  2. The example code is available at https://github.com/open-keychain/api-example
  3. Execute ./gradlew build

Development with Android Studio

We are using the newest Android Studio for development. Development with Eclipse is currently not possible because we are using the new project structure.

  1. Clone the project from Github
  2. From Android Studio: File -> Import Project -> Select the cloned top folder

OpenKeychain's API

OpenKeychain provides two APIs, namely the Intent API and the Remote OpenPGP API. The Intent API can be used without permissions to start OpenKeychain's activities for cryptographic operations, import of keys, etc. However, it always requires user input, so that no malicious application can use this API without user intervention.
The Remote OpenPGP API is more sophisticated and allows to to operations without user interaction in the background. When utilizing this API, OpenKeychain asks the user on first use to grant access for the calling client application.

More technical information and examples about these APIs can be found in the project's wiki:

Libraries

ZXing Barcode Scanner Android Integration

Classes can be found under https://github.com/open-keychain/zxing-android-integration.

  1. Copy all classes from https://github.com/zxing/zxing/tree/master/android-integration folder to our git repository.

ZXing QR-Code Classes

Classes can be found under https://github.com/open-keychain/zxing-qr-code. All QR Code related classes were extracted from the ZXing library (https://github.com/zxing/zxing).

Bouncy Castle

Spongy Castle

Spongy Castle is the stock Bouncy Castle libraries with a couple of small changes to make it work on Android. OpenKeychain uses a forked version with some small changes. These changes will been sent to Bouncy Castle, and Spongy Castle will be used again when they have filtered down.

see

Bouncy Castle resources

Documentation

Notes

Build System

We try to make our builds as reproducible/deterministic as possible.

Update Gradle version

  • Always use a fixed Android Gradle plugin version not a dynamic one, e.g. 0.7.3 instead of 0.7.+ (allows offline builds without lookups for new versions, also some minor Android plugin versions had serious issues, i.e. 0.7.2 and 0.8.1)
  • Update every build.gradle file with the new gradle version and/or gradle plugin version
    • build.gradle
    • OpenKeychain/build.gradle
  • run ./gradlew wrapper twice to update gradle and download the new gradle jar file
  • commit the corresponding Gradle wrapper to the repository (allows easy building for new contributors without the need to install the required Gradle version using a package manager)

Update SDK and Build Tools

  • Open build.gradle and change:
ext {
    compileSdkVersion = 21
    buildToolsVersion = '21.1.2'
}
  • Change SDK and Build Tools in git submodules "openkeychain-api-lib" and "openpgp-api-lib" manually. They should also build on their own without the ext variables.

Add new library

  • You can add the library as a Maven dependency or as a git submodule (if patches are required) in the "extern" folder.
  • If added as a Maven dependency, pin the library using Gradle Witness
  • If added as a git submodule, change the compileSdkVersion and buildToolsVersion in build.gradle to use the variables from the root project:
android {
    compileSdkVersion rootProject.ext.compileSdkVersion
    buildToolsVersion rootProject.ext.buildToolsVersion
}

Slow Gradle?

Error:Configuration with name 'default' not found.

Gradle project dependencies are missing. Do a git submodule init && git submodule update

Translations

Translations are hosted on Transifex, which is configured by ".tx/config".

  1. To pull newest translations install transifex client (e.g. apt-get install transifex-client)
  2. Config Transifex client with "~/.transifexrc"
  3. Go into root folder of git repo
  4. execute tx pull (tx pull -a to get all languages)

see http://help.transifex.net/features/client/index.html#user-client

Coding Style

Code

  • Indentation: 4 spaces, no tabs
  • Maximum line width for code and comments: 100
  • Opening braces don't go on their own line
  • Field names: Non-public, non-static fields start with m.
  • Acronyms are words: Treat acronyms as words in names, yielding !XmlHttpRequest, getUrl(), etc.
  • Fully Qualify Imports: Do not use wildcard-imports such as import foo.*;

The full coding style can be found at http://source.android.com/source/code-style.html

Automated syntax check with CheckStyle

####Linux

  1. Paste the tools/checkstyle.xml file to ~/.AndroidStudioPreview/config/codestyles/
  2. Go to Settings > Code Style > Java, select OpenPgpChecker, as well as Code Style > XML and select OpenPgpChecker again.
  3. Start code inspection and see the results by selecting Analyze > Inspect Code from Android-Studio or you can directly run checkstyle via cli with .tools/checkstyle. Make sure it's executable first.

####Mac OSX

  1. Paste the tools/checkstyle.xml file to ~/Library/Preferences/AndroidStudioPreview/codestyles
  2. Go to Preferences > Code Style > Java, select OpenPgpChecker, as well as Code Style > XML and select OpenPgpChecker again.
  3. Start code inspection and see the results by selecting Analyze > Inspect Code from Android-Studio or you can directly run checkstyle via cli with .tools/checkstyle. Make sure it's executable first.

####Windows

  1. Paste the tools/checkstyle.xml file to C:\Users\<UserName>\.AndroidStudioPreview\config\codestyles
  2. Go to File > Settings > Code Style > Java, select OpenPgpChecker, as well as Code Style > XML and select OpenPgpChecker again.
  3. Start code inspection and see the results by selecting Analyze > Inspect Code from Android-Studio.

Licenses

OpenKechain is licensed under GPLv3+. The full license text can be found in the LICENSE file. Some parts and some libraries are Apache License v2, MIT X11 License (see below).

This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.

This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with this program. If not, see http://www.gnu.org/licenses/.

Libraries

Images