Remove support for v3 sig generation

2024-12-25 00:18:51 -05:00 · 2014-08-14 15:24:37 +02:00 · 2014-08-14 15:24:37 +02:00 · e72e47d92e
commit e72e47d92e
parent 37edd0f390
8 changed files with 13 additions and 122 deletions
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/Constants.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/Constants.java
@ -64,7 +64,6 @@ public final class Constants {
        public static final String DEFAULT_FILE_COMPRESSION = "defaultFileCompression";
        public static final String PASSPHRASE_CACHE_TTL = "passphraseCacheTtl";
        public static final String LANGUAGE = "language";
-        public static final String FORCE_V3_SIGNATURES = "forceV3Signatures";
        public static final String KEY_SERVERS = "keyServers";
        public static final String KEY_SERVERS_DEFAULT_VERSION = "keyServersDefaultVersion";
        public static final String WRITE_VERSION_HEADER = "writeVersionHeader";
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/helper/Preferences.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/helper/Preferences.java
@ -130,16 +130,6 @@ public class Preferences {
        editor.commit();
    }

-    public boolean getForceV3Signatures() {
-        return mSharedPreferences.getBoolean(Constants.Pref.FORCE_V3_SIGNATURES, false);
-    }
-
-    public void setForceV3Signatures(boolean value) {
-        SharedPreferences.Editor editor = mSharedPreferences.edit();
-        editor.putBoolean(Constants.Pref.FORCE_V3_SIGNATURES, value);
-        editor.commit();
-    }
-
    public boolean isFirstTime() {
        return mSharedPreferences.getBoolean(Constants.Pref.FIRST_TIME, true);
    }
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/PgpSignEncrypt.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/PgpSignEncrypt.java
@ -27,7 +27,6 @@ import org.spongycastle.openpgp.PGPException;
 import org.spongycastle.openpgp.PGPLiteralData;
 import org.spongycastle.openpgp.PGPLiteralDataGenerator;
 import org.spongycastle.openpgp.PGPSignatureGenerator;
-import org.spongycastle.openpgp.PGPV3SignatureGenerator;
 import org.spongycastle.openpgp.operator.jcajce.JcePBEKeyEncryptionMethodGenerator;
 import org.spongycastle.openpgp.operator.jcajce.JcePGPDataEncryptorBuilder;
 import org.sufficientlysecure.keychain.Constants;
@ -68,7 +67,6 @@ public class PgpSignEncrypt {
    private int mSymmetricEncryptionAlgorithm;
    private long mSignatureMasterKeyId;
    private int mSignatureHashAlgorithm;
-    private boolean mSignatureForceV3;
    private String mSignaturePassphrase;
    private boolean mEncryptToSigner;
    private boolean mCleartextInput;
@ -99,7 +97,6 @@ public class PgpSignEncrypt {
        this.mSymmetricEncryptionAlgorithm = builder.mSymmetricEncryptionAlgorithm;
        this.mSignatureMasterKeyId = builder.mSignatureMasterKeyId;
        this.mSignatureHashAlgorithm = builder.mSignatureHashAlgorithm;
-        this.mSignatureForceV3 = builder.mSignatureForceV3;
        this.mSignaturePassphrase = builder.mSignaturePassphrase;
        this.mEncryptToSigner = builder.mEncryptToSigner;
        this.mCleartextInput = builder.mCleartextInput;
@ -122,7 +119,6 @@ public class PgpSignEncrypt {
        private int mSymmetricEncryptionAlgorithm = 0;
        private long mSignatureMasterKeyId = Constants.key.none;
        private int mSignatureHashAlgorithm = 0;
-        private boolean mSignatureForceV3 = false;
        private String mSignaturePassphrase = null;
        private boolean mEncryptToSigner = false;
        private boolean mCleartextInput = false;
@ -179,11 +175,6 @@ public class PgpSignEncrypt {
            return this;
        }

-        public Builder setSignatureForceV3(boolean signatureForceV3) {
-            mSignatureForceV3 = signatureForceV3;
-            return this;
-        }
-
        public Builder setSignaturePassphrase(String signaturePassphrase) {
            mSignaturePassphrase = signaturePassphrase;
            return this;
@ -349,19 +340,13 @@ public class PgpSignEncrypt {

        /* Initialize signature generator object for later usage */
        PGPSignatureGenerator signatureGenerator = null;
-        PGPV3SignatureGenerator signatureV3Generator = null;
        if (enableSignature) {
            updateProgress(R.string.progress_preparing_signature, 4, 100);

            try {
                boolean cleartext = mCleartextInput && mEnableAsciiArmorOutput && !enableEncryption;
-                if (mSignatureForceV3) {
-                    signatureV3Generator = signingKey.getV3SignatureGenerator(
-                            mSignatureHashAlgorithm, cleartext);
-                } else {
-                    signatureGenerator = signingKey.getSignatureGenerator(
-                            mSignatureHashAlgorithm, cleartext);
-                }
+                signatureGenerator = signingKey.getSignatureGenerator(
+                        mSignatureHashAlgorithm, cleartext);
            } catch (PgpGeneralException e) {
                // TODO throw correct type of exception (which shouldn't be PGPException)
                throw new KeyExtractionException();
@ -388,11 +373,7 @@ public class PgpSignEncrypt {
            }

            if (enableSignature) {
-                if (mSignatureForceV3) {
-                    signatureV3Generator.generateOnePassVersion(false).encode(bcpgOut);
-                } else {
-                    signatureGenerator.generateOnePassVersion(false).encode(bcpgOut);
-                }
+                signatureGenerator.generateOnePassVersion(false).encode(bcpgOut);
            }

            PGPLiteralDataGenerator literalGen = new PGPLiteralDataGenerator();
@ -408,11 +389,7 @@ public class PgpSignEncrypt {

                // update signature buffer if signature is requested
                if (enableSignature) {
-                    if (mSignatureForceV3) {
-                        signatureV3Generator.update(buffer, 0, length);
-                    } else {
-                        signatureGenerator.update(buffer, 0, length);
-                    }
+                    signatureGenerator.update(buffer, 0, length);
                }

                alreadyWritten += length;
@ -435,11 +412,7 @@ public class PgpSignEncrypt {
            final BufferedReader reader = new BufferedReader(new InputStreamReader(in));

            // update signature buffer with first line
-            if (mSignatureForceV3) {
-                processLineV3(reader.readLine(), armorOut, signatureV3Generator);
-            } else {
-                processLine(reader.readLine(), armorOut, signatureGenerator);
-            }
+            processLine(reader.readLine(), armorOut, signatureGenerator);

            // TODO: progress: fake annealing?
            while (true) {
@ -454,13 +427,8 @@ public class PgpSignEncrypt {
                armorOut.write(NEW_LINE);

                // update signature buffer with input line
-                if (mSignatureForceV3) {
-                    signatureV3Generator.update(NEW_LINE);
-                    processLineV3(line, armorOut, signatureV3Generator);
-                } else {
-                    signatureGenerator.update(NEW_LINE);
-                    processLine(line, armorOut, signatureGenerator);
-                }
+                signatureGenerator.update(NEW_LINE);
+                processLine(line, armorOut, signatureGenerator);
            }

            armorOut.endClearText();
@ -480,11 +448,7 @@ public class PgpSignEncrypt {
                bcpgOut = new BCPGOutputStream(out);
            }

-            if (mSignatureForceV3) {
-                signatureV3Generator.generateOnePassVersion(false).encode(bcpgOut);
-            } else {
-                signatureGenerator.generateOnePassVersion(false).encode(bcpgOut);
-            }
+            signatureGenerator.generateOnePassVersion(false).encode(bcpgOut);

            PGPLiteralDataGenerator literalGen = new PGPLiteralDataGenerator();
            pOut = literalGen.open(bcpgOut, PGPLiteralData.BINARY, mOriginalFilename, new Date(),
@ -496,11 +460,7 @@ public class PgpSignEncrypt {
            while ((length = in.read(buffer)) > 0) {
                pOut.write(buffer, 0, length);

-                if (mSignatureForceV3) {
-                    signatureV3Generator.update(buffer, 0, length);
-                } else {
-                    signatureGenerator.update(buffer, 0, length);
-                }
+                signatureGenerator.update(buffer, 0, length);

                alreadyWritten += length;
                if (mData.getSize() > 0) {
@ -517,11 +477,7 @@ public class PgpSignEncrypt {

        if (enableSignature) {
            updateProgress(R.string.progress_generating_signature, 95, 100);
-            if (mSignatureForceV3) {
-                signatureV3Generator.generate().encode(pOut);
-            } else {
-                signatureGenerator.generate().encode(pOut);
-            }
+            signatureGenerator.generate().encode(pOut);
        }

        // closing outputs
@ -570,30 +526,4 @@ public class PgpSignEncrypt {
        pSignatureGenerator.update(data);
    }

-    private static void processLineV3(final String pLine, final ArmoredOutputStream pArmoredOutput,
-                                      final PGPV3SignatureGenerator pSignatureGenerator)
-            throws IOException, SignatureException {
-
-        if (pLine == null) {
-            return;
-        }
-
-        final char[] chars = pLine.toCharArray();
-        int len = chars.length;
-
-        while (len > 0) {
-            if (!Character.isWhitespace(chars[len - 1])) {
-                break;
-            }
-            len--;
-        }
-
-        final byte[] data = pLine.substring(0, len).getBytes("UTF-8");
-
-        if (pArmoredOutput != null) {
-            pArmoredOutput.write(data);
-        }
-        pSignatureGenerator.update(data);
-    }
-
 }
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/OpenPgpService.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/OpenPgpService.java
@ -191,7 +191,6 @@ public class OpenPgpService extends RemoteService {
                builder.setEnableAsciiArmorOutput(asciiArmor)
                        .setVersionHeader(PgpHelper.getVersionForHeader(this))
                        .setSignatureHashAlgorithm(accSettings.getHashAlgorithm())
-                        .setSignatureForceV3(false)
                        .setSignatureMasterKeyId(accSettings.getKeyId())
                        .setSignaturePassphrase(passphrase);

@ -299,7 +298,6 @@ public class OpenPgpService extends RemoteService {

                    // sign and encrypt
                    builder.setSignatureHashAlgorithm(accSettings.getHashAlgorithm())
-                            .setSignatureForceV3(false)
                            .setSignatureMasterKeyId(accSettings.getKeyId())
                            .setSignaturePassphrase(passphrase);
                } else {
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/KeychainIntentService.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/KeychainIntentService.java
@ -257,7 +257,6 @@ public class KeychainIntentService extends IntentService
                            .setCompressionId(compressionId)
                            .setSymmetricEncryptionAlgorithm(
                                    Preferences.getPreferences(this).getDefaultEncryptionAlgorithm())
-                            .setSignatureForceV3(Preferences.getPreferences(this).getForceV3Signatures())
                            .setEncryptionMasterKeyIds(encryptionKeyIds)
                            .setSymmetricPassphrase(symmetricPassphrase)
                            .setSignatureMasterKeyId(signatureKeyId)
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/PreferencesActivity.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/PreferencesActivity.java
@ -119,9 +119,6 @@ public class PreferencesActivity extends PreferenceActivity {
            initializeAsciiArmor(
                    (CheckBoxPreference) findPreference(Constants.Pref.DEFAULT_ASCII_ARMOR));

-            initializeForceV3Signatures(
-                    (CheckBoxPreference) findPreference(Constants.Pref.FORCE_V3_SIGNATURES));
-
            initializeWriteVersionHeader(
                    (CheckBoxPreference) findPreference(Constants.Pref.WRITE_VERSION_HEADER));

@ -266,9 +263,6 @@ public class PreferencesActivity extends PreferenceActivity {
            initializeAsciiArmor(
                    (CheckBoxPreference) findPreference(Constants.Pref.DEFAULT_ASCII_ARMOR));

-            initializeForceV3Signatures(
-                    (CheckBoxPreference) findPreference(Constants.Pref.FORCE_V3_SIGNATURES));
-
            initializeWriteVersionHeader(
                    (CheckBoxPreference) findPreference(Constants.Pref.WRITE_VERSION_HEADER));
        }
@ -392,18 +386,6 @@ public class PreferencesActivity extends PreferenceActivity {
        });
    }

-    private static void initializeForceV3Signatures(final CheckBoxPreference mForceV3Signatures) {
-        mForceV3Signatures.setChecked(sPreferences.getForceV3Signatures());
-        mForceV3Signatures
-                .setOnPreferenceChangeListener(new Preference.OnPreferenceChangeListener() {
-                    public boolean onPreferenceChange(Preference preference, Object newValue) {
-                        mForceV3Signatures.setChecked((Boolean) newValue);
-                        sPreferences.setForceV3Signatures((Boolean) newValue);
-                        return false;
-                    }
-                });
-    }
-
    private static void initializeWriteVersionHeader(final CheckBoxPreference mWriteVersionHeader) {
        mWriteVersionHeader.setChecked(sPreferences.getWriteVersionHeader());
        mWriteVersionHeader.setOnPreferenceChangeListener(new Preference.OnPreferenceChangeListener() {
--- a/OpenKeychain/src/main/res/values/strings.xml
+++ b/OpenKeychain/src/main/res/values/strings.xml
@ -103,7 +103,6 @@
    <string name="label_passphrase_cache_ttl">Passphrase Cache</string>
    <string name="label_message_compression">Message Compression</string>
    <string name="label_file_compression">File Compression</string>
-    <string name="label_force_v3_signature">Force old OpenPGPv3 Signatures</string>
    <string name="label_keyservers">Keyservers</string>
    <string name="label_key_id">Key ID</string>
    <string name="label_creation">Creation</string>
--- a/OpenKeychain/src/main/res/xml/adv_preferences.xml
+++ b/OpenKeychain/src/main/res/xml/adv_preferences.xml
@ -16,7 +16,7 @@
 -->

 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
-    <PreferenceCategory android:title="@string/section_defaults" >
+    <PreferenceCategory android:title="@string/section_defaults">
        <org.sufficientlysecure.keychain.ui.widget.IntegerListPreference
            android:key="defaultEncryptionAlgorithm"
            android:persistent="false"
@ -33,22 +33,16 @@
            android:key="defaultFileCompression"
            android:persistent="false"
            android:title="@string/label_file_compression" />
-
        <CheckBoxPreference
            android:key="defaultAsciiArmor"
            android:persistent="false"
            android:title="@string/label_ascii_armor" />
-
+    </PreferenceCategory>
+    <PreferenceCategory android:title="@string/section_advanced">
        <CheckBoxPreference
            android:key="writeVersionHeader"
            android:persistent="false"
            android:title="@string/label_write_version_header"
            android:summary="@string/label_write_version_header_summary" />
    </PreferenceCategory>
-    <PreferenceCategory android:title="@string/section_advanced" >
-        <CheckBoxPreference
-            android:key="forceV3Signatures"
-            android:persistent="false"
-            android:title="@string/label_force_v3_signature"/>
-    </PreferenceCategory>
 </PreferenceScreen>