moparisthebest/open-keychain
1
0
Fork 0
mirror of https://github.com/moparisthebest/open-keychain synced 2024-11-15 13:25:06 -05:00
Code Issues Releases Wiki Activity

revamp fingerprint and keyid methods in NfcActivity

Browse Source
This commit is contained in:
Vincent Breitmoser 2014-09-30 01:46:16 +02:00
parent de5dd482e1
commit dabdda36cf
1 changed files with 47 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/NfcActivity.java
View File

@ -23,9 +23,12 @@ import org.spongycastle.bcpg.HashAlgorithmTags;
import org.spongycastle.util.encoders.Hex; import org.spongycastle.util.encoders.Hex;
import org.sufficientlysecure.keychain.Constants; import org.sufficientlysecure.keychain.Constants;
import org.sufficientlysecure.keychain.R; import org.sufficientlysecure.keychain.R;
import org.sufficientlysecure.keychain.ui.util.KeyFormattingUtils;
import org.sufficientlysecure.keychain.util.Iso7816TLV;
import org.sufficientlysecure.keychain.util.Log; import org.sufficientlysecure.keychain.util.Log;
import java.io.IOException; import java.io.IOException;
import java.nio.ByteBuffer;
import java.util.Locale; import java.util.Locale;
/** /**
@ -257,33 +260,59 @@ public class NfcActivity extends ActionBarActivity {
return getName(card(info)) + " <" + (new String(Hex.decode(getDataField(card(data))))) + ">"; return getName(card(info)) + " <" + (new String(Hex.decode(getDataField(card(data))))) + ">";
} }
/** /** Return the key id from application specific data stored on tag, or null
* Gets the long key ID * if it doesn't exist.
* *
* @return the long key id (last 16 bytes of the fingerprint) * @param idx Index of the key to return the fingerprint from.
* @throws java.io.IOException * @return The long key id of the requested key, or null if not found.
*/ */
public long getKeyId() throws IOException { public static Long nfcGetKeyId(IsoDep isoDep, int idx) throws IOException {
String keyId = getFingerprint().substring(24); byte[] fp = nfcGetFingerprint(isoDep, idx);
Log.d(Constants.TAG, "keyId: " + keyId); if (fp == null) {
return Long.parseLong(keyId, 16); return null;
}
ByteBuffer buf = ByteBuffer.wrap(fp);
// skip first 12 bytes of the fingerprint
buf.position(12);
// the last eight bytes are the key id (big endian, which is default order in ByteBuffer)
return buf.getLong();
} }
/** /** Return fingerprints of all keys from application specific data stored
* Gets the fingerprint of the signature key * on tag, or null if data not available.
* *
* @return the fingerprint * @return The fingerprints of all subkeys in a contiguous byte array.
* @throws java.io.IOException
*/ */
public String getFingerprint() throws IOException { public static byte[] nfcGetFingerprints(IsoDep isoDep) throws IOException {
String data = "00CA006E00"; String data = "00CA006E00";
String fingerprint = card(data); byte[] buf = isoDep.transceive(Hex.decode(data));
fingerprint = fingerprint.toLowerCase(Locale.ENGLISH); // better enforce lower case
fingerprint = fingerprint.substring(fingerprint.indexOf("c5") + 4, fingerprint.indexOf("c5") + 44);
Log.d(Constants.TAG, "fingerprint: " + fingerprint); Iso7816TLV tlv = Iso7816TLV.readSingle(buf, true);
Log.d(Constants.TAG, "nfc tlv data:\n" + tlv.prettyPrint());
return fingerprint; Iso7816TLV fptlv = Iso7816TLV.findRecursive(tlv, 0xc5);
if (fptlv == null) {
return null;
}
return fptlv.mV;
}
/** Return the fingerprint from application specific data stored on tag, or
* null if it doesn't exist.
*
* @param idx Index of the key to return the fingerprint from.
* @return The fingerprint of the requested key, or null if not found.
*/
public static byte[] nfcGetFingerprint(IsoDep isoDep, int idx) throws IOException {
byte[] data = nfcGetFingerprints(isoDep);
// return the master key fingerprint
ByteBuffer fpbuf = ByteBuffer.wrap(data);
byte[] fp = new byte[20];
fpbuf.get(fp, 20*idx, 20);
return fp;
} }
/** /**