moparisthebest/open-keychain
1
0
Fork 0
mirror of https://github.com/moparisthebest/open-keychain synced 2024-11-11 11:35:07 -05:00
Code Issues Releases Wiki Activity

import-log: use holder pattern in log fragment

Browse Source
This commit is contained in:
Vincent Breitmoser 2014-06-11 00:37:23 +02:00
parent 3895c10a58
commit 8d75d3e00e
1 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/LogDisplayFragment.java
View File

@ -5,8 +5,6 @@ import android.content.Intent;
import android.graphics.Color; import android.graphics.Color;
import android.os.Bundle; import android.os.Bundle;
import android.support.v4.app.ListFragment; import android.support.v4.app.ListFragment;
import android.support.v4.view.GestureDetectorCompat;
import android.support.v4.view.MotionEventCompat;
import android.util.TypedValue; import android.util.TypedValue;
import android.view.GestureDetector; import android.view.GestureDetector;
import android.view.GestureDetector.SimpleOnGestureListener; import android.view.GestureDetector.SimpleOnGestureListener;
@ -16,7 +14,6 @@ import android.view.View;
import android.view.View.OnTouchListener; import android.view.View.OnTouchListener;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.ArrayAdapter; import android.widget.ArrayAdapter;
import android.widget.Filterable;
import android.widget.ImageView; import android.widget.ImageView;
import android.widget.TextView; import android.widget.TextView;
@ -135,29 +132,40 @@ public class LogDisplayFragment extends ListFragment implements OnTouchListener
notifyDataSetChanged(); notifyDataSetChanged();
} }
private class ItemHolder {
final TextView mText;
final ImageView mImg;
public ItemHolder(TextView text, ImageView image) {
mText = text;
mImg = image;
}
}
@Override @Override
public View getView(int position, View convertView, ViewGroup parent) { public View getView(int position, View convertView, ViewGroup parent) {
LogEntryParcel entry = getItem(position); LogEntryParcel entry = getItem(position);
TextView text; ItemHolder ih;
if (convertView == null) { if (convertView == null) {
convertView = mInflater.inflate(R.layout.log_display_item, parent, false); convertView = mInflater.inflate(R.layout.log_display_item, parent, false);
text = (TextView) convertView.findViewById(R.id.log_text); ih = new ItemHolder(
convertView.setTag(text); (TextView) convertView.findViewById(R.id.log_text),
(ImageView) convertView.findViewById(R.id.log_img)
);
convertView.setTag(ih);
} else { } else {
text = (TextView) convertView.getTag(); ih = (ItemHolder) convertView.getTag();
} }
ImageView img = (ImageView) convertView.findViewById(R.id.log_img);
text.setText(getResources().getString(entry.mType.getMsgId(), (Object[]) entry.mParameters)); ih.mText.setText(getResources().getString(entry.mType.getMsgId(), (Object[]) entry.mParameters));
text.setTextColor(entry.mLevel == LogLevel.DEBUG ? Color.GRAY : Color.BLACK); ih.mText.setTextColor(entry.mLevel == LogLevel.DEBUG ? Color.GRAY : Color.BLACK);
convertView.setPadding((entry.mIndent) * dipFactor, 0, 0, 0); convertView.setPadding((entry.mIndent) * dipFactor, 0, 0, 0);
switch (entry.mLevel) { switch (entry.mLevel) {
case DEBUG: img.setBackgroundColor(Color.GRAY); break; case DEBUG: ih.mImg.setBackgroundColor(Color.GRAY); break;
case INFO: img.setBackgroundColor(Color.BLACK); break; case INFO: ih.mImg.setBackgroundColor(Color.BLACK); break;
case WARN: img.setBackgroundColor(Color.YELLOW); break; case WARN: ih.mImg.setBackgroundColor(Color.YELLOW); break;
case ERROR: img.setBackgroundColor(Color.RED); break; case ERROR: ih.mImg.setBackgroundColor(Color.RED); break;
case START: img.setBackgroundColor(Color.GREEN); break; case START: ih.mImg.setBackgroundColor(Color.GREEN); break;
case OK: img.setBackgroundColor(Color.GREEN); break; case OK: ih.mImg.setBackgroundColor(Color.GREEN); break;
} }
return convertView; return convertView;