From 608b66d192fcab62ab44d28c34171f9ca1aff38b Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Sat, 25 Apr 2015 03:39:40 +0200 Subject: [PATCH] change HttpsEditText to generic PrefixEditText --- .../LinkedIdCreateTwitterStep1Fragment.java | 2 +- ...sPrefixedText.java => PrefixedEditText.java} | 17 ++++++++++++----- .../linked_create_https_fragment_step1.xml | 4 +++- .../linked_create_twitter_fragment_step1.xml | 10 +++++++--- OpenKeychain/src/main/res/values/attr.xml | 4 ++++ 5 files changed, 27 insertions(+), 10 deletions(-) rename OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/{HttpsPrefixedText.java => PrefixedEditText.java} (63%) diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateTwitterStep1Fragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateTwitterStep1Fragment.java index c36f98058..d7c7a6f2e 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateTwitterStep1Fragment.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateTwitterStep1Fragment.java @@ -107,7 +107,7 @@ public class LinkedIdCreateTwitterStep1Fragment extends Fragment { }); mEditHandle = (EditText) view.findViewById(R.id.linked_create_twitter_handle); - mEditHandle.setText("v_debug"); + mEditHandle.setText(""); return view; } diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/HttpsPrefixedText.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/PrefixedEditText.java similarity index 63% rename from OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/HttpsPrefixedText.java rename to OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/PrefixedEditText.java index 292343eb7..3cbb114e8 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/HttpsPrefixedText.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/PrefixedEditText.java @@ -1,20 +1,27 @@ package org.sufficientlysecure.keychain.ui.widget; import android.content.Context; +import android.content.res.TypedArray; import android.graphics.*; import android.support.annotation.NonNull; import android.util.AttributeSet; import android.widget.EditText; -/** */ -public class HttpsPrefixedText extends EditText { +import org.sufficientlysecure.keychain.R; - private String mPrefix; // can be hardcoded for demo purposes +public class PrefixedEditText extends EditText { + + private String mPrefix; private Rect mPrefixRect = new Rect(); - public HttpsPrefixedText(Context context, AttributeSet attrs) { + public PrefixedEditText(Context context, AttributeSet attrs) { super(context, attrs); - mPrefix = "https://"; + TypedArray style = context.getTheme().obtainStyledAttributes( + attrs, R.styleable.PrefixedEditText, 0, 0); + mPrefix = style.getString(R.styleable.PrefixedEditText_prefix); + if (mPrefix == null) { + mPrefix = ""; + } } @Override diff --git a/OpenKeychain/src/main/res/layout/linked_create_https_fragment_step1.xml b/OpenKeychain/src/main/res/layout/linked_create_https_fragment_step1.xml index a18c1883a..8b6047e21 100644 --- a/OpenKeychain/src/main/res/layout/linked_create_https_fragment_step1.xml +++ b/OpenKeychain/src/main/res/layout/linked_create_https_fragment_step1.xml @@ -1,5 +1,6 @@ @@ -37,7 +38,7 @@ android:textAppearance="?android:attr/textAppearanceMedium" android:text="@string/linked_create_https_1_3" /> - + android:layout_height="match_parent" + > - + android:hint="@string/linked_create_twitter_handle" + custom:prefix="\@" + /> diff --git a/OpenKeychain/src/main/res/values/attr.xml b/OpenKeychain/src/main/res/values/attr.xml index 7a2f3054e..74584a1e5 100644 --- a/OpenKeychain/src/main/res/values/attr.xml +++ b/OpenKeychain/src/main/res/values/attr.xml @@ -29,4 +29,8 @@ + + + + \ No newline at end of file