mirror of
https://github.com/moparisthebest/open-keychain
synced 2024-11-27 11:12:15 -05:00
tests: add a couple of CertifyOperation test cases
This commit is contained in:
Vincent Breitmoser
parent
07251f35ae
commit
0c3f9ae0a6
@ -0,0 +1,238 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2014 Vincent Breitmoser <v.breitmoser@mugenguild.com>
|
||||||
|
*
|
||||||
|
* This program is free software: you can redistribute it and/or modify
|
||||||
|
* it under the terms of the GNU General Public License as published by
|
||||||
|
* the Free Software Foundation, either version 3 of the License, or
|
||||||
|
* (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This program is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
* GNU General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU General Public License
|
||||||
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package org.sufficientlysecure.keychain.operations;
|
||||||
|
|
||||||
|
import org.junit.Assert;
|
||||||
|
import org.junit.Before;
|
||||||
|
import org.junit.BeforeClass;
|
||||||
|
import org.junit.Test;
|
||||||
|
import org.junit.runner.RunWith;
|
||||||
|
import org.robolectric.Robolectric;
|
||||||
|
import org.robolectric.RobolectricTestRunner;
|
||||||
|
import org.robolectric.shadows.ShadowLog;
|
||||||
|
import org.spongycastle.bcpg.sig.KeyFlags;
|
||||||
|
import org.spongycastle.jce.provider.BouncyCastleProvider;
|
||||||
|
import org.sufficientlysecure.keychain.operations.results.CertifyResult;
|
||||||
|
import org.sufficientlysecure.keychain.operations.results.OperationResult.LogType;
|
||||||
|
import org.sufficientlysecure.keychain.operations.results.PgpEditKeyResult;
|
||||||
|
import org.sufficientlysecure.keychain.operations.results.ExportResult;
|
||||||
|
import org.sufficientlysecure.keychain.operations.results.OperationResult.OperationLog;
|
||||||
|
import org.sufficientlysecure.keychain.pgp.CanonicalizedPublicKeyRing;
|
||||||
|
import org.sufficientlysecure.keychain.pgp.PgpDecryptVerify;
|
||||||
|
import org.sufficientlysecure.keychain.pgp.PgpKeyOperation;
|
||||||
|
import org.sufficientlysecure.keychain.pgp.UncachedKeyRing;
|
||||||
|
import org.sufficientlysecure.keychain.pgp.UncachedKeyRing.IteratorWithIOThrow;
|
||||||
|
import org.sufficientlysecure.keychain.pgp.WrappedSignature;
|
||||||
|
import org.sufficientlysecure.keychain.provider.KeychainContract.Certs;
|
||||||
|
import org.sufficientlysecure.keychain.provider.ProviderHelper;
|
||||||
|
import org.sufficientlysecure.keychain.service.CertifyActionsParcel;
|
||||||
|
import org.sufficientlysecure.keychain.service.CertifyActionsParcel.CertifyAction;
|
||||||
|
import org.sufficientlysecure.keychain.service.SaveKeyringParcel;
|
||||||
|
import org.sufficientlysecure.keychain.service.SaveKeyringParcel.Algorithm;
|
||||||
|
import org.sufficientlysecure.keychain.service.SaveKeyringParcel.ChangeUnlockParcel;
|
||||||
|
import org.sufficientlysecure.keychain.util.InputData;
|
||||||
|
import org.sufficientlysecure.keychain.util.ProgressScaler;
|
||||||
|
import org.sufficientlysecure.keychain.util.TestingUtils;
|
||||||
|
|
||||||
|
import java.io.ByteArrayInputStream;
|
||||||
|
import java.io.ByteArrayOutputStream;
|
||||||
|
import java.io.OutputStream;
|
||||||
|
import java.io.PrintStream;
|
||||||
|
import java.security.Security;
|
||||||
|
import java.util.Iterator;
|
||||||
|
|
||||||
|
@RunWith(RobolectricTestRunner.class)
|
||||||
|
@org.robolectric.annotation.Config(emulateSdk = 18) // Robolectric doesn't yet support 19
|
||||||
|
public class CertifyOperationTest {
|
||||||
|
|
||||||
|
static String mPassphrase = TestingUtils.genPassphrase(true);
|
||||||
|
|
||||||
|
static UncachedKeyRing mStaticRing1, mStaticRing2;
|
||||||
|
static String mKeyPhrase1 = TestingUtils.genPassphrase(true);
|
||||||
|
static String mKeyPhrase2 = TestingUtils.genPassphrase(true);
|
||||||
|
|
||||||
|
static PrintStream oldShadowStream;
|
||||||
|
|
||||||
|
@BeforeClass
|
||||||
|
public static void setUpOnce() throws Exception {
|
||||||
|
Security.insertProviderAt(new BouncyCastleProvider(), 1);
|
||||||
|
oldShadowStream = ShadowLog.stream;
|
||||||
|
// ShadowLog.stream = System.out;
|
||||||
|
|
||||||
|
PgpKeyOperation op = new PgpKeyOperation(null);
|
||||||
|
|
||||||
|
{
|
||||||
|
SaveKeyringParcel parcel = new SaveKeyringParcel();
|
||||||
|
parcel.mAddSubKeys.add(new SaveKeyringParcel.SubkeyAdd(
|
||||||
|
Algorithm.RSA, 1024, null, KeyFlags.CERTIFY_OTHER, 0L));
|
||||||
|
parcel.mAddSubKeys.add(new SaveKeyringParcel.SubkeyAdd(
|
||||||
|
Algorithm.DSA, 1024, null, KeyFlags.SIGN_DATA, 0L));
|
||||||
|
parcel.mAddSubKeys.add(new SaveKeyringParcel.SubkeyAdd(
|
||||||
|
Algorithm.ELGAMAL, 1024, null, KeyFlags.ENCRYPT_COMMS, 0L));
|
||||||
|
parcel.mAddUserIds.add("derp");
|
||||||
|
parcel.mNewUnlock = new ChangeUnlockParcel(mKeyPhrase1);
|
||||||
|
|
||||||
|
PgpEditKeyResult result = op.createSecretKeyRing(parcel);
|
||||||
|
Assert.assertTrue("initial test key creation must succeed", result.success());
|
||||||
|
Assert.assertNotNull("initial test key creation must succeed", result.getRing());
|
||||||
|
|
||||||
|
mStaticRing1 = result.getRing();
|
||||||
|
}
|
||||||
|
|
||||||
|
{
|
||||||
|
SaveKeyringParcel parcel = new SaveKeyringParcel();
|
||||||
|
parcel.mAddSubKeys.add(new SaveKeyringParcel.SubkeyAdd(
|
||||||
|
Algorithm.RSA, 1024, null, KeyFlags.CERTIFY_OTHER, 0L));
|
||||||
|
parcel.mAddSubKeys.add(new SaveKeyringParcel.SubkeyAdd(
|
||||||
|
Algorithm.DSA, 1024, null, KeyFlags.SIGN_DATA, 0L));
|
||||||
|
parcel.mAddSubKeys.add(new SaveKeyringParcel.SubkeyAdd(
|
||||||
|
Algorithm.ELGAMAL, 1024, null, KeyFlags.ENCRYPT_COMMS, 0L));
|
||||||
|
parcel.mAddUserIds.add("ditz");
|
||||||
|
parcel.mNewUnlock = new ChangeUnlockParcel(null, "1234");
|
||||||
|
|
||||||
|
PgpEditKeyResult result = op.createSecretKeyRing(parcel);
|
||||||
|
Assert.assertTrue("initial test key creation must succeed", result.success());
|
||||||
|
Assert.assertNotNull("initial test key creation must succeed", result.getRing());
|
||||||
|
|
||||||
|
mStaticRing2 = result.getRing();
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
@Before
|
||||||
|
public void setUp() throws Exception {
|
||||||
|
ProviderHelper providerHelper = new ProviderHelper(Robolectric.application);
|
||||||
|
|
||||||
|
// don't log verbosely here, we're not here to test imports
|
||||||
|
ShadowLog.stream = oldShadowStream;
|
||||||
|
|
||||||
|
providerHelper.saveSecretKeyRing(mStaticRing1, new ProgressScaler());
|
||||||
|
providerHelper.savePublicKeyRing(mStaticRing2.extractPublicKeyRing(), new ProgressScaler());
|
||||||
|
|
||||||
|
// ok NOW log verbosely!
|
||||||
|
ShadowLog.stream = System.out;
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testSelfCertifyFlag() throws Exception {
|
||||||
|
|
||||||
|
CanonicalizedPublicKeyRing ring = new ProviderHelper(Robolectric.application)
|
||||||
|
.getCanonicalizedPublicKeyRing(mStaticRing1.getMasterKeyId());
|
||||||
|
Assert.assertEquals("secret key must be marked self-certified in database",
|
||||||
|
// TODO this should be more correctly be VERIFIED_SELF at some point!
|
||||||
|
Certs.VERIFIED_SECRET, ring.getVerified());
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testCertify() throws Exception {
|
||||||
|
CertifyOperation op = operationWithFakePassphraseCache(
|
||||||
|
mStaticRing1.getMasterKeyId(), mStaticRing1.getMasterKeyId(), mKeyPhrase1);
|
||||||
|
|
||||||
|
{
|
||||||
|
CanonicalizedPublicKeyRing ring = new ProviderHelper(Robolectric.application)
|
||||||
|
.getCanonicalizedPublicKeyRing(mStaticRing2.getMasterKeyId());
|
||||||
|
Assert.assertEquals("public key must not be marked verified prior to certification",
|
||||||
|
Certs.UNVERIFIED, ring.getVerified());
|
||||||
|
}
|
||||||
|
|
||||||
|
CertifyActionsParcel actions = new CertifyActionsParcel(mStaticRing1.getMasterKeyId());
|
||||||
|
actions.add(new CertifyAction(mStaticRing2.getMasterKeyId()));
|
||||||
|
CertifyResult result = op.certify(actions, null);
|
||||||
|
|
||||||
|
Assert.assertTrue("certification must succeed", result.success());
|
||||||
|
|
||||||
|
{
|
||||||
|
CanonicalizedPublicKeyRing ring = new ProviderHelper(Robolectric.application)
|
||||||
|
.getCanonicalizedPublicKeyRing(mStaticRing2.getMasterKeyId());
|
||||||
|
Assert.assertEquals("new key must be verified now",
|
||||||
|
Certs.VERIFIED_SECRET, ring.getVerified());
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testCertifySelf() throws Exception {
|
||||||
|
CertifyOperation op = operationWithFakePassphraseCache(
|
||||||
|
mStaticRing1.getMasterKeyId(), mStaticRing1.getMasterKeyId(), mKeyPhrase1);
|
||||||
|
|
||||||
|
CertifyActionsParcel actions = new CertifyActionsParcel(mStaticRing1.getMasterKeyId());
|
||||||
|
actions.add(new CertifyAction(mStaticRing1.getMasterKeyId()));
|
||||||
|
|
||||||
|
CertifyResult result = op.certify(actions, null);
|
||||||
|
|
||||||
|
Assert.assertFalse("certification with itself must fail!", result.success());
|
||||||
|
Assert.assertTrue("error msg must be about self certification",
|
||||||
|
result.getLog().containsType(LogType.MSG_CRT_ERROR_SELF));
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testCertifyNonexistent() throws Exception {
|
||||||
|
|
||||||
|
CertifyOperation op = operationWithFakePassphraseCache(null, null, mKeyPhrase1);
|
||||||
|
|
||||||
|
{
|
||||||
|
CertifyActionsParcel actions = new CertifyActionsParcel(mStaticRing1.getMasterKeyId());
|
||||||
|
actions.add(new CertifyAction(1234L));
|
||||||
|
|
||||||
|
CertifyResult result = op.certify(actions, null);
|
||||||
|
|
||||||
|
Assert.assertFalse("certification of nonexistent key must fail", result.success());
|
||||||
|
Assert.assertTrue("must contain error msg about not found",
|
||||||
|
result.getLog().containsType(LogType.MSG_CRT_WARN_NOT_FOUND));
|
||||||
|
}
|
||||||
|
|
||||||
|
{
|
||||||
|
CertifyActionsParcel actions = new CertifyActionsParcel(1234L);
|
||||||
|
actions.add(new CertifyAction(mStaticRing1.getMasterKeyId()));
|
||||||
|
|
||||||
|
CertifyResult result = op.certify(actions, null);
|
||||||
|
|
||||||
|
Assert.assertFalse("certification of nonexistent key must fail", result.success());
|
||||||
|
Assert.assertTrue("must contain error msg about not found",
|
||||||
|
result.getLog().containsType(LogType.MSG_CRT_ERROR_MASTER_NOT_FOUND));
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
private CertifyOperation operationWithFakePassphraseCache(
|
||||||
|
final Long checkMasterKeyId, final Long checkSubKeyId, final String passphrase) {
|
||||||
|
|
||||||
|
return new CertifyOperation(Robolectric.application,
|
||||||
|
new ProviderHelper(Robolectric.application),
|
||||||
|
null, null) {
|
||||||
|
@Override
|
||||||
|
public String getCachedPassphrase(long masterKeyId, long subKeyId)
|
||||||
|
throws NoSecretKeyException {
|
||||||
|
if (checkMasterKeyId != null) {
|
||||||
|
Assert.assertEquals("requested passphrase should be for expected master key id",
|
||||||
|
(long) checkMasterKeyId, masterKeyId);
|
||||||
|
}
|
||||||
|
if (checkSubKeyId != null) {
|
||||||
|
Assert.assertEquals("requested passphrase should be for expected sub key id",
|
||||||
|
(long) checkSubKeyId, subKeyId);
|
||||||
|
}
|
||||||
|
if (passphrase == null) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
return passphrase;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
||||||
Loading…
Reference in New Issue
Block a user