mirror of
https://github.com/moparisthebest/minetest
synced 2024-12-22 15:48:48 -05:00
80cebdc23c
Sometimes you accidentally forget the quotes when using global_exists, this makes minetest abort if you did so. M builtin/common/strict.lua
57 lines
1.6 KiB
Lua
57 lines
1.6 KiB
Lua
|
|
-- Always warn when creating a global variable, even outside of a function.
|
|
-- This ignores mod namespaces (variables with the same name as the current mod).
|
|
local WARN_INIT = false
|
|
|
|
|
|
function core.global_exists(name)
|
|
if type(name) ~= "string" then
|
|
error("core.global_exists: " .. tostring(name) .. " is not a string")
|
|
end
|
|
return rawget(_G, name) ~= nil
|
|
end
|
|
|
|
|
|
local meta = {}
|
|
local declared = {}
|
|
-- Key is source file, line, and variable name; seperated by NULs
|
|
local warned = {}
|
|
|
|
function meta:__newindex(name, value)
|
|
local info = debug.getinfo(2, "Sl")
|
|
local desc = ("%s:%d"):format(info.short_src, info.currentline)
|
|
if not declared[name] then
|
|
local warn_key = ("%s\0%d\0%s"):format(info.source,
|
|
info.currentline, name)
|
|
if not warned[warn_key] and info.what ~= "main" and
|
|
info.what ~= "C" then
|
|
core.log("warning", ("Assignment to undeclared "..
|
|
"global %q inside a function at %s.")
|
|
:format(name, desc))
|
|
warned[warn_key] = true
|
|
end
|
|
declared[name] = true
|
|
end
|
|
-- Ignore mod namespaces
|
|
if WARN_INIT and name ~= core.get_current_modname() then
|
|
core.log("warning", ("Global variable %q created at %s.")
|
|
:format(name, desc))
|
|
end
|
|
rawset(self, name, value)
|
|
end
|
|
|
|
|
|
function meta:__index(name)
|
|
local info = debug.getinfo(2, "Sl")
|
|
local warn_key = ("%s\0%d\0%s"):format(info.source, info.currentline, name)
|
|
if not declared[name] and not warned[warn_key] and info.what ~= "C" then
|
|
core.log("warning", ("Undeclared global variable %q accessed at %s:%s")
|
|
:format(name, info.short_src, info.currentline))
|
|
warned[warn_key] = true
|
|
end
|
|
return rawget(self, name)
|
|
end
|
|
|
|
setmetatable(_G, meta)
|
|
|